From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754407AbdEIOWq (ORCPT ); Tue, 9 May 2017 10:22:46 -0400 Received: from mout.web.de ([212.227.17.11]:61844 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751742AbdEIOWo (ORCPT ); Tue, 9 May 2017 10:22:44 -0400 Subject: [PATCH 1/4] hamradio: Combine two seq_printf() calls into one in yam_seq_show() From: SF Markus Elfring To: linux-hams@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Javier Martinez Canillas , Jean-Paul Roubelat Cc: LKML , kernel-janitors@vger.kernel.org References: <4c5c939a-bd55-7b88-8e41-49f5544b7658@users.sourceforge.net> Message-ID: Date: Tue, 9 May 2017 16:22:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <4c5c939a-bd55-7b88-8e41-49f5544b7658@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:7cdW6hBaguu5p/wMs3Y8Y+8YMBQ2li6CHTX2qkGv2qeLJjJiIAb kNnnfm67m4RNq0I07Ocxe7I0cm/Jdo1G9+JIfyV5AyU8Z8YS6o4FXDshDdshTrx1h9K5lxR UkBTBdfMEdvaqb1hSl7fENUgFuv0DqaOwOzTA43Vrlso2K6unWjJ0kTmHYGSKyL/v4tD0cH lxmGYOaKpLNkY96YYuZDQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:wxpf2LgH09w=:CL/Njx++YZvUBYU31nzgdM sDS202hMyuStNH05zy/0g84oIF3j3hlUI3chrlNjpFXTxKObhtNlGuwizMGQxCtADVxUuCUg9 61f9xHD7YPe+5kq+/CAnutIRrdvXFOc6CgWxQHe48rW6k0BTO1mwV4G/CfwaggNLgxXQ2UYlE jj/bx8orByTEU4/NJTERmlDRSYqVI77OM7BxSUI2m2OsyrhR1ou2kvmJYFeDtkPfbtKEd+Qxj L3rVtyWwjBKhYa9cBVjowK+hkY95aTKAQ8BXStJRo4fZyLttCiOYDCrPBoiAFNePVOxouYgnY QiF1wSJmWgoIZ8WWs/jX6m3GOEBVWsjIIYSpJ8OivdH9feMvK8R5g/R0q5qCOkptW/pi2lL6Y jPTJbaXRIXm9f2jHVkKxWr905dnpR1YCQbBvsgVnYHV1DLsbDphJDUvDuJiFGvocDJIm7D0pA GiAcgNcQN7i6id25UiqZVaA0FyagRDTZAPoS+z0f8ZO44mVEKSobk6l10KnGle134S/pu6IZJ 1piTKB20qCC9H/BZX+x+mx5J+W365SWqPTRmSDPYsUKB1AJsg9iYGMqxrZKWfR5QtxW3KNAo3 DRTRJKMCvGnaXfWnqe8GjVQ5AW/E5FEiiZ4xz1ZuBwy7S6n0BFrnJNFizTBCnXqn91C908yqh HwBHr3TzVhahLTGoddTN9ddj4JMEKO2AH229ITLh6ZUgccEvOqCs80c5/be0weOQ2kWFsInBk EH84mmqPbrvSJUksuaynDmyuD7DhnP2/myiVnW0FrLV3Zzi1ynXeZx78x1Nsr7se6M1ctmG4J mJwVREC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 9 May 2017 14:16:45 +0200 A bit of data was put into a sequence by two separate function calls. Print the same data by a single function call instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/hamradio/yam.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c index b6891ada1d7b..542f1e511df1 100644 --- a/drivers/net/hamradio/yam.c +++ b/drivers/net/hamradio/yam.c @@ -830,8 +830,7 @@ static int yam_seq_show(struct seq_file *seq, void *v) seq_printf(seq, " RxFrames %lu\n", dev->stats.rx_packets); seq_printf(seq, " TxInt %u\n", yp->nb_mdint); seq_printf(seq, " RxInt %u\n", yp->nb_rxint); - seq_printf(seq, " RxOver %lu\n", dev->stats.rx_fifo_errors); - seq_printf(seq, "\n"); + seq_printf(seq, " RxOver %lu\n\n", dev->stats.rx_fifo_errors); return 0; } -- 2.12.2