From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06E82C001B0 for ; Mon, 24 Jul 2023 09:14:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232192AbjGXJOz (ORCPT ); Mon, 24 Jul 2023 05:14:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232152AbjGXJOn (ORCPT ); Mon, 24 Jul 2023 05:14:43 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC2AE1B0 for ; Mon, 24 Jul 2023 02:13:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690190034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2oPDYvwpZtu0Ko50jtkdQDGuMOTIWCRCGf2FetUqVmk=; b=VGJkn90QFxetVFTML/KZga4fs3BGD1RZk9y1LAfU7qjzF+26SqRuXPJ6ZtU1Z9K4zZuGDf ud7iwTVHepqxYqkG2vaui1JdH2NRhow0HcjpszzUbz6H1j8V7GY0A5JiQzJCLIjMeyoW+Q jyFHViDNfJ6FTWCt+BqOjbAJq5sQ1Tg= Received: from mail-oa1-f71.google.com (mail-oa1-f71.google.com [209.85.160.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-UvYQZFpYOuOxV0vgqXm61g-1; Mon, 24 Jul 2023 05:13:52 -0400 X-MC-Unique: UvYQZFpYOuOxV0vgqXm61g-1 Received: by mail-oa1-f71.google.com with SMTP id 586e51a60fabf-1bb64b02f8fso125277fac.0 for ; Mon, 24 Jul 2023 02:13:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690190032; x=1690794832; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2oPDYvwpZtu0Ko50jtkdQDGuMOTIWCRCGf2FetUqVmk=; b=ayfkuGdphCSr82bWiWt7Wd9TI4ysm2y4reEJ3KKRs9zsBEHmjsshbiyU4nH6pzpEsS bqDFUAZmxbZCXWRNLTGvCuDmRTpvbGfHdw0J9QwUIXpkkWagJyy95K1y+WMuom3/hnqa Ss58AevPMVhH7eZMq01Qva38rQWQ8Ipi4jRYecwzdAbII6sqGlpUSzjiwy7MoFeFNgFV SuiONPF0fXneU/kgpikytJoA1dZSFZUMfSthJ5O6YA+3w4m+1QK7mgo5ex4yTmb+h9wq TeGTOOOLA0tHGsKWGIKvNit+iJl0cfHYJy1QAcV3mQPt7h0+7XBehru4lEfGfqw1M2bH 5TqA== X-Gm-Message-State: ABy/qLZa6VKowQQd6QmQKiNVRsR8N6FIyl2pL5FJxkCF4D1HHHMloQgc HBiI/Mb0Nlh6QRhbf41uzIf53M5AS+BfNQUR1ThuamDVFDque7+h4mPLLbIXdL0I1Ubb5FIgWP6 xkr0Rwdr7yCLGiqCje6BNSdaO X-Received: by 2002:a05:6870:568e:b0:1b7:613c:2e30 with SMTP id p14-20020a056870568e00b001b7613c2e30mr7564440oao.2.1690190032046; Mon, 24 Jul 2023 02:13:52 -0700 (PDT) X-Google-Smtp-Source: APBJJlGz31tvB+wfj4JC9JljpAdnVVugjKH/UFomLvpFW9yVXyN8NXs0fQCdMnGqdTxGWM2Ywaca6g== X-Received: by 2002:a05:6870:568e:b0:1b7:613c:2e30 with SMTP id p14-20020a056870568e00b001b7613c2e30mr7564429oao.2.1690190031838; Mon, 24 Jul 2023 02:13:51 -0700 (PDT) Received: from [10.66.61.39] ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id w6-20020a63af06000000b0050f85ef50d1sm7977675pge.26.2023.07.24.02.13.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jul 2023 02:13:51 -0700 (PDT) Message-ID: Date: Mon, 24 Jul 2023 17:13:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v7 03/12] KVM: Remove CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL Content-Language: en-US To: Raghavendra Rao Ananta , Oliver Upton , Marc Zyngier , James Morse , Suzuki K Poulose Cc: Paolo Bonzini , Sean Christopherson , Huacai Chen , Zenghui Yu , Anup Patel , Atish Patra , Jing Zhang , Reiji Watanabe , Colton Lewis , David Matlack , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20230722022251.3446223-1-rananta@google.com> <20230722022251.3446223-4-rananta@google.com> From: Shaoqin Huang In-Reply-To: <20230722022251.3446223-4-rananta@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/22/23 10:22, Raghavendra Rao Ananta wrote: > kvm_arch_flush_remote_tlbs() or CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL > are two mechanisms to solve the same problem, allowing > architecture-specific code to provide a non-IPI implementation of > remote TLB flushing. > > Dropping CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL allows KVM to standardize > all architectures on kvm_arch_flush_remote_tlbs() instead of > maintaining two mechanisms. > > Signed-off-by: Raghavendra Rao Ananta Reviewed-by: Shaoqin Huang > --- > virt/kvm/Kconfig | 3 --- > virt/kvm/kvm_main.c | 2 -- > 2 files changed, 5 deletions(-) > > diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig > index b74916de5183..484d0873061c 100644 > --- a/virt/kvm/Kconfig > +++ b/virt/kvm/Kconfig > @@ -62,9 +62,6 @@ config HAVE_KVM_CPU_RELAX_INTERCEPT > config KVM_VFIO > bool > > -config HAVE_KVM_ARCH_TLB_FLUSH_ALL > - bool > - > config HAVE_KVM_INVALID_WAKEUPS > bool > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 70e5479797ac..d6b050786155 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -345,7 +345,6 @@ bool kvm_make_all_cpus_request(struct kvm *kvm, unsigned int req) > } > EXPORT_SYMBOL_GPL(kvm_make_all_cpus_request); > > -#ifndef CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL > void kvm_flush_remote_tlbs(struct kvm *kvm) > { > ++kvm->stat.generic.remote_tlb_flush_requests; > @@ -366,7 +365,6 @@ void kvm_flush_remote_tlbs(struct kvm *kvm) > ++kvm->stat.generic.remote_tlb_flush; > } > EXPORT_SYMBOL_GPL(kvm_flush_remote_tlbs); > -#endif > > static void kvm_flush_shadow_all(struct kvm *kvm) > { -- Shaoqin