From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mihai Sain <mihai.sain@microchip.com>,
claudiu.beznea@tuxon.dev, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] ARM: dts: microchip: sam9x60_curiosity: Add power-supply properties for sdmmc nodes
Date: Tue, 23 Jan 2024 09:46:23 +0100 [thread overview]
Message-ID: <c289a167-031a-44cc-ab62-0fb0adcab2bb@linaro.org> (raw)
In-Reply-To: <20240123083158.7339-2-mihai.sain@microchip.com>
On 23/01/2024 09:31, Mihai Sain wrote:
> The sdmmc0 and sdmmc1 controllers are powered from 3.3V regulator.
> Add vmmc-supply and vqmmc-supply properties to sdmmc nodes.
>
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---
> arch/arm/boot/dts/microchip/at91-sam9x60_curiosity.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/microchip/at91-sam9x60_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sam9x60_curiosity.dts
> index c6fbdd29019f..457c54dde0b7 100644
> --- a/arch/arm/boot/dts/microchip/at91-sam9x60_curiosity.dts
> +++ b/arch/arm/boot/dts/microchip/at91-sam9x60_curiosity.dts
> @@ -452,6 +452,8 @@ &sdmmc0 {
> pinctrl-0 = <&pinctrl_sdmmc0_default &pinctrl_sdmmc0_cd>;
> cd-gpios = <&pioA 25 GPIO_ACTIVE_LOW>;
> disable-wp;
> + vmmc-supply = <&vdd1_3v3>;
> + vqmmc-supply = <&vdd1_3v3>;
For this and all other patches:
It is surprising that you use the same supply for both. Looks like
inaccurate description. It is possible, but I think unlikely because
usually VQMMC has lower voltage than 3.3V.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-23 8:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 8:31 [PATCH 0/8] Add power-supply properties for sdmmc nodes on Microchip boards Mihai Sain
2024-01-23 8:31 ` [PATCH 1/8] ARM: dts: microchip: sam9x60_curiosity: Add power-supply properties for sdmmc nodes Mihai Sain
2024-01-23 8:46 ` Krzysztof Kozlowski [this message]
2024-01-23 9:07 ` Mihai.Sain
2024-01-23 9:58 ` Krzysztof Kozlowski
2024-02-03 16:55 ` claudiu beznea
2024-01-23 8:31 ` [PATCH 2/8] ARM: dts: microchip: sam9x60ek: " Mihai Sain
2024-01-23 8:31 ` [PATCH 3/8] ARM: dts: microchip: sama5d27_som1_ek: " Mihai Sain
2024-01-23 8:31 ` [PATCH 4/8] ARM: dts: microchip: sama5d27_wlsom1: Add power-supply property for sdmmc1 node Mihai Sain
2024-01-23 8:31 ` [PATCH 5/8] ARM: dts: microchip: sama5d27_wlsom1_ek: Add power-supply property for sdmmc0 node Mihai Sain
2024-01-23 8:31 ` [PATCH 6/8] ARM: dts: microchip: sama5d29_curiosity: Add power-supply properties for sdmmc nodes Mihai Sain
2024-01-23 8:31 ` [PATCH 7/8] ARM: dts: microchip: sama5d2_icp: Add power-supply property for sdmmc0 node Mihai Sain
2024-01-23 8:31 ` [PATCH 8/8] ARM: dts: microchip: sama5d2_xplained: " Mihai Sain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c289a167-031a-44cc-ab62-0fb0adcab2bb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.sain@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®