From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761491AbcIXHtV (ORCPT ); Sat, 24 Sep 2016 03:49:21 -0400 Received: from mout.web.de ([212.227.15.3]:63446 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757734AbcIXHtU (ORCPT ); Sat, 24 Sep 2016 03:49:20 -0400 To: linux-ide@vger.kernel.org, "David S. Miller" Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Subject: [PATCH] ide: Use kmalloc_array() in hwif_init() Message-ID: Date: Sat, 24 Sep 2016 09:49:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:qidULB2cLPTumiFS5hNN2+a1EoXs+Sqzs+DAOxym9BGubr1xmJl 8Mf8CYd5oQouq8yq3Iz0YI1Y23mHJcfluosQqMS2ST8AoJtycnbZd5Zj9nHbCX8m4xEFJkf M7V3csENBIrjSC4ROdLEn0JixSbHqUGx9n42fWsaL+DvXYtiyYHPrVKdidDqT83eoBzfyAR 28jgzPD+kbwTxI90hWKgg== X-UI-Out-Filterresults: notjunk:1;V01:K0:7J9XAJl7Oeo=:W5D0ICMwMMXbwaHLng+6jT 2gCtDkpz7FqiTaFDXd02FL5czNCDh5LxxhFeI/K16UMPoYImj69KsQDgGbtnezww+niCy+ila D1Lrw9BJvwkW3ObGJyJcfI7iSSrK4WbrgEePQgpHKnX2oGLzJtdylJ1LEZywB5SrTW1UmhVY2 wlXfCxDbaDFBshO6rZS7dbSRjXRzWvSc7CTg7Xh1JbZ+Dp1affj1AeqEkeiAoQ9ZbMf+Waxsx boJjX/fAahIk9VDBD8GOgTngBIrZk0wCnWHP7UI8BiaWCJpvOxugTcO9GHWjpCTR+nhxgAjJ0 Odnh9aAew0Ja1YF39r9Y66nb13PVq8fLtsHY97jlm69+cu2X/bi1TEmBjtRMZhsVsPOpkrHBe jAbGdYML/vfbTdGRZmbMzVvYd5HpLlGq7UQfeWOzNttRjG9FqEicB2+quMyEu30+vVM4VJWc7 eqbmK5hWe5ewBH5vEdkjpFL7HmrJhB0uyKjQPTgqxAC8whJkAuA3iMvdBc36Zgu2FGlPaXKT8 1FiEnapn0yGcSGzAdJGCTyOEKqe1QTzgRy/untqQIKSbE0udz9ZrYKiYvo0uysw2h1UHZ8RpO PgVGEerEgE4lDVCBSV0GOe3+CZjfI2HTCoBYTJmg+L4WJJPwrS3zUtrtsHhxcttf4bDpyDLIE NZ4Rn8938LBNW7oDJ1l+SJeVgIO4yD4Ay3iUujG66mgNYiSnFW0OdDSEYuppphzk5TjwqsaDl 4XlpWJUkGgI6J+pUSytWut595Er2ehRwsVchpWe8iAhIXcW6ODZYvhDhb25VorwJBSmWT0AQ0 BbbmN6Q Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 24 Sep 2016 09:39:03 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/ide/ide-probe.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c index 0b63fac..645a67b 100644 --- a/drivers/ide/ide-probe.c +++ b/drivers/ide/ide-probe.c @@ -973,8 +973,9 @@ static int hwif_init(ide_hwif_t *hwif) if (!hwif->sg_max_nents) hwif->sg_max_nents = PRD_ENTRIES; - hwif->sg_table = kmalloc(sizeof(struct scatterlist)*hwif->sg_max_nents, - GFP_KERNEL); + hwif->sg_table = kmalloc_array(hwif->sg_max_nents, + sizeof(*hwif->sg_table), + GFP_KERNEL); if (!hwif->sg_table) { printk(KERN_ERR "%s: unable to allocate SG table.\n", hwif->name); goto out; -- 2.10.0