mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dyoung@redhat.com" <dyoung@redhat.com>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"bhe@redhat.com" <bhe@redhat.com>,
	"vgoyal@redhat.com" <vgoyal@redhat.com>,
	"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"andriy.shevchenko@linux.intel.com" 
	<andriy.shevchenko@linux.intel.com>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"halves@canonical.com" <halves@canonical.com>,
	"kernel@gpiccoli.net" <kernel@gpiccoli.net>
Subject: Re: [PATCH] notifier/panic: Introduce panic_notifier_filter
Date: Sat, 8 Jan 2022 12:36:32 -0300	[thread overview]
Message-ID: <c2923957-9719-ef23-802a-24765ead7630@igalia.com> (raw)
In-Reply-To: <CAHp75Vf8SisR16tK=hwiF9ET0PoQRcu1h5LCZHZAGX8M3KysRA@mail.gmail.com>

On 07/01/2022 20:07, Andy Shevchenko wrote:
> [...] 
>     +       if (!buf)
>     +               return -EINVAL;
> 
> 
> I also implied that you don’t need this condition.
> 
>     +       while ((func = strsep(&buf, ","))) {
>     +               addr = kallsyms_lookup_name(func);
> 
>  
> 
>     +
> 
> 
> Btw, this is redundant blank line.
>  
> 
>     +               if (!addr) {

Thanks Andy, just submitted a V4 that incorporates your suggestions.
Cheers,


Guilherme

  parent reply	other threads:[~2022-01-08 15:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07 19:12 [PATCH V3] " Guilherme G. Piccoli
     [not found] ` <CAHp75Vf8SisR16tK=hwiF9ET0PoQRcu1h5LCZHZAGX8M3KysRA@mail.gmail.com>
2022-01-08 15:36   ` Guilherme G. Piccoli [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-01-06 16:27 [PATCH] " Guilherme G. Piccoli
2022-01-06 20:01 ` Guilherme G. Piccoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2923957-9719-ef23-802a-24765ead7630@igalia.com \
    --to=gpiccoli@igalia.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bhe@redhat.com \
    --cc=corbet@lwn.net \
    --cc=dyoung@redhat.com \
    --cc=halves@canonical.com \
    --cc=kernel@gpiccoli.net \
    --cc=kexec@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®