From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752671AbdEJJMF (ORCPT ); Wed, 10 May 2017 05:12:05 -0400 Received: from www381.your-server.de ([78.46.137.84]:35353 "EHLO www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751735AbdEJJMD (ORCPT ); Wed, 10 May 2017 05:12:03 -0400 Subject: Re: [PATCH v2] iio:ad5064: Add support for ltc2633 and similar devices To: Mike Looijmans , linux-iio@vger.kernel.org References: <1493199875-11912-1-git-send-email-mike.looijmans@topic.nl> <646b634f-c0ad-f39c-a395-02461f5e8352@metafoo.de> <1494228384-28786-1-git-send-email-mike.looijmans@topic.nl> Cc: linux-kernel@vger.kernel.org, Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net From: Lars-Peter Clausen Message-ID: Date: Wed, 10 May 2017 11:12:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <1494228384-28786-1-git-send-email-mike.looijmans@topic.nl> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Authenticated-Sender: lars@metafoo.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/08/2017 09:26 AM, Mike Looijmans wrote: > The Linear Technology LTC2631, LTC2633 and LTC2635 are very similar > to the AD5064 device, in particular the LTC2627. > > This patch adds support for those devices. Only the LTC2633 has been > tested, which is the 2-channel variant. The LTC2631 is the 1-channel, > and the LTC2635 the 4-channel version. The actual DAC resolution depends > on the exact chip type and can be 12, 10 or 8 bits, using the upper bits > so this has no effect on the register map. The internal reference is set > to 2.5V on "L" versions, and it's 4.096V for "H" versions. > > Datasheets: > LTC2631: http://www.linear.com/docs/26553 > LTC2633: http://www.linear.com/docs/39529 > LTC2635: http://www.linear.com/docs/28754 > > Signed-off-by: Mike Looijmans Reviewed-by: Lars-Peter Clausen Thanks for reworking the patch.