From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751593AbbJRSzF (ORCPT ); Sun, 18 Oct 2015 14:55:05 -0400 Received: from giles.leenox.de ([5.9.156.120]:50701 "EHLO mail.leenox.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739AbbJRSzD (ORCPT ); Sun, 18 Oct 2015 14:55:03 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 18 Oct 2015 20:54:57 +0200 From: Tillmann Heidsieck To: punit vara Cc: Greg KH , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Julia Lawall , Sudip Mukherjee , Dan Carpenter , Larry Finger , linux-kernel-owner@vger.kernel.org Subject: Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test Organization: leenox.de In-Reply-To: References: <1444847155-11243-1-git-send-email-punitvara@gmail.com> <1444847155-11243-5-git-send-email-punitvara@gmail.com> <20151017051635.GA3074@kroah.com> Message-ID: User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2015-10-18 08:32, punit vara wrote: > On Sat, Oct 17, 2015 at 10:46 AM, Greg KH > wrote: >> On Wed, Oct 14, 2015 at 11:55:55PM +0530, Punit Vara wrote: >>> Put constant on the right side of a test.Problem found using >>> checkpatch: >>> >>> Warning:Comparisons should place the constant on the right side of >>> the test >>> >>> Signed-off-by: Punit Vara >>> --- >>> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 ++++++++-------- >>> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> Didn't apply to my tree :( > In this case what should I do ? Should I do git reset , git pull and > then do changes on latest tree ? > Greg is probably trying to apply this series to the staging-next branch of his staging tree[0] so you need to clone that one, or add it as an additional remote[1] to your clone of the kernel tree (much better option IMHO). After this you need to rebase[2] your changes onto the stating-next branch, fix up all conflicts in your code, and resend the patch. I hope this helps Tillmann [0] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git [1] https://git-scm.com/book/en/v2/Git-Basics-Working-with-Remotes [2] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git