mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Daniel Bristot de Oliveira <bristot@kernel.org>,
	linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org
Subject: [PATCH 7/8] rtla/osnoise: Fix error message when failing to enable trace instance
Date: Mon, 24 Jan 2022 15:24:10 +0100	[thread overview]
Message-ID: <c2a20c84d63092e685af9649f9b7656c3ecd1c90.1643033113.git.bristot@kernel.org> (raw)
In-Reply-To: <cover.1643033113.git.bristot@kernel.org>

When a trace instance creation fails, tools are printing:

	Could not enable -> osnoiser <- tracer for tracing

Print the actual (and correct) name of the tracer it fails to enable.

Fixes: b1696371d865 ("rtla: Helper functions for rtla")
Cc: Daniel Bristot de Oliveira <bristot@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org
Cc: linux-trace-devel@vger.kernel.org
Signed-off-by: Daniel Bristot de Oliveira <bristot@kernel.org>
---
 tools/tracing/rtla/src/osnoise.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/tracing/rtla/src/osnoise.c b/tools/tracing/rtla/src/osnoise.c
index 7b73d1eccd0e..c1368315d508 100644
--- a/tools/tracing/rtla/src/osnoise.c
+++ b/tools/tracing/rtla/src/osnoise.c
@@ -807,7 +807,7 @@ struct osnoise_tool *osnoise_init_trace_tool(char *tracer)
 
 	retval = enable_tracer_by_name(trace->trace.inst, tracer);
 	if (retval) {
-		err_msg("Could not enable osnoiser tracer for tracing\n");
+		err_msg("Could not enable %s tracer for tracing\n", tracer);
 		goto out_err;
 	}
 
-- 
2.34.1


  parent reply	other threads:[~2022-01-24 14:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1643033113.git.bristot@kernel.org>
2022-01-24 14:24 ` [PATCH 1/8] rtla: Follow kernel version Daniel Bristot de Oliveira
2022-01-24 14:24 ` [PATCH 2/8] rtla/utils: Fix session duration parsing Daniel Bristot de Oliveira
2022-01-24 14:24 ` [PATCH 3/8] rtla/osnoise_top: Fix segmentation fault when failing to enable -t Daniel Bristot de Oliveira
2022-02-03 16:41   ` Steven Rostedt
2022-02-03 16:43     ` Steven Rostedt
2022-02-03 17:30       ` Daniel Bristot de Oliveira
2022-02-03 17:56         ` Steven Rostedt
2022-01-24 14:24 ` [PATCH 4/8] rtla/osnoise_hist: " Daniel Bristot de Oliveira
2022-01-24 14:24 ` [PATCH 5/8] rtla/timerlat_top: " Daniel Bristot de Oliveira
2022-01-24 14:24 ` [PATCH 6/8] rtla/timerlat_hist: " Daniel Bristot de Oliveira
2022-01-24 14:24 ` Daniel Bristot de Oliveira [this message]
2022-01-24 14:24 ` [PATCH 8/8] rtla/trace: Error message fixup Daniel Bristot de Oliveira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2a20c84d63092e685af9649f9b7656c3ecd1c90.1643033113.git.bristot@kernel.org \
    --to=bristot@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®