mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Sui Jingfeng <sui.jingfeng@linux.dev>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Abel Vesa <abel.vesa@linaro.org>
Cc: Johan Hovold <johan@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] drm/bridge: Fix assignment of the of_node of the parent to aux bridge
Date: Thu, 31 Oct 2024 13:31:47 +0100	[thread overview]
Message-ID: <c2a4cc3a-2ffc-46f3-8636-238cd561f7aa@linaro.org> (raw)
In-Reply-To: <230b5910-6790-44cb-90ed-222bee89054d@linux.dev>

On 30/10/2024 15:49, Sui Jingfeng wrote:
> Hi,
> 
> On 2024/10/21 21:08, Neil Armstrong wrote:
>> Hi,
>>
>> On Fri, 18 Oct 2024 15:49:34 +0300, Abel Vesa wrote:
>>> The assignment of the of_node to the aux bridge needs to mark the
>>> of_node as reused as well, otherwise resource providers like pinctrl will
>>> report a gpio as already requested by a different device when both pinconf
>>> and gpios property are present.
>>> Fix that by using the device_set_of_node_from_dev() helper instead.
>>>
>>>
>>> [...]
>> Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes)
> 
> 
> It's quite impolite to force push patches that still under reviewing,
> this prevent us to know what exactly its solves.

It's quite explicit.

> 
> This also prevent us from finding a better solution.

Better solution of ? This needed to be fixed and backported to stable,
if there's desire to redesign the driver, then it should be discussed in a separate thread.

> 
>> [1/1] drm/bridge: Fix assignment of the of_node of the parent to aux bridge
>>        https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/85e444a68126a631221ae32c63fce882bb18a262
>>


  reply	other threads:[~2024-10-31 12:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18 12:49 Abel Vesa
2024-10-18 15:43 ` Dmitry Baryshkov
2024-10-30 16:45   ` Sui Jingfeng
2024-10-30 19:39     ` Laurent Pinchart
2024-10-31 12:29     ` Neil Armstrong
2024-10-21  7:12 ` Neil Armstrong
2024-10-21  7:23 ` Johan Hovold
2024-10-31 14:05   ` Johan Hovold
2024-10-31 16:13     ` Abel Vesa
2024-10-31 16:33       ` Johan Hovold
2024-11-01  9:49         ` Abel Vesa
2024-10-31 15:48   ` Dmitry Baryshkov
2024-10-31 16:26     ` Johan Hovold
2024-10-21 13:08 ` Neil Armstrong
2024-10-30 14:49   ` Sui Jingfeng
2024-10-31 12:31     ` Neil Armstrong [this message]
2024-10-31 14:02       ` Johan Hovold
2024-10-31 15:31         ` Sui Jingfeng
2024-10-31 15:06       ` Sui Jingfeng
2024-10-31 16:23         ` Johan Hovold
2024-11-01  3:49           ` Sui Jingfeng
2024-11-01  7:27             ` Johan Hovold
2024-11-01  9:20             ` Laurent Pinchart
2024-11-01 10:27               ` Dmitry Baryshkov
2024-11-01 14:43                 ` Laurent Pinchart
2024-11-01  6:15       ` Sui Jingfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2a4cc3a-2ffc-46f3-8636-238cd561f7aa@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=abel.vesa@linaro.org \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=johan@kernel.org \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=stable@vger.kernel.org \
    --cc=sui.jingfeng@linux.dev \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®