From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [207.246.76.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D78591C8FA2 for ; Tue, 22 Oct 2024 17:56:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=207.246.76.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729619790; cv=none; b=GQR/0+6Scbc96/1JRUzm1JDxG2gCwRqbjZuNSk4ya06Snvo1nCqUhJDUY3LT4tteTmwHoZ1/Pfwm+HBz/ref0Xgc8/nh15v7vuhU54CkHliXO1yeYGl/nqtqSGKLtIhFlefPS+VI4d1psHjHkgqOnGq+QDr8AMUmQEkE5eItjDo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729619790; c=relaxed/simple; bh=pf9vSfqRBsjSd2TM5I2xo/gtg+4SY8vPL8CeXA3BrA0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jiYJX/Z4m9K5D9WYGHJTiclNG/wZk3oP/NGx1qUUzhrS00aFGlBEhvl5ttZBtgP6CRz0IaX73lp33Fm7rsNC+hQZ+uQmEtsVnQ3plQaG+OM5AdJrEdF88qzx7u2PS1ldMaCvCDQ3XYJDQgN0kLgetAgltY2AVq5Dbypa9juuRxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kwiboo.se; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b=F205EJ2v; arc=none smtp.client-ip=207.246.76.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kwiboo.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b="F205EJ2v" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: Cc: To: Subject: MIME-Version: Date: Message-ID; q=dns/txt; s=fe-e1b5cab7be; t=1729619774; bh=YGvLjOzdMUUNlRyiBCim3QXE0H0tSBA3xLQ6miTXyIw=; b=F205EJ2vCko4LMsf5gAXQje2kuR34Xeuuz1iVeTEbP5ZB7nDURVWbZzeVHLj3/1FlsMJ53VKB aWaV/IcDXE0YcFqzFNEzJmr6D87bruShq1Y8EkyaatQuNfNQlt6OTJXod1esN4eRccTOxGz3duB X78Oy/dzRVmV0Z7HsL93poR6RS4dLdlS5rKWmi6ZFJvaT6a/trtvR7pbDCGrkXG2IxkWc3FhhAC oldXeQ2Q1RkRKu87LqLi9WsxWTi8NwOr1jyfkxL2BUiZ7o0KIPklf4Gn0HvZDDYfP8JH0zvWNHf Kh19IuRBKkf1lKa2P3iVFgejQWW2KJIbFKZ5ceBUGwkA== Message-ID: Date: Tue, 22 Oct 2024 19:56:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add FriendlyARM NanoPi R3S board To: Tianling Shen Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Chris Morgan , Andy Yan , Jagan Teki , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <13bb8657-f048-4f79-a2c1-3680445f2bef@kwiboo.se> <20241022173901.892190-1-cnsztl@gmail.com> Content-Language: en-US From: Jonas Karlman In-Reply-To: <20241022173901.892190-1-cnsztl@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Report-Abuse-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Complaints-To: abuse@forwardemail.net X-ForwardEmail-Version: 0.4.40 X-ForwardEmail-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 207.246.76.47 X-ForwardEmail-ID: 6717e73d289888ca1b5a4034 Hi Tianling, On 2024-10-22 19:38, Tianling Shen wrote: > Hi Jonas, > > On Wed, Oct 23, 2024 at 12:49 AM Jonas Karlman wrote: >> >> Hi Tianling, >> >> On 2024-10-20 19:39, Tianling Shen wrote: >>> The NanoPi R3S(as "R3S") is an open source platform with dual-Gbps >>> Ethernet ports designed and developed by FriendlyElec for IoT >>> applications. >>> >>> Specification: >>> - Rockchip RK3566 >>> - 2GB LPDDR4X RAM >>> - optional 32GB eMMC module >>> - SD card slot >>> - 2x 1000 Base-T >>> - 3x LEDs (POWER, LAN, WAN) >>> - 2x Buttons (Reset, MaskROM) >>> - 1x USB 3.0 Port >>> - Type-C 5V 2A Power >>> >>> Signed-off-by: Tianling Shen >>> --- >>>  arch/arm64/boot/dts/rockchip/Makefile         |   1 + >>>  .../boot/dts/rockchip/rk3566-nanopi-r3s.dts   | 554 ++++++++++++++++++ >>>  2 files changed, 555 insertions(+) >>>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts >>> >>> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile >>> index 8e1025cb5d20..e641033d23d1 100644 >>> --- a/arch/arm64/boot/dts/rockchip/Makefile >>> +++ b/arch/arm64/boot/dts/rockchip/Makefile >>> @@ -109,6 +109,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-model-a.dtb >>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb >>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lckfb-tspi.dtb >>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb >>> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-nanopi-r3s.dtb >>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb >>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb >>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-fastrhino-r66s.dtb >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts b/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts >>> new file mode 100644 >>> index 000000000000..951dd9bcb4b0 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts >>> @@ -0,0 +1,554 @@ >>> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT >>> +/* >>> + * Copyright (c) 2020 Rockchip Electronics Co., Ltd. >>> + * >>> + * Copyright (c) 2024 FriendlyElec Computer Tech. Co., Ltd. >>> + * (http://www.friendlyarm.com/ This could probably be updated to use https://www.friendlyelec.com/ >>> + * >>> + * Copyright (c) 2024 Tianling Shen >>> + */ >>> + >>> +/dts-v1/; >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include "rk3566.dtsi" >>> + >>> +/ { >>> +     model = "FriendlyARM NanoPi R3S"; >> >> Please use the marketing name, and the name added in binding: >> >>    FriendlyElec NanoPi R3S > > Sorry for the copy & paste error, will fix it in new patch. The commit subject could probably also be updated :-) > >> >>> +     compatible = "friendlyarm,nanopi-r3s", "rockchip,rk3566"; >>> + >>> +     aliases { >>> +             ethernet0 = &gmac1; >>> +             mmc0 = &sdmmc0; >>> +             mmc1 = &sdhci; >> >> This board comes with on-board eMMC this please use mmc0 as alias for >> &sdhci; and mmc1 for sd-card. > > Is using mmc0 for sdhci a common practice for eMMC boards? > The eMMC module on R3S is optional and users may get boards without it. Typically any non-removable storage (emmc) is listed before removable storage (sd-card) options. Also U-Boot will try to override and use mmc0=sdhci and mmc1=sdmmc0 for all rk356x boards, so for EFI booing using control FDT the alias may be different. Regards, Jonas [snip]