From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37C20C43334 for ; Thu, 21 Jul 2022 16:52:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232695AbiGUQwU (ORCPT ); Thu, 21 Jul 2022 12:52:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232644AbiGUQwQ (ORCPT ); Thu, 21 Jul 2022 12:52:16 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4D478BABD for ; Thu, 21 Jul 2022 09:52:14 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id m9so2500398ljp.9 for ; Thu, 21 Jul 2022 09:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=eZWePtkmW38ghd0Ghj4mqIdKzqnUwv6l+PWxC4PR9Fo=; b=xIqk2NDONVGSt9CFDj74RXp3+ZhVTqdS38QUbdoe4QPu+U55MQTbtXruHio+rZkGeR JhJkHIMD4STN9fefcql3MRiZERzo0EJvviBKQbafQmj8+wu7B+0xyCKVVgRP2LVsWODz ObofyXcSbFP6eeQAaqC7rU7QT0xCdwL+y7cyZG/rDVKZAXb0iKJJEgXCZBunpx2XcUJz uOtd/d9kysS88KAO6okDLe/0WWPcSLI6tyNrXmGvlV0u92LrkY9LVFjwB0OGrWDbavt7 L6g0Xoz9ffMmXBYezMDBjIYfl6iZgLumW4RRNIASfYRBr8rLWMK78A0zGzYF37n8260t gyWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=eZWePtkmW38ghd0Ghj4mqIdKzqnUwv6l+PWxC4PR9Fo=; b=yvXODn03iBH62Xq6vgAWVE1IbJev2rynOgBZDzNdyqE2l3m6MeFItL31zoO2LeWedK 2SLVmxRpEzzb1En0Fr3wGWJI0MzKC75dPsdp5kckezhJYQbunY/Op3J/dBpPqIcnKf0x UfAfaiTnWt5dYai5EZeC8BmZhTBK6+Ezz4+Vm7+saMeuNTtF3406EL64l+P98Bo/img8 DmMVjO+DCoS/LPmyDh6arz0WzGTozaNsAjFExEtR55iI+GG46i4IHF0JkDXYBlaHKDgu fr+Kms/fqUHBF9FR0cXTHoF/00FaaO2JD3Y/U6SYkMZVA9i0FuTsNT1zE2PhkOifJ+Nn 9Q7g== X-Gm-Message-State: AJIora/8HfeASK3enj9kKkRo63niYBHCjeAHRjWM85u3+SCI40di4X5D rago0vouiZ51Q6miexT/DRmOVw== X-Google-Smtp-Source: AGRyM1sLupBygsiOlOL5jneEivZDUqHn/Fu625JHyf7f6wLB6zZW09v4ma4/XP/dJfkD+HSowAvxNg== X-Received: by 2002:a05:651c:12c6:b0:25b:cab8:cc2a with SMTP id 6-20020a05651c12c600b0025bcab8cc2amr21022982lje.110.1658422332971; Thu, 21 Jul 2022 09:52:12 -0700 (PDT) Received: from [192.168.115.193] (89-162-31-138.fiber.signal.no. [89.162.31.138]) by smtp.gmail.com with ESMTPSA id b9-20020ac24109000000b004870f517c89sm543394lfi.33.2022.07.21.09.52.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jul 2022 09:52:12 -0700 (PDT) Message-ID: Date: Thu, 21 Jul 2022 18:52:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 2/2] dt-bindings: arm: qcom: Document additional sku6 for sc7180 pazquel Content-Language: en-US To: Doug Anderson Cc: Yunlong Jia , LKML , Henry Sun , Bob Moragues , Andy Gross , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm References: <20220721033918.v3.1.I10519ca1bf88233702a90e296088808d18cdc7b1@changeid> <20220721033918.v3.2.I7ecbb7eeb58c5e6a33e32a3abf4d6874e6cb725c@changeid> <4b2fe9d0-f590-0fac-79fa-bb05da1d61df@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/07/2022 18:43, Doug Anderson wrote: > Hi, > > On Thu, Jul 21, 2022 at 9:33 AM Krzysztof Kozlowski > wrote: >> >> On 21/07/2022 15:37, Doug Anderson wrote: >>> >>> Not worth sending a new version for, but normally I expect the >>> bindings to be patch #1 and the dts change to be patch #2. In any >>> case: >>> >>> Reviewed-by: Douglas Anderson >> >> I would say worth v4, because otherwise patches is not bisectable. > > You're saying because `dtbs_check` will fail between the two? Yes > How does > flipping the order help? If `dtbs_check` needs to be bisectable then > these two need to be one patch, but I was always under the impression > that we wanted bindings patches separate from dts patches. I don't think anyone said that bindings patches must be separate from DTS. The only restriction is DTS cannot go with drivers. Bindings for boards go pretty often with DTS (subarch). This is exactly what maintainers do, e.g.: https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/log/?h=arm64-for-5.20 Bindings for hardware should go via subsystem maintainer (drivers). Best regards, Krzysztof