From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD8C2C7EE24 for ; Tue, 2 May 2023 20:10:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229888AbjEBUKN (ORCPT ); Tue, 2 May 2023 16:10:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229871AbjEBUKK (ORCPT ); Tue, 2 May 2023 16:10:10 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A69011BFA for ; Tue, 2 May 2023 13:10:08 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-959a3e2dc72so851248466b.2 for ; Tue, 02 May 2023 13:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683058207; x=1685650207; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TrkwBFguAbANKPkb92jEkKp9+9ycK8gx4NZ9hGUSGSY=; b=mqQc6SihWNja/CcPZKDwDck5+pdV+Y3BmQ53O9JbGmLQD63uGzx8KPqgDp5x6uy522 X0s2lU/rPVVYwpBQsz4zYlRS1kpO/REsm+f/T/KTdbD+qWYxCzV83n7uyGyBdCxHmJIs zXVtdmtAhmrhOl2UnbQFTd6L31iPq5cuPERX5htQq/Sf85f0h4uwqc2oFM6yblvowfqa 9Hz8FfsuITZiS0ibTLuykT2dU/4rX6NUfrqvnW2UZr9/Z7Yj2xIPh/Vb1NMPTbcAs24C gINb3Uo2rGp6pgWGyFiN32p8JQjOmw1tPf9E2QqwQQl/PZ7hLUvt3noViSMEX6KucAnE YKKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683058207; x=1685650207; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TrkwBFguAbANKPkb92jEkKp9+9ycK8gx4NZ9hGUSGSY=; b=daBWqbJPnCvrzXlBLGHKQ3NbBlmnlanwRcY+bP6U4029drotFZH2Yd55jK2ZtjqrDk zg9ycCgbrWPxs0VhhptRMXufHenakpiIgH9TM0Fl5ckoNbyxjib6eR2LrgZzsxHoU91d aJtqQQvx9BsSNTmLs8yy4t9UJccYWwE9lSg1QHVxQpN4nzCmV81tNSrL3aLgN5JNKuli N1ZpPCKPBcZxIsjWNzw5qwGyHWLTjb6bjueWlDQjqu5L5bfO7tUigMKWrh+FoEDLCzia 40AdD1IO+XTUTeE+FIpBV8cpTUXhlklrF0eJHe1g5bOOkMRU1iHXP6jwVF3bJlltHK7e oq4g== X-Gm-Message-State: AC+VfDxs87uIuGHOJ8UeosrOdgs0hqOztDBJ8nnu8gE8PxwpHRQzWv9n 3LbV/zXLaUGzbyJ5/FYkm6+14Q== X-Google-Smtp-Source: ACHHUZ7zECZ2pF61UvoVQHbwGavK/W0U/U0D6d4F+vmFcyV9bCmuiX8I9x+CGfE7E8oFUZgMZ9Fs6A== X-Received: by 2002:a17:906:eec8:b0:94a:58a5:2300 with SMTP id wu8-20020a170906eec800b0094a58a52300mr1070369ejb.27.1683058206988; Tue, 02 May 2023 13:10:06 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:37be:eda5:e303:19e0? ([2a02:810d:15c0:828:37be:eda5:e303:19e0]) by smtp.gmail.com with ESMTPSA id tl18-20020a170907c31200b0095ed3befbedsm9405106ejc.54.2023.05.02.13.10.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 May 2023 13:10:06 -0700 (PDT) Message-ID: Date: Tue, 2 May 2023 22:10:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v1 1/2] dt-binding: cdns,usb3: Add clock and reset Content-Language: en-US To: Minda Chen , Rob Herring , Krzysztof Kozlowski , Pawel Laszczak , Greg Kroah-Hartman , Peter Chen , Roger Quadros , Philipp Zabel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20230502081805.112149-1-minda.chen@starfivetech.com> <20230502081805.112149-2-minda.chen@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20230502081805.112149-2-minda.chen@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/05/2023 10:18, Minda Chen wrote: > To support generic clock and reset init in Cadence USBSS > controller. Add clock and reset dts configuration. s/. Add/, add/ (although still weird sentence) > > Signed-off-by: Minda Chen > --- > Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 12 ++++++++++++ Also update the example or any in-tree DTS. Why existing users do not need it? Aren't you duplicating clocks with wrapping node? Best regards, Krzysztof