From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A61D3C76188 for ; Tue, 4 Apr 2023 02:03:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233026AbjDDCDj (ORCPT ); Mon, 3 Apr 2023 22:03:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229689AbjDDCDh (ORCPT ); Mon, 3 Apr 2023 22:03:37 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE7D71980 for ; Mon, 3 Apr 2023 19:03:35 -0700 (PDT) Received: from dggpemm500013.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Pr9wK67JKzKrSc; Tue, 4 Apr 2023 10:01:05 +0800 (CST) Received: from [10.67.108.67] (10.67.108.67) by dggpemm500013.china.huawei.com (7.185.36.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 4 Apr 2023 10:03:33 +0800 Message-ID: Date: Tue, 4 Apr 2023 10:03:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0 Subject: Re: [PATCH] x86: profiling: Using generic unwinding in profile_pc Content-Language: en-US To: Andi Kleen , "x86@kernel.org" , "linux-kernel@vger.kernel.org" CC: "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "hpa@zytor.com" References: <20230224021858.120078-1-chenzhongjin@huawei.com> <96d44033-3bfd-840b-15d7-80dd3a1a5313@linux.intel.com> From: Chen Zhongjin In-Reply-To: <96d44033-3bfd-840b-15d7-80dd3a1a5313@linux.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.108.67] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500013.china.huawei.com (7.185.36.172) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/4/4 2:29, Andi Kleen wrote: > > On 4/2/2023 6:24 PM, Chen Zhongjin wrote: >> Just ping... Or has profile code already been obsoleted? > > > I think it would be reasonable to remove the locked functions hack > since lock profiling can be handled with much better other tools these > days. > > I wouldn't make it depend on the generic unwinder since such a low > level facility is likely better off without complex dependencies that > could break. > > -Andi > > Although now the generic unwinder on x86 is quite stable... I think it's acceptable to remove the locked functions unwinding for !FP case and leave the FP part as is. I'll send a new patch for this with another bugfix. Thanks for review and best, Chen