From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C799B18E75A for ; Wed, 29 Jan 2025 17:51:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738173069; cv=none; b=JkMy2+a0wJ6jcaGRDok6CD9neKvWgCNYa77RKBX4ziMsEUEZk4uI/p+BrakyLy6pxi5ZCX2IDGZnC+u9Y2fnfS7dSxrsDFnyDzsEiOpIyIhUyX5OyxswugQbR/0Tzw03at6hyd3hGmF13Aot9L3WJcoXKkyFE98gMAPb/k/5fNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738173069; c=relaxed/simple; bh=CE05Ui4pxV9dF13pO5S2TKXYgDSU4uTD+SSMv5oz3G0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=Hs2iaxpUu77xK0+rcYK4OQVQzDIgaGiiQNv5gCqyf7wNckH4sQJyn3WNaSXu9lp6FxBizUaQ+T06sklpNGSMyFFgHVpNN6DpQs+ICgBW4e1Ngt5ZeNkAdASCFs2tXyNU2hh9nS3+6+aOk0iwGtdhwJGUZXsXj70j3CECp6NraVQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=AtfEM9m2; arc=none smtp.client-ip=210.118.77.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="AtfEM9m2" Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20250129175059euoutp01ba4b029e7d6f247fb663f17f242b17c9~fOzAgmNAA2467524675euoutp01b for ; Wed, 29 Jan 2025 17:50:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20250129175059euoutp01ba4b029e7d6f247fb663f17f242b17c9~fOzAgmNAA2467524675euoutp01b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1738173059; bh=kSqxDp2G8UmdMOmj3Yqy0w3UxKBUqDUXGbyJOchC1os=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=AtfEM9m2PLEeXOaqh6XXLsx/3VsaPGDqfxz2PfTkylaE8+Ble3HZiimRVEhPV3xS1 DV/N27iUvE3qG8VJ7ldjcooQKm7NW22tQE2dV0lR/cpU2QmBJ6yWGKZV55jqX5V5kH gexeEcZAzfUhJTk25//FaELjBTLxTDMtmIh54BjQ= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20250129175058eucas1p17f0a325e475a8433d68280fba4d88aad~fOzALVMwX0575505755eucas1p1-; Wed, 29 Jan 2025 17:50:58 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 37.D2.20397.28A6A976; Wed, 29 Jan 2025 17:50:58 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20250129175058eucas1p130a5352d5ee0c5db03baf91bab6b34b4~fOy-zHqcr1248312483eucas1p1I; Wed, 29 Jan 2025 17:50:58 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20250129175058eusmtrp1e17ae7aef3ef5a385d1fa5ec640d2c42~fOy-ykSp91832818328eusmtrp1O; Wed, 29 Jan 2025 17:50:58 +0000 (GMT) X-AuditID: cbfec7f5-e59c770000004fad-e9-679a6a827b32 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 53.3F.19920.28A6A976; Wed, 29 Jan 2025 17:50:58 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250129175057eusmtip114ad00e49b0f787cab57f6d62ee091cb~fOy-O6tiY0827008270eusmtip1y; Wed, 29 Jan 2025 17:50:57 +0000 (GMT) Message-ID: Date: Wed, 29 Jan 2025 18:50:57 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/1] regmap: Synchronize cache for the page selector To: Andy Shevchenko Cc: Mark Brown , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Dmitry Baryshkov , DRI mailing list Content-Language: en-US From: Marek Szyprowski In-Reply-To: Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKKsWRmVeSWpSXmKPExsWy7djPc7pNWbPSDe52alj0Nk1nspj68Amb xetpH9gsJp7/yWZx5et7NovmxevZLC7vmsNmMffLVGYHDo9NqzrZPO5c28PmMe9koMf+uWvY Pe53H2fy+LxJLoAtissmJTUnsyy1SN8ugSuj4fwjpoJPPBX/thxgbWBcxNXFyMkhIWAisWTW C8YuRi4OIYEVjBJ/fnxkAkkICXxhlOg9UAOR+Mwosef7HzaYjs8P57JAJJYzSrw8PY8VwvnI KHH94TSgWRwcvAJ2Etv+R4OYLAKqEv3/U0B6eQUEJU7OfMICYosKyEvcvzWDHcQWFvCWWNE6 nxHEFhEwl1g3aREbyEhmgdVMEo/6b4BdxCwgLnHryXwwm03AUKLrbRfYQZwCRhInJ82GqpGX 2P52DjNIs4TABw6J5h897CBHSAi4SJzZWADxgLDEq+Nb2CFsGYnTk3tYIOrbGSUW/L7PBOFM YJRoeH6LEaLKWuLOuV9sIIOYBTQl1u/Shwg7SlzZPo0FYj6fxI23ghA38ElM2jadGSLMK9HR JgRRrSYx6/g6uLUHL1xinsCoNAspWGYh+XIWkm9mIexdwMiyilE8tbQ4Nz212DgvtVyvODG3 uDQvXS85P3cTIzAlnf53/OsOxhWvPuodYmTiYDzEKMHBrCTCG3tuRroQb0piZVVqUX58UWlO avEhRmkOFiVx3kX7W9OFBNITS1KzU1MLUotgskwcnFINTJblT2cY3Fmh92BZpjX7djv2fKZQ tj1W4VK/O99q+O49IjpZ7VnZxr9ftwmkm98MzrwUmthccCZOoPeoyF3mrVON3cW82qVZhK/c +Sjp919pmab8aX//qGmtv5M9NrpUcN6Y15+540jyv77X2zi3/VH8u96jYXorg6icpOiBXces Hoj0J0xx5dht8nPSC2kFd58H0g/Ps5VuiJzydeqTuDkcCy5z9c8wZ17/znW/8wQDtvz4l5pP pKPKerkNGadGJL5cdH2h54EXx0KFtyy55FCx7HHqouf/TNUD3C4ckdDyfd9fkBk6+7naoWv7 7+/atENA+81dnq9FUVpRN52evpp5QLDzuFzGwqP33/AYNiixFGckGmoxFxUnAgBQsz3VuAMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJIsWRmVeSWpSXmKPExsVy+t/xu7pNWbPSDfp38Fn0Nk1nspj68Amb xetpH9gsJp7/yWZx5et7NovmxevZLC7vmsNmMffLVGYHDo9NqzrZPO5c28PmMe9koMf+uWvY Pe53H2fy+LxJLoAtSs+mKL+0JFUhI7+4xFYp2tDCSM/Q0kLPyMRSz9DYPNbKyFRJ384mJTUn syy1SN8uQS+j4fwjpoJPPBX/thxgbWBcxNXFyMkhIWAi8fnhXJYuRi4OIYGljBKHFx1kg0jI SJyc1sAKYQtL/LnWxQZR9J5RoqP/PmMXIwcHr4CdxLb/0SAmi4CqRP//FJByXgFBiZMzn7CA 2KIC8hL3b81gB7GFBbwlVrTOZwSxRQTMJdZNWgQ2kllgNZPEj94N7BDz57JIvJmxBaybWUBc 4taT+UwgNpuAoUTX2y6w4zgFjCROTprNBFFjJtG1tYsRwpaX2P52DvMERqFZSA6ZhWTULCQt s5C0LGBkWcUoklpanJueW2yoV5yYW1yal66XnJ+7iREYh9uO/dy8g3Heq496hxiZOBgPMUpw MCuJ8Maem5EuxJuSWFmVWpQfX1Sak1p8iNEUGBgTmaVEk/OBiSCvJN7QzMDU0MTM0sDU0sxY SZzX7fL5NCGB9MSS1OzU1ILUIpg+Jg5OqQYmGweO/lea1tP3xkpunOM+KWhyq+EGz4aGRuOo dRPyupU0TF+oiIXGqAtkBl+c5CXLlabZtlCUYXGWoVLN4Wv2Rn2a0iKGhn0lz2YazOFVvvSv q8zFeCIvh5Xn33bf9yfWFgip71+d4VWdJv5IUOpQiOEbr1UPngh0fl48b9MWu4gPmm9rTy2Y /d12ScWxfWV39v6+ubZ6/dVFp3UCkvTW2U7J39HGJ7+W86jL8cP1vo9kdGUc2Y54WzKcV7Jc 3fXkeX6V3am7h57n/dL46q3/nKHGqmv/04Df5qnrI5/fbQu/0cm0bHmdfeuvvakLg+dIbPxa mxw7YeLHrx8DZ57k/PSx7eDhV0Fltuf7uU4qsRRnJBpqMRcVJwIAV5Rfw0wDAAA= X-CMS-MailID: 20250129175058eucas1p130a5352d5ee0c5db03baf91bab6b34b4 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20250117135754eucas1p1a8558792f9475c2acc009e1ba20c7109 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20250117135754eucas1p1a8558792f9475c2acc009e1ba20c7109 References: <8a7581e4-6422-4d77-8027-02df0d7da489@samsung.com> <42fe4488-0ff2-4b92-ae11-cce1664a7176@samsung.com> <6b4cba29-786c-4999-ac1d-27b3e4cea6f8@samsung.com> On 29.01.2025 16:07, Andy Shevchenko wrote: >> [...] > Meanwhile, can you test this patch (on top of non-working case)? > > diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c > index 2314744201b4..f799a7a80231 100644 > --- a/drivers/base/regmap/regmap.c > +++ b/drivers/base/regmap/regmap.c > @@ -1553,8 +1553,19 @@ static int _regmap_select_page(struct regmap *map, unsigned int *reg, > * virtual copy as well. > */ > if (page_chg && > - in_range(range->selector_reg, range->window_start, range->window_len)) > + in_range(range->selector_reg, range->window_start, range->window_len)) { > + bool bypass, cache_only; > + > + bypass = map->cache_bypass; > + cache_only = map->cache_only; > + map->cache_bypass = false; > + map->cache_only = true; > + > _regmap_update_bits(map, sel_register, mask, val, NULL, false); > + > + map->cache_bypass = bypass; > + map->cache_only = cache_only; > + } > } > > *reg = range->window_start + win_offset; > > If I understood the case, the affected driver doesn't use case and we actually > write to the selector register twice which most likely messes up the things. > But this is only a theory (since we don't have the traces yet). Bingo! This patch (on top of current linux-next) fixed the probe issue. Feel free to add: Reported-by: Marek Szyprowski Tested-by: Marek Szyprowski (although I'm not sure if this is a fix for the generic case or just this driver) Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland