mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Maíra Canal" <mcanal@igalia.com>
To: Sidong Yang <sidong.yang@furiosa.ai>,
	Tomeu Vizoso <tomeu@tomeuvizoso.net>,
	Oded Gabbay <ogabbay@kernel.org>,
	Philipp Stanner <phasta@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	Matthew Brost <matthew.brost@intel.com>,
	ckoenig.leichtzumerken@gmail.com
Cc: Tvrtko Ursulin <tursulin@ursulin.net>,
	Heiko Stuebner <heiko@sntech.de>,
	Gyeyoung Baek <gye976@gmail.com>,
	dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/2] accel/rocket: Report NPU usage through fdinfo
Date: Fri, 20 Nov 2026 12:31:17 -0300	[thread overview]
Message-ID: <c2c39d36-70ec-4623-9d21-639622cef80a@igalia.com> (raw)
In-Reply-To: <20261120141225.789350-1-sidong.yang@furiosa.ai>

Hi Sidong,

On 20/11/26 11:12, Sidong Yang wrote:
> Report how much of the NPU each client uses through fdinfo. Patch 1
> exports the runtime the scheduler already accounts per entity, and patch
> 2 uses it for rocket's drm-engine-npu key.
> 
> v6: Rename the getter to drm_sched_entity_get_runtime_ns() (Maíra
>      Canal). Report rdev->num_cores, the cores that are bound, as the
>      capacity instead of rdev->max_cores, and skip the key once no core
>      is left as a capacity of zero is not allowed (Maíra Canal). Add
>      tags.
> v5: Use the entity runtime from the new drm_sched_entity_get_runtime()
>      instead of a counter in rocket (Tvrtko Ursulin). Reviewed-by tags
>      are not carried as the accounting changed. Based on drm-misc-next.
> v4: Single drm-engine-npu key with drm-engine-capacity-npu, and
>      documentation (Tomeu Vizoso).
> v3: Add a rocket_engine_usage_create() helper (Gyeyoung Baek).
> v2: Size the per-core counters by rdev->max_cores.

For both patches,

Reviewed-by: Maíra Canal <mcanal@igalia.com>

Best regards,
- Maíra

> 
> Link to v5: https://lore.kernel.org/all/20261112171144.3151554-1-sidong.yang@furiosa.ai/
> Link to v4: https://lore.kernel.org/all/20261103155338.1949294-1-sidong.yang@furiosa.ai/
> Link to v3: https://lore.kernel.org/all/20261103104804.1887489-1-sidong.yang@furiosa.ai/
> Link to v2: https://lore.kernel.org/all/20261101152723.1430312-1-sidong.yang@furiosa.ai/
> Link to v1: https://lore.kernel.org/all/20261031083642.1076356-1-sidong.yang@furiosa.ai/
> 
> Sidong Yang (2):
>    drm/sched: Add drm_sched_entity_get_runtime_ns()
>    accel/rocket: Report NPU usage through fdinfo
> 
>   Documentation/accel/rocket/index.rst     | 29 ++++++++++++++++++++++++
>   Documentation/gpu/drm-usage-stats.rst    |  1 +
>   drivers/accel/rocket/rocket_drv.c        | 25 +++++++++++++++++++-
>   drivers/gpu/drm/scheduler/sched_entity.c | 25 ++++++++++++++++++++
>   include/drm/gpu_scheduler.h              |  1 +
>   5 files changed, 80 insertions(+), 1 deletion(-)
> 
> 
> base-commit: c408466a4dfaee4b12587e926c5b85e68c8b3c40


      parent reply	other threads:[~2026-11-20 15:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 14:12 Sidong Yang
2026-11-20 14:12 ` [PATCH v6 1/2] drm/sched: Add drm_sched_entity_get_runtime_ns() Sidong Yang
2026-11-20 14:12 ` [PATCH v6 2/2] accel/rocket: Report NPU usage through fdinfo Sidong Yang
2026-11-20 15:31 ` Maíra Canal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2c39d36-70ec-4623-9d21-639622cef80a@igalia.com \
    --to=mcanal@igalia.com \
    --cc=ckoenig.leichtzumerken@gmail.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gye976@gmail.com \
    --cc=heiko@sntech.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.brost@intel.com \
    --cc=ogabbay@kernel.org \
    --cc=phasta@kernel.org \
    --cc=sidong.yang@furiosa.ai \
    --cc=tomeu@tomeuvizoso.net \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®