mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tianchen Ding <dtcccc@linux.alibaba.com>
To: Abel Wu <wuyun.abel@bytedance.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Valentin Schneider <valentin.schneider@arm.com>,
	Barry Song <21cnbao@gmail.com>,
	Benjamin Segall <bsegall@google.com>,
	Chen Yu <yu.c.chen@intel.com>,
	Daniel Jordan <daniel.m.jordan@oracle.com>,
	"Gautham R . Shenoy" <gautham.shenoy@amd.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	Mike Galbraith <efault@gmx.de>, Qais Yousef <qyousef@layalina.io>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Yicong Yang <yangyicong@huawei.com>,
	Youssef Esmat <youssefesmat@chromium.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] sched/eevdf: Fix vruntime adjustment on reweight
Date: Thu, 29 Feb 2024 17:24:58 +0800	[thread overview]
Message-ID: <c2ceff07-e1b4-4dbc-b945-f91a9076375e@linux.alibaba.com> (raw)
In-Reply-To: <20231107090510.71322-2-wuyun.abel@bytedance.com>

Hi Abel:

I'm not so familiar with eevdf and still learning. Here I've some questions 
about this patch.

1. You did proof that V will not change during reweight (COROLLARY #2). However, 
according to the original paper, the new V will be:
V' = V + lag(j)/(W - w_j) - lag(j)/(W - w_j + w'_j)
So the V' in paper will change (when lag is not zero).
Is the V in Linux code slightly different from the paper?

2. I print some log around reweight_entity(), mainly want to print V by calling 
avg_vruntime(cfs_rq). I found your algorithm only keeps the V unchanged during 
reweight_eevdf(), but not reweight_entity().

In detail:
If curr is true (i.e., cfs_rq->curr == se), we will directly run 
reweight_eevdf(), and the V is not changed.
If curr is false, we will have __dequeue_entity() -> reweight_eevdf() -> 
__enqueue_entity(). The V is finally changed due to dequeue and enqueue. So the 
result of reweight_entity() will be impacted by "cfs_rq->curr == se", is this 
expected?

Thanks!

  parent reply	other threads:[~2024-02-29  9:25 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07  9:05 [PATCH 0/4] sched/eevdf: Optimize reweight and pick Abel Wu
2023-11-07  9:05 ` [PATCH 1/4] sched/eevdf: Fix vruntime adjustment on reweight Abel Wu
2023-11-07  9:52   ` Peter Zijlstra
2023-11-14 21:57   ` [tip: sched/urgent] " tip-bot2 for Abel Wu
2023-11-15 15:36   ` [PATCH 1/4] " Yiwei Lin
2023-11-16  4:48     ` Abel Wu
2023-11-16  4:59       ` Yiwei Lin
2023-11-16  9:01         ` Abel Wu
2023-11-16  5:07       ` Abel Wu
2023-11-16  6:51         ` Yiwei Lin
2023-11-16  7:11           ` Abel Wu
2024-02-29  9:24   ` Tianchen Ding [this message]
2024-02-29 14:25     ` Abel Wu
2024-03-01  6:41       ` Tianchen Ding
2024-03-01  8:30         ` Abel Wu
2024-03-01 10:04           ` Tianchen Ding
2023-11-07  9:05 ` [PATCH 2/4] sched/eevdf: Sort the rbtree by virtual deadline Abel Wu
2023-11-07 11:03   ` Peter Zijlstra
2023-11-07 11:06     ` Abel Wu
2023-11-07 23:26   ` Benjamin Segall
2023-11-08  8:51     ` Abel Wu
2023-11-07  9:05 ` [PATCH 3/4] sched/eevdf: O(1) fastpath for task selection Abel Wu
2023-11-07 10:12   ` Abel Wu
2023-11-07 10:42     ` Peter Zijlstra
2023-11-07  9:05 ` [PATCH 4/4] sched/stats: branch statistics for pick_eevdf Abel Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2ceff07-e1b4-4dbc-b945-f91a9076375e@linux.alibaba.com \
    --to=dtcccc@linux.alibaba.com \
    --cc=21cnbao@gmail.com \
    --cc=bsegall@google.com \
    --cc=daniel.m.jordan@oracle.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=efault@gmx.de \
    --cc=gautham.shenoy@amd.com \
    --cc=joel@joelfernandes.org \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=qyousef@layalina.io \
    --cc=tim.c.chen@linux.intel.com \
    --cc=valentin.schneider@arm.com \
    --cc=wuyun.abel@bytedance.com \
    --cc=yangyicong@huawei.com \
    --cc=youssefesmat@chromium.org \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome