From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27F9D352F99 for ; Tue, 10 Feb 2026 10:22:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770718925; cv=none; b=Ht1G6tnTiwOXFAW3hmZIpUl7AM4l8sL48Hci6+sIvpBfpR6DDCe91aDSNWynDCtB9ag2QUDE0i+z2VpjqZCwwWvP3j2QPyZlHgE/K19cyqJbH2SiIxH1qfOietWgcNKayDdLam1BiBRuZLRMJgYPcMJ8WOj+4JyUbXDMcURwGzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770718925; c=relaxed/simple; bh=gI0uSe6xdP7wA3g45lbH73AvP5DIXkQ622aiAYNF9yI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YYB6vKr5rj4wADG8UADIbTrLcVvafDoEbJ/F6afCRdOm2JSBs+LxRSyVk1xp3v0wsakEKDpBj76I8QFL9peUizljLr7RJ5/JZnVgS59iTwRCJmtm0Ba1SkCCKoE37GH0/ljunoLqF7eiE8sT/539MVyRHxkhQbGq2nlshUTM/U8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Qs8BXQx1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WRE0cZHG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Qs8BXQx1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WRE0cZHG" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61A7Z4Ad2169252 for ; Tue, 10 Feb 2026 10:22:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= L3YjCD5VIamP8jn5HK0Atw0KqI7eQ9Ow3MU1kuHgTnM=; b=Qs8BXQx1Am1qt5NU mspb3m8KZh7Gcj703Q3L8v1EeC7iyGdcORhfVyPZ8nGNj4JI3961fDIK1C1z7JPk 9yQ5/bGOFEFcpEUm6ZTS9IIcCL0QEYHRmQtYDw01U0OzwS8Ad+bmRaNEiHWc7gI1 gmvGqGUujPMwaDNizDmBmtR9tXNLATpvlMzJMEkemM+YFSJgDMDyQT+7UD+/BF/k S5IjlxYlDnuNjdOdAPkebCyixvWCtv08YvFU89+2hSRDECI/vQqpUkYwsazJWz8i tuB711GT07RnzvhWNu0UNHW6YeGqYKXPUrKp3cys/wYhBl/cuDuZUFfgVr6v8F2V r2bE/Q== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c80drrjt0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Feb 2026 10:22:03 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c551e6fe4b4so3847502a12.3 for ; Tue, 10 Feb 2026 02:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770718923; x=1771323723; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=L3YjCD5VIamP8jn5HK0Atw0KqI7eQ9Ow3MU1kuHgTnM=; b=WRE0cZHGbWg8hal/WynIT4SJBRwGlTwJMNgb6/zGIq8vo1yfRfEpEyGDjwJ9lzCMvK 0c1xGceSfViEsPxI/BiFarkdKMBNyKcrQE4909RL4WrA6dRTzUTuwVIDaAzugD6KxB3e m7XZl62bM5eKxvcoYfNqrePFLmat7tU9QXu0CBqy9QSjx5PZ/kPXVAWYionVVVrFFeZt /uXtpeqrmHIaJo3rvNlZZ4nsg8S5XxLnyYucW0F1NHX6tu2/hOPvn1SozPneyTdOi2mH GOUMiaq7CyL6dsKlyJ1/aXOfbkIt6e8Fb4/j37mVhftqJJFz6JzXWiSTajNR4V/gUWAJ j5aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770718923; x=1771323723; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L3YjCD5VIamP8jn5HK0Atw0KqI7eQ9Ow3MU1kuHgTnM=; b=H3lX2tyIAviru8gfOGtfY+PAQSrNBL+dfMqKKC5mk5j3ELJUz/y/TvSSkeeNh9OUgU X/j7vJaTfQFW4s6H0h5u0vwEj3t8tLfLQG+tnh7S73Dk8mKy4UP6jTUQedRGkgPIy0SV l7k6oldRP17x9TvrDzAds3xI57Yu4mJAVsWB/Gjs2H8uDPw6TMfUKExFrBimE0nCdYyN jA7T2At84XtJMRsR0z2srtDcXq0dQm4dd/TWoCFzIPodeyrtjBNZEz/l4umYTdIPLb4r 1nqp5CDUC+GmsXeEZE8KH0uGRc8aoR8E+6aV6Uq/wqUWRZcfVL+7exKnoCoYYF48kJE0 IF9A== X-Forwarded-Encrypted: i=1; AJvYcCUtzH6nNR/YOP7gKSbqqoMkrmwXypsY+Hwm7jLvI7nzCB5c15RrMQ2Cf0hNN1ZwFObJ1TfzhO+JxGVwArg=@vger.kernel.org X-Gm-Message-State: AOJu0YyJYok9uUg89r6UxeF1/LnP4GPrm+I9gYIys767RJhSvE4fIdLq oXK/rrj1WVRMn2lNgRAMKjtnxJfbdLQ1Yo4A3sxxj1mHFEqBu/s4vgOm/+k9QYr6u8AdYirsex+ Za89bXmOPKrncCgADxkHsuyaYHQxr1quwuLZOCWZwmY4V8rLWVyXDSgoBANJY/WP7VTY= X-Gm-Gg: AZuq6aLhhtEK5g5H6DivcuQKSXzoTix9gUXbu+8hNA9e81PnmgKB/F7IqaDU3BjvlZx 30rJc9RF76O/Ggry1zFBXnKHWzcFe1gJSa3yXFPrymIWhWj5IuJQLza6v0So9nw9/1bJpKwMGOx FpaKQhm12QQZsBeSeQot2t0Xd1vt/a2PxDGw85cVzidzI1owohZ3kc433f8h9WkyK+UICWXukk1 6OQTMZtpU13mFlNaKLqQXxWu/zmL2T+Xe1CpZKmQIvzpTXC+2Q7vPtmuXsDUT76iq3MAKjmffkn HFAIxB8B1gGBLl3FtX6nZBFgb1R1GgJhHX7S+6gSEQ6phdGimrdrPjIftOeH3U8gSYZngZb9/eQ /eIohW9uv+uRoSJbRjBMhxqaLr+gKZZPjYR9YzxKs+BMbGlrIzOV3GuyA/H0/fwF8HYhx+R960C TLfdm6ysK7dobo0vM= X-Received: by 2002:a05:6a00:9513:b0:81f:45d3:adcc with SMTP id d2e1a72fcca58-824879a5af8mr1785781b3a.18.1770718922712; Tue, 10 Feb 2026 02:22:02 -0800 (PST) X-Received: by 2002:a05:6a00:9513:b0:81f:45d3:adcc with SMTP id d2e1a72fcca58-824879a5af8mr1785760b3a.18.1770718922195; Tue, 10 Feb 2026 02:22:02 -0800 (PST) Received: from [10.133.33.6] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824418b7cc3sm12949398b3a.51.2026.02.10.02.21.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 02:22:01 -0800 (PST) Message-ID: Date: Tue, 10 Feb 2026 18:21:58 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] phy: qcom: edp: Add per-version LDO configuration callback To: Dmitry Baryshkov Cc: Vinod Koul , Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260205-edp_phy-v1-0-231882bbf3f1@oss.qualcomm.com> <20260205-edp_phy-v1-2-231882bbf3f1@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEwMDA4NyBTYWx0ZWRfXx4TTXx+FLRUL 01GeDK3q9JiuQ8qT2RFS/i4rOtFA98losXF8Y247p4eA+U1K3/ujCkcdd4K+vzymtGR2ukRRgPe 2vrDBwOiVVG4e2yisAncEuWL5ox05kTuikBt7v9lmED+YCa+i8XXA+36VmG+QICtbI2NpCIvtlO tHdCIx+zvMvWfLyHxb0Ik2QlG8ShbQPOlzboaKZDoBGlgkjvKOLfb2YfjZL0VGBM8fKf2an9QHC qqbyiICN+3oijE4xq7ngDzBlB5E5g70BQ5/McHLefgDgHsaewJSbrM2/CkoBHAsBMvwGBbezUdM xJjNRFhFtnSK8vk3eVTrUDx8PYHaSVaH+uARnGH8r1xODdR60HuXtS0FeC0SlN4mzlckLtvS4np u5nr3pU08AJy/pvffBFcN5MRhjS56kbAyEr/XiK0jJjxnHD0SlGwFqyKZUCOtklMrKfPM4Fd3cx Eo0vsfHgSGNPSpJZf7A== X-Authority-Analysis: v=2.4 cv=fd+gCkQF c=1 sm=1 tr=0 ts=698b06cb cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=Wno69rA-yjVtWsVoYkYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: m52DPJm_QG8xy7gkluYj6V1FJS5ZHkDf X-Proofpoint-GUID: m52DPJm_QG8xy7gkluYj6V1FJS5ZHkDf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-10_01,2026-02-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602100087 On 2/7/2026 6:17 PM, Dmitry Baryshkov wrote: > On Thu, Feb 05, 2026 at 05:20:54PM +0800, Yongxing Mou wrote: >> Introduce the com_ldo_config callback to support per‑PHY LDO >> configuration. > > Missing the why part. Is the driver programming incorrect values, or is > it an optimisation? In the former case it needs Fixes, maybe cc:stable, > maybe Reported-by, etc. > Sure.. will add next version >> >> Signed-off-by: Yongxing Mou >> --- >> drivers/phy/qualcomm/phy-qcom-edp.c | 86 ++++++++++++++++++++++++++++++++----- >> 1 file changed, 76 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c >> index 10cbb7d9a8a0..388226dbad7f 100644 >> --- a/drivers/phy/qualcomm/phy-qcom-edp.c >> +++ b/drivers/phy/qualcomm/phy-qcom-edp.c >> @@ -81,6 +81,7 @@ struct phy_ver_ops { >> int (*com_clk_fwd_cfg)(const struct qcom_edp *edp); >> int (*com_configure_pll)(const struct qcom_edp *edp); >> int (*com_configure_ssc)(const struct qcom_edp *edp); >> + int (*com_ldo_config)(const struct qcom_edp *edp); >> }; >> >> struct qcom_edp_phy_cfg { >> @@ -273,7 +274,7 @@ static int qcom_edp_set_voltages(struct qcom_edp *edp, const struct phy_configur >> const struct qcom_edp_swing_pre_emph_cfg *cfg = edp->cfg->swing_pre_emph_cfg; >> unsigned int v_level = 0; >> unsigned int p_level = 0; >> - u8 ldo_config; >> + int ret; >> u8 swing; >> u8 emph; >> int i; >> @@ -300,13 +301,13 @@ static int qcom_edp_set_voltages(struct qcom_edp *edp, const struct phy_configur >> if (swing == 0xff || emph == 0xff) >> return -EINVAL; >> >> - ldo_config = edp->is_edp ? 0x0 : 0x1; >> + ret = edp->cfg->ver_ops->com_ldo_config(edp); >> + if (ret) >> + return ret; >> >> - writel(ldo_config, edp->tx0 + TXn_LDO_CONFIG); >> writel(swing, edp->tx0 + TXn_TX_DRV_LVL); >> writel(emph, edp->tx0 + TXn_TX_EMP_POST1_LVL); >> >> - writel(ldo_config, edp->tx1 + TXn_LDO_CONFIG); >> writel(swing, edp->tx1 + TXn_TX_DRV_LVL); >> writel(emph, edp->tx1 + TXn_TX_EMP_POST1_LVL); >> >> @@ -530,6 +531,52 @@ static int qcom_edp_com_configure_pll_v4(const struct qcom_edp *edp) >> return 0; >> } >> >> +static int qcom_edp_ldo_config_v3(const struct qcom_edp *edp) >> +{ >> + const struct phy_configure_opts_dp *dp_opts = &edp->dp_opts; >> + u32 ldo_config; >> + >> + if (!edp->is_edp) >> + ldo_config = 0x0; >> + else if (dp_opts->link_rate <= 2700) >> + ldo_config = 0x81; >> + else >> + ldo_config = 0x41; >> + >> + writel(ldo_config, edp->tx0 + TXn_LDO_CONFIG); >> + writel(ldo_config, edp->tx1 + TXn_LDO_CONFIG); >> + >> + return 0; >> +} >> + >> +static int qcom_edp_ldo_config_v4(const struct qcom_edp *edp) >> +{ >> + const struct phy_configure_opts_dp *dp_opts = &edp->dp_opts; >> + u32 ldo_config; >> + >> + if (!edp->is_edp) >> + ldo_config = 0x0; >> + else if (dp_opts->link_rate <= 2700) >> + ldo_config = 0xC1; > > Lowercase hex > Got it . will fix >> + else >> + ldo_config = 0x81; >> + >> + writel(ldo_config, edp->tx0 + TXn_LDO_CONFIG); >> + writel(ldo_config, edp->tx1 + TXn_LDO_CONFIG); >> + >> + return 0; >> +} >> + >> +static const struct phy_ver_ops qcom_edp_phy_ops_v3 = { >> + .com_power_on = qcom_edp_phy_power_on_v4, >> + .com_resetsm_cntrl = qcom_edp_phy_com_resetsm_cntrl_v4, >> + .com_bias_en_clkbuflr = qcom_edp_com_bias_en_clkbuflr_v4, >> + .com_clk_fwd_cfg = qcom_edp_com_clk_fwd_cfg_v4, >> + .com_configure_pll = qcom_edp_com_configure_pll_v4, >> + .com_configure_ssc = qcom_edp_com_configure_ssc_v4, >> + .com_ldo_config = qcom_edp_ldo_config_v3, >> +}; >> + >> static const struct phy_ver_ops qcom_edp_phy_ops_v4 = { >> .com_power_on = qcom_edp_phy_power_on_v4, >> .com_resetsm_cntrl = qcom_edp_phy_com_resetsm_cntrl_v4, >> @@ -537,6 +584,7 @@ static const struct phy_ver_ops qcom_edp_phy_ops_v4 = { >> .com_clk_fwd_cfg = qcom_edp_com_clk_fwd_cfg_v4, >> .com_configure_pll = qcom_edp_com_configure_pll_v4, >> .com_configure_ssc = qcom_edp_com_configure_ssc_v4, >> + .com_ldo_config = qcom_edp_ldo_config_v4, >> }; >> >> static const struct qcom_edp_phy_cfg sa8775p_dp_phy_cfg = { >> @@ -550,7 +598,7 @@ static const struct qcom_edp_phy_cfg sa8775p_dp_phy_cfg = { >> static const struct qcom_edp_phy_cfg sc7280_dp_phy_cfg = { >> .aux_cfg = edp_phy_aux_cfg_v4, >> .vco_div_cfg = edp_phy_vco_div_cfg_v4, >> - .ver_ops = &qcom_edp_phy_ops_v4, >> + .ver_ops = &qcom_edp_phy_ops_v3, > > This looks like an extra change. Is it intentional in this patch? If so, > mention it in the commit message. > Yes.. due to kodiak ldo func not compatable with other phys, will update the commit message. >> }; >> >> static const struct qcom_edp_phy_cfg sc8280xp_dp_phy_cfg = { >