From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E95DBC43334 for ; Thu, 16 Jun 2022 20:20:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231513AbiFPUUp (ORCPT ); Thu, 16 Jun 2022 16:20:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378460AbiFPUUe (ORCPT ); Thu, 16 Jun 2022 16:20:34 -0400 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31D525C76B for ; Thu, 16 Jun 2022 13:19:56 -0700 (PDT) Received: by mail-io1-xd32.google.com with SMTP id a10so2602063ioe.9 for ; Thu, 16 Jun 2022 13:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Dfkm2dRdVxtt3SV4LQI+L9Ln4V2YzTGpPhRrTLCNvI8=; b=QSWpvu9pWfaUPtZWEVpGfTPlC4TAzgLKTQazq9FVTmXWjrP7M8kNlU8AN8oqhkIvad fQdfo6nlia4m120WWW67tUJiMptbuycHSVLtE4oGfB+/dQMM2VypdNmh+s1ID6SP3flH fUryY1g6P4hWm6WOsHv/RZ0oncfsgXIOoT2EQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Dfkm2dRdVxtt3SV4LQI+L9Ln4V2YzTGpPhRrTLCNvI8=; b=Pv1yJxMEgDZDuayZLnxuUdLDYXTro9YfVxw6U1v5MtDOBpdygwM1IYHKza5kJnIufC jxWZkuYlPOxhe/XRXl2lSJeF2H10DabZtj0/j6wYN0D3ZylCYy0tAzWdXMlDw0Z1aECf jwen4rHHhaBJOeCsS044NJ6MyCPct3Ngyxmy6u5BqHW280yM9d1IipLab709ag1Ej8P7 U25bMSt+ecc/QL5EYiqSgA3y9AunO0UNMORTBBt79h3Dx7oNiEE6iQpJV8Yd5hqTAfBk H4wP6u9qdGzXvusD5Fxzpsg5uNuT+N5RwhZTIN4TqFilbctGgLlgNc8REJbDP8WIc+G0 vi7g== X-Gm-Message-State: AJIora/W+VV09oikUbektet+BdRUI9gABc0zhOYnu76f7W/UCSi8O1Nt ggmUllBDJsxohqxdI9xYcqDJiA== X-Google-Smtp-Source: AGRyM1uhjyLP+Q7fR9PxCN3oEeMg+rYmK3g6VQVZBzwNqbTEr5ANByUlMGD6MD/qFY1p/nDnL1xa4A== X-Received: by 2002:a05:6602:29c3:b0:669:25e5:72d2 with SMTP id z3-20020a05660229c300b0066925e572d2mr3474783ioq.206.1655410795569; Thu, 16 Jun 2022 13:19:55 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id s70-20020a025149000000b00331f8fff9a3sm1286586jaa.64.2022.06.16.13.19.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jun 2022 13:19:55 -0700 (PDT) Subject: Re: [PATCH] selftests: vm: Fix resource leak when return error To: Ding Xiang , akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220615093629.1330809-1-dingxiang@cmss.chinamobile.com> <29be48c7-7178-6f25-c99b-0d11eb967539@linuxfoundation.org> From: Shuah Khan Message-ID: Date: Thu, 16 Jun 2022 14:19:54 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <29be48c7-7178-6f25-c99b-0d11eb967539@linuxfoundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/16/22 2:11 PM, Shuah Khan wrote: > On 6/15/22 3:36 AM, Ding Xiang wrote: >> When return on an error path, file handle need to be closed >> to prevent resource leak >> >> Signed-off-by: Ding Xiang >> --- >>   tools/testing/selftests/vm/ksm_tests.c | 2 ++ >>   1 file changed, 2 insertions(+) >> >> diff --git a/tools/testing/selftests/vm/ksm_tests.c b/tools/testing/selftests/vm/ksm_tests.c >> index 2fcf24312da8..f5e4e0bbd081 100644 >> --- a/tools/testing/selftests/vm/ksm_tests.c >> +++ b/tools/testing/selftests/vm/ksm_tests.c >> @@ -54,6 +54,7 @@ static int ksm_write_sysfs(const char *file_path, unsigned long val) >>       } >>       if (fprintf(f, "%lu", val) < 0) { >>           perror("fprintf"); >> +        fclose(f); >>           return 1; >>       } >>       fclose(f); >> @@ -72,6 +73,7 @@ static int ksm_read_sysfs(const char *file_path, unsigned long *val) >>       } >>       if (fscanf(f, "%lu", val) != 1) { >>           perror("fscanf"); >> +        fclose(f); >>           return 1; >>       } >>       fclose(f); >> > > Looks good to me. > > Reviewed-by: Shuah Khan > I applied this to linux-kselftest fixes for next rc. thanks, -- Shuah