Re: [PATCH 2/3] arm64: dts: qcom: Suppress a few intentional redundant whitespaces

[Krzysztof Kozlowski <krzk@kernel.org>]

On 16/09/2026 22:46, Krzysztof Kozlowski wrote:
> Ignore redundant whitespaces in a few places to suppress warnings from
> `dt-check-style --mode relaxed` like:
> 
>   sc7280-herobrine.dtsi:357: [redundant-whitespace] extra whitespace after :
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 6 ++++++
>  arch/arm64/boot/dts/qcom/sm8750.dtsi           | 4 ++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> index 58ea0532c0fb..21179ca1219b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> @@ -354,11 +354,13 @@ keyboard_backlight: led-0 {
>  pp1256_s8b: &vreg_s8b_1p256 {};
>  
>  pp1800_l18b_s0: &vreg_l18b_1p8 {};
> +/* dt-check-style disable=redundant-whitespace */
>  pp1800_l18b:    &vreg_l18b_1p8 {};
>  
>  vreg_l19b_s0: &vreg_l19b_1p8 {};
>  
>  pp1800_alc5682: &vreg_l2c_1p8 {};
> +/* dt-check-style disable=redundant-whitespace */
>  pp1800_l2c:     &vreg_l2c_1p8 {};
>  
>  vreg_l4c: &vreg_l4c_1p8_3p0 {};
> @@ -368,14 +370,17 @@ keyboard_backlight: led-0 {
>  pp3000_l7c: &vreg_l7c_3p0 {};
>  
>  pp1800_prox: &vreg_l8c_1p8 {};
> +/* dt-check-style disable=redundant-whitespace */
>  pp1800_l8c:  &vreg_l8c_1p8 {};
>  
>  pp2950_l9c: &vreg_l9c_2p96 {};
>  
> +/* dt-check-style disable=redundant-whitespace */
>  pp1800_lcm:  &vreg_l12c_1p8 {};
>  pp1800_mipi: &vreg_l12c_1p8 {};
>  pp1800_l12c: &vreg_l12c_1p8 {};
>  
> +/* dt-check-style disable=redundant-whitespace */
>  pp3300_lcm:  &vreg_l13c_3p0 {};
>  pp3300_mipi: &vreg_l13c_3p0 {};
>  pp3300_l13c: &vreg_l13c_3p0 {};
> @@ -384,6 +389,7 @@ keyboard_backlight: led-0 {
>  
>  vreg_edp_bl: &ppvar_sys {};
>  
> +/* dt-check-style disable=redundant-whitespace */
>  ts_avdd:      &pp3300_left_in_mlb {};
>  vreg_edp_3p3: &pp3300_left_in_mlb {};
>  
> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> index ed3d29e13021..afeb6e57e0aa 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> @@ -2480,6 +2480,7 @@ swr3: soundwire@6ab0000 {
>  			qcom,din-ports = <4>;
>  			qcom,dout-ports = <9>;
>  
> +			/* dt-check-style disable=redundant-whitespace-strict */
>  			qcom,ports-sinterval =		/bits/ 16 <0x07 0x1f 0x3f 0x07 0x1f 0x3f 0x18f 0x18f 0x18f 0x0f 0x0f 0xff 0x31f>;

The comment should be placed before node and is not really important
here, because it is from 'strict' ruleset, unlike the herobrine ones.

I should have called this RFC to show intentions and whether this is the
code we would like to maintain.

>  			qcom,ports-offset1 =		/bits/ 8 <0x01 0x03 0x05 0x02 0x04 0x15 0x00 0x00 0x00 0x06 0x0d 0xff 0x00>;
>  			qcom,ports-offset2 =		/bits/ 8 <0xff 0x07 0x1f 0xff 0x07 0x1f 0xff 0xff 0xff 0xff 0xff 0xff 0xff>;


Best regards,
Krzysztof