From: Joe Perches <joe@perches.com>
To: Kai Ye <yekai13@huawei.com>, herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
wangzhou1@hisilicon.com
Subject: Re: [PATCH v2 3/5] crypto: hisilicon/sgl - add some dfx logs
Date: Tue, 30 Mar 2021 00:56:03 -0700 [thread overview]
Message-ID: <c2dcae1a5ea1f6900e061fe1a7dc393dbaf1bdc5.camel@perches.com> (raw)
In-Reply-To: <1617089946-48078-4-git-send-email-yekai13@huawei.com>
On Tue, 2021-03-30 at 15:39 +0800, Kai Ye wrote:
> Add some dfx logs in some abnormal exit situations.
[]
> diff --git a/drivers/crypto/hisilicon/sgl.c b/drivers/crypto/hisilicon/sgl.c
[]
> @@ -87,8 +87,10 @@ struct hisi_acc_sgl_pool *hisi_acc_create_sgl_pool(struct device *dev,
> block[i].sgl = dma_alloc_coherent(dev, block_size,
> &block[i].sgl_dma,
> GFP_KERNEL);
> - if (!block[i].sgl)
> + if (!block[i].sgl) {
> + dev_err(dev, "Fail to allocate hw SG buffer!\n");
This doesn't seem useful as dma_alloc_coherent does a dump_stack
by default on OOM.
next prev parent reply other threads:[~2021-03-30 7:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 7:39 [PATCH v2 0/5] bug fix and clear coding style Kai Ye
2021-03-30 7:39 ` [PATCH v2 1/5] crypto: hisilicon/sgl - fixup " Kai Ye
2021-03-30 7:53 ` Joe Perches
2021-03-30 7:39 ` [PATCH v2 2/5] crypto: hisilicon/sgl - delete unneeded variable initialization Kai Ye
2021-03-30 7:39 ` [PATCH v2 3/5] crypto: hisilicon/sgl - add some dfx logs Kai Ye
2021-03-30 7:56 ` Joe Perches [this message]
2021-03-30 9:24 ` yekai(A)
2021-03-30 7:39 ` [PATCH v2 4/5] crypto: hisilicon/sgl - fix the soft sg map to hardware sg Kai Ye
2021-03-30 7:39 ` [PATCH v2 5/5] crypto: hisilicon/sgl - fix the sg buf unmap Kai Ye
2021-04-09 7:43 ` Herbert Xu
2021-03-31 9:30 [PATCH v2 0/5] bug fix and clear coding style Kai Ye
2021-03-31 9:30 ` [PATCH v2 3/5] crypto: hisilicon/sgl - add some dfx logs Kai Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2dcae1a5ea1f6900e061fe1a7dc393dbaf1bdc5.camel@perches.com \
--to=joe@perches.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=yekai13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®