From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>,
patrick@stwcx.xyz, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>
Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: correct the compatible string of adm1272
Date: Fri, 27 Sep 2024 15:30:34 +0930 [thread overview]
Message-ID: <c2ddf0375eff2c9c18fd26029fc6a1be7ed23a8b.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240926013411.3701546-1-Delphine_CC_Chiu@wiwynn.com>
On Thu, 2024-09-26 at 09:34 +0800, Delphine CC Chiu wrote:
> From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
>
> Remove the redundant space in the compatible string of adm1272.
In this case the space is not redundant, it's just incorrect, the
compatible string doesn't match any specified. Do you mind fixing the
wording?
>
> Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
Can you please add an appropriate Fixes: tag?
Thanks,
Andrew
> ---
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> index 98477792aa00..7ed76cd4fd2d 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> @@ -284,12 +284,12 @@ &i2c10 {
> &i2c11 {
> status = "okay";
> power-sensor@10 {
> - compatible = "adi, adm1272";
> + compatible = "adi,adm1272";
> reg = <0x10>;
> };
>
> power-sensor@12 {
> - compatible = "adi, adm1272";
> + compatible = "adi,adm1272";
> reg = <0x12>;
> };
>
next prev parent reply other threads:[~2024-09-27 6:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 1:34 Delphine CC Chiu
2024-09-27 6:00 ` Andrew Jeffery [this message]
2024-09-27 6:21 ` Delphine_CC_Chiu/WYHQ/Wiwynn
2024-09-27 6:28 ` Andrew Jeffery
2024-09-27 7:22 ` Ricky CX Wu/WYHQ/Wiwynn
2024-09-27 7:23 ` Delphine_CC_Chiu/WYHQ/Wiwynn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2ddf0375eff2c9c18fd26029fc6a1be7ed23a8b.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=Delphine_CC_Chiu@wiwynn.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=ricky.cx.wu.wiwynn@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®