From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 297D734251A for ; Tue, 27 Jan 2026 10:41:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769510470; cv=none; b=SeacINLg02iBDQaGB2QYYmng5Vi156MTfnE3ZzJ6IqCnXkBGUY8J7xOQ5zJTxbgy0XtWELs+RmYH1lmPuTpr7XHNjTJVWjaSkrjI15tnyQjBT7YwM6Msr9cFLcll+vTFLwuXgQITuLr+QbNuEHNmdsdBVijBRrs2CAh5FBFfv78= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769510470; c=relaxed/simple; bh=ep8pkCwlbUpSN66L5MpDnjNjWPh2mpgjhXM0xSkHFh4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sXzAX9muiMTHHTWzVqVNd3jyPPS1fnubWQzI/6lXOjSLkF5B++1LxLqmYzfmqtjpkwKp+78sYYPnU4LsIedrfPBoSb8gEXGeu6AkF13rvDTHGScXrP7pigUgLW8pl7sGz7bsSGOWZfKc68Tjr8t2vY1No9jU1E2/VJhiqwD/Y2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=a8oniDP8; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jhub10ew; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="a8oniDP8"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jhub10ew" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769510468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Euj5FVmeiCgVhty6Ys/ujWG8Y866aXXG7V4F32PyIco=; b=a8oniDP8sIIrCwe2R935DT8cCGC3RaJa34iZQ11ZpR+JVD3ojI9X7TNSgDD5mlxj5jlrvp i1KBR/LVAFaZ/1cIKlQu8p/f+AXuwoeSg2S+sMk0YPM2Piu+vd6/hueVCXwxnaftk+ZKpV lWHXeaPD/+2AkZvQVmtyAkq+QGsF2Sw= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-410-ZwEZAaQYNGWbPcQPR8Qcug-1; Tue, 27 Jan 2026 05:41:06 -0500 X-MC-Unique: ZwEZAaQYNGWbPcQPR8Qcug-1 X-Mimecast-MFC-AGG-ID: ZwEZAaQYNGWbPcQPR8Qcug_1769510465 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-59df8699267so923952e87.2 for ; Tue, 27 Jan 2026 02:41:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769510464; x=1770115264; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Euj5FVmeiCgVhty6Ys/ujWG8Y866aXXG7V4F32PyIco=; b=jhub10ewdGewbax9zYjq3xfVBunI0eM2we7Uume9dL2DConQcshOLR3fUrNVNaLcfi NQEkRkUogVl8IsM6bahZGZtOe2BDd+bvxYN9ohmk6e5QHGEPREV2gxi7/te+91OXSsOv 1ERjmLMXoidIyEvpXpoVT1aq0IYaXVHcK7SLw2a7WT7xqRstVqztebhi+4ueBPqt5QlJ Wl77P2esxG1IWHXHMJIWcfDdKf7yGFGGb21DfokVSva8mXg0ShvhvnOiIyLd0sKaea6e etIEV9QtL8eNFTbjamsOCtFQTOKzha3PWsIzZ/05IlY8Nw/68eQka9YU42HLsFqsj55h m3MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769510464; x=1770115264; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Euj5FVmeiCgVhty6Ys/ujWG8Y866aXXG7V4F32PyIco=; b=QM3raqaV0AGIw89tntf/cDNv//1V9NEzfZFqXoxPIhbt/XYHidGI9KXFDExBoGXW1r JUeJFzOBsq7SrtU7YsmwDlfPUeILlor25w7IOLhkMAH2ldZtZTF03I6Q3FOnjZo9BhgP Ph4K/wFsg0MnNnUZFiK4yOwLCPnoGbklnT2EtzFYATjzt0GKLSwtUGWFxS57qUHAlrZl PKSYMC3bPluc81oh7tWdS6SMcVcXwZTjrjaWoFBz5wENAF0oGGB0Vpm6tFdf9u1pT3UM bA9gl0O4erre+KsXo/0MbwMXpdorfIRn6W6U3Ovz3oVpnsSrGgVlaPJYHY0/XGLQjojI ORlQ== X-Forwarded-Encrypted: i=1; AJvYcCWUSy1Y3CakFgSioQ8FOjGQoHMJgptQgwAShDEhAQARQ0GraeZVcHZe0Lk09XhoVY7anoqe9WdC5IvOHXk=@vger.kernel.org X-Gm-Message-State: AOJu0YwFIIblrVs0OAtKiSzsWRpnI4M8U9aowIC0uBZzrGQLW7/oFqvu WwOJRaNkP6NRC6YzHSNS4Z8iopr/GFhaVBEjVY5psZlu9E1m/MEewzi9W7C8LyT7Fq/lBnOoADi ZJlwyFNrXmTm4uwXBK78Wb1Z+5fmVapK/A6tYQuYXg+SSLcmYnhd/nDkUuok/kYH7Jw== X-Gm-Gg: AZuq6aIqFmGr1IWU/BYdXZtKu/Hph6dXOOPBdOI2D08xIi769+fVgcQSEg8MQ9EF/Vd rFNR9H0/JUfbEnVXUrNsBBH4O0fcrWsnIsZMG2+SDuVe0vtZ/2AVL2t/8dwfFLNVhWlvF0COryw NZba9QYNTviYMeQucyIAnpZgwkey2ZxEKuSfMKBsDPWYrt93QPTT4TR4yS0uHMC/EdbsgwmOKYR aug0XgfKvl7x5k2BSXBCkBFoVClx56AXq2662qsE0NE8s8lSqjWPH2WOHT9Iv5vw8ED4g33TkjX GUWqoj3D+TteBKu0pqIqjKZqjbQg/25oMLev86HmkPmcNPLNgIKNVzgU6kWhYZIDmjoq2wj6rvh uDUpGENX919XQ X-Received: by 2002:a05:6512:3b91:b0:59d:fd1e:50da with SMTP id 2adb3069b0e04-59e040308e5mr507786e87.36.1769510464444; Tue, 27 Jan 2026 02:41:04 -0800 (PST) X-Received: by 2002:a05:6512:3b91:b0:59d:fd1e:50da with SMTP id 2adb3069b0e04-59e040308e5mr507755e87.36.1769510463979; Tue, 27 Jan 2026 02:41:03 -0800 (PST) Received: from [192.168.88.32] ([212.105.155.22]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59de492cc4asm3330939e87.101.2026.01.27.02.41.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jan 2026 02:41:03 -0800 (PST) Message-ID: Date: Tue, 27 Jan 2026 11:41:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v8 4/4] net: dsa: add basic initial driver for MxL862xx switches To: Daniel Golle , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiner Kallweit , Russell King , Simon Horman , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Frank Wunderlich , Chad Monroe , Cezary Wilmanski , Avinash Jayaraman , Bing tao Xu , Liang Xu , Juraj Povazanec , "Fanni (Fang-Yi) Chan" , "Benny (Ying-Tsan) Weng" , "Livia M. Rosu" , John Crispin References: <18c6a24eef8617abb5073569fee162f1aa1c06ea.1769053079.git.daniel@makrotopia.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: <18c6a24eef8617abb5073569fee162f1aa1c06ea.1769053079.git.daniel@makrotopia.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/22/26 4:42 AM, Daniel Golle wrote: > +static int mxl862xx_send_cmd(struct mxl862xx_priv *priv, u16 cmd, u16 size, > + bool quiet) > +{ > + int ret; > + > + ret = mxl862xx_reg_write(priv, MXL862XX_MMD_REG_LEN_RET, size); > + if (ret) > + return ret; > + > + ret = mxl862xx_reg_write(priv, MXL862XX_MMD_REG_CTRL, > + cmd | CTRL_BUSY_MASK); > + if (ret) > + return ret; > + > + ret = mxl862xx_busy_wait(priv); > + if (ret) > + return ret; > + > + ret = mxl862xx_reg_read(priv, MXL862XX_MMD_REG_LEN_RET); > + /* handle errors returned by the firmware as -EIO > + * The firmware is based on Zephyr OS and uses the errors as > + * defined in errno.h of Zephyr OS. See > + * https://github.com/zephyrproject-rtos/zephyr/blob/v3.7.0/lib/libc/minimal/include/errno.h > + */ > + if ((s16)ret < 0) { The cast is likely not needed above? if `ret` values < S16_MIN are possible this will return such values to the caller without the IO err printk. > + if (!quiet) > + dev_err(&priv->mdiodev->dev, > + "CMD %04x returned error %d\n", cmd, (s16)ret); > + return -EIO; > + } > + > + return ret; > +} > + > +int mxl862xx_api_wrap(struct mxl862xx_priv *priv, u16 cmd, void *_data, > + u16 size, bool read, bool quiet) > +{ > + __le16 *data = _data; > + u16 max, i; > + int ret, cmd_ret; Minor nit: reverse christmas tree above. BTW the initial port isolation LGTM, but I would appreciate some DSA expert second opinion. Thanks, Paolo