From: Andrew Lunn <andrew@lunn.ch>
To: cedric.jehasse@luminex.be
Cc: Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: use the hw tx queues
Date: Tue, 26 May 2026 14:30:43 +0200 [thread overview]
Message-ID: <c2e2ec6a-edc4-4eb2-8dce-a79858e6a1e1@lunn.ch> (raw)
In-Reply-To: <20260526-net-next-mv88e6xxx-cbs-v2-1-13eb49c29b83@luminex.be>
On Tue, May 26, 2026 at 01:41:14PM +0200, Cedric Jehasse via B4 Relay wrote:
> From: Cedric Jehasse <cedric.jehasse@luminex.be>
>
> >From the datasheets i've looked at these switches have 4 or 8 transmit
> queues per port.
> There's a PRI field in the dsa tag used to indicate which egress queue
> the frame is to be sent to.
> This isn't done for vlan tagged frames because this would overwrite the
> PCP value in the vlan tag (The PRI field in the dsa
> tag is used as the PCP value in the vlan tag).
Maybe a bit more context would be good here. This patch is about
frames the host is sending to the switch. Looking at just the commit
message this was not obvious. It was only when i looked at the tagger
change did i understand that.
Does DSA_CMD_FORWARD vs DSA_CMD_FROM_CPU make a difference here? Does
DSA_CMD_FROM_CPU skip some classification stages in the switch, where
as DSA_CMD_FORWARD might pass through more stages in the switch and
have the queue over written by the hardware?
Andrew
next prev parent reply other threads:[~2026-05-26 12:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 11:41 [PATCH net-next v2 0/2] net: dsa: mv88e6xxx: add support for credit based shaper Cedric Jehasse via B4 Relay
2026-05-26 11:41 ` [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: use the hw tx queues Cedric Jehasse via B4 Relay
2026-05-26 12:30 ` Andrew Lunn [this message]
2026-05-26 13:21 ` Cedric Jehasse
2026-05-26 14:15 ` Andrew Lunn
2026-05-26 11:41 ` [PATCH net-next v2 2/2] net: dsa: mv88e6xxx: add support for credit based shaper Cedric Jehasse via B4 Relay
2026-05-26 15:49 ` Andrew Lunn
2026-05-27 9:38 ` Cedric Jehasse
2026-05-26 12:19 ` [PATCH net-next v2 0/2] " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2e2ec6a-edc4-4eb2-8dce-a79858e6a1e1@lunn.ch \
--to=andrew@lunn.ch \
--cc=cedric.jehasse@luminex.be \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®