From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE8E04C98 for ; Sat, 22 Nov 2025 15:37:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763825865; cv=none; b=jt2Uh9KXM3741EZPy8/hdSjTKtTy09oVRUdGaB4UI229abOBnwp21ldMKqPGsGGyVMEeLywGKfNoIBRuwXSzE95YB5M0RFfu45X+1Yl5rvkM/ROICyHM0QbZKDkQjK0MAON0HP3qbbPvbkO4jcxSOTrwzX/A/75/rVmDW+OuRKo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763825865; c=relaxed/simple; bh=yucTcIpBA1JDU4+sCVhuam6JBYgAi5IA7cgIZP9CqVo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qtIZfN2FNB8Toq0mYHS7wGm507vpBFQ2Odn12hvFZo2ur3y6VispbnwKcLIPtLDlARn9YLhJejIeyEma7BP4MtMAAWuBQJlG+a/PY+4Ck6LVHpgUe26kV6BgYNBWKJSwlEwd/kJ4D3hvwDBtjWuTIeYwxCEKLVi/IC/DELHjyDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=fWmRQVI2; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="fWmRQVI2" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-42b32a5494dso1645714f8f.2 for ; Sat, 22 Nov 2025 07:37:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1763825862; x=1764430662; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=t08qHXnMcST7KOq0j7X4ZwqqxOnWp8qODdnF3cViEMA=; b=fWmRQVI28uOvzqm5bsjLkTF63/ggBTw3KAA9xmtzGv41wRp+IKTuLVUvv4eTXXF5YP UQZXluI3btufG0tAG6wKmf5tqWv7585dU3EMZeHoN5QF9noQN1HDwOKcRluyTB9R3Izg PQ5+xQ0fz3lacmFiitpuF8tyVCIRJJ/p0X8/p9BSB+0n4GcXiGT3v0/NktQ+htKApMhf Kv1y979IGyCILI88r9iUGvSA8xlVxEbPh/Dv5NG58hv7PdLTulRXfym5VXWo7S///inZ vqk5OHt+C3N+1xvq/W6uwG8qyj10hqKrFrX3MGrl5tdNWNoDv4wdF/1w/KcPeXG7qnit vTUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763825862; x=1764430662; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t08qHXnMcST7KOq0j7X4ZwqqxOnWp8qODdnF3cViEMA=; b=CAG9bNwsDc+gskKtdkOhNtrNUNAyhTXruJOhSELIuOiX78C2drERIGaW049gzOZwzY 0bnJEkCX1rP/jbmA19PF2HwkNRNZ57feVBmmfFto2sJXYiD0Q8tuJkg7tD1IPqCpXfv4 jpJuOxkFi8CztHLlZtIQkOlGxgbe/f/We0hau5zeC7C0jIqSQ+ZTNxjEHdNBNwMr8l0P 7A+2TFX7ACF6Rrk1CXuZIOgsczGZziV316Y3qP3c9xLt4DYldQl8aEUyry3IAjxZnDOE DqvWHjg498/yptOZ+dqltn5STIVryoaoiShY439sYUaxbM6rGggsy4fJNYyYwmUoEy7p 4b6w== X-Forwarded-Encrypted: i=1; AJvYcCUGx4UleEMlCiGXsfS/zdMPQJ4daDgkNsxdciHlQs1VEh8xooKx53ZHnVpGBbTSflZoZTVxiECKht8ylLM=@vger.kernel.org X-Gm-Message-State: AOJu0Yyx6XP6z4VcXNq2BORjCANBsvL2xAWl1HP82XOi7UUdN4iYZGHf NN0eIlsaA1PeqnRpRMO4/SFX+rW3brDSQ2aLMpHFlLhuGStCk+IDgWGdyhIN0DtDNIo= X-Gm-Gg: ASbGncvCHjV6aHL6/J+xs2FOXthCq6HpUEmdwKekIdvdFaymuRhForBYp/fBuaQnwHD ixCUH/YWkCezYTl1MmzRP/e6DuytcgTXxVHCEJCQsrirQ5hvOvgbw8zJzM2O5NoQO958z6BaFAq 6czfmY9njSwfG6YK9vXLSBA1RtTx33qE8cZJLz0fMPiG/UJISzQj4WWG2Qq1nfYNItt5Mdi/E/U uX5MUeBw5667w9wugHQmOEiRkZ90+QvunrSifsVj2w4XjWUEQ5MYJwUAaiKfNWhHa8rVosayefb /B6G/HS84FlY1+TuF05BSaaqjSRQCqCPcCcDDWx1mE9aekSoR+pD163rtmuRNysp6ZisQ6Q1hoP Wx2QRLYHwuz//wYqxgeEhZhwZxF2hRVAsW6iFMghuZ6jXT9mf50l2kGoNHi3ORCL7mYL6s8OSEC zyA1qBfxRvRpcbAIgXNwk= X-Google-Smtp-Source: AGHT+IGO0A8r2uuBqox0fVT2/tCFSYV3FxpYBlRvXTVbmzZJv9FxgHqP1rZPRso0qsJLGxd+to3LYA== X-Received: by 2002:a05:6000:24c4:b0:42b:3268:bfc0 with SMTP id ffacd0b85a97d-42cc1d51edcmr6210355f8f.49.1763825862080; Sat, 22 Nov 2025 07:37:42 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.134]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fb91f4sm17660970f8f.31.2025.11.22.07.37.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Nov 2025 07:37:41 -0800 (PST) Message-ID: Date: Sat, 22 Nov 2025 17:37:40 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] ARM: at91: remove unnecessary of_platform_default_populate calls To: "Rob Herring (Arm)" , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Nicolas Ferre , Alexandre Belloni , Russell King Cc: linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20251120-at91-probe-v2-0-8c8592f02e8e@kernel.org> <20251120-at91-probe-v2-3-8c8592f02e8e@kernel.org> From: Claudiu Beznea Content-Language: en-US In-Reply-To: <20251120-at91-probe-v2-3-8c8592f02e8e@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Rob, On 11/20/25 23:37, Rob Herring (Arm) wrote: > The DT core will call of_platform_default_populate, so it is not > necessary for machine specific code to call it unless there are custom > match entries, auxdata or parent device. Neither of those apply here, so > remove the call. > > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Rob Herring (Arm) > --- > v2: > - Dust off and rebase to 6.18-rc1 > - Add new platforms added since v1 > --- > arch/arm/mach-at91/at91rm9200.c | 9 --------- > arch/arm/mach-at91/at91sam9.c | 9 --------- > arch/arm/mach-at91/sam9x60.c | 9 --------- > arch/arm/mach-at91/sam9x7.c | 9 --------- > arch/arm/mach-at91/sama5.c | 19 ++----------------- > arch/arm/mach-at91/sama7.c | 8 -------- > 6 files changed, 2 insertions(+), 61 deletions(-) > [ ...] > diff --git a/arch/arm/mach-at91/sama5.c b/arch/arm/mach-at91/sama5.c > index efae697ce29c..e56022f00800 100644 > --- a/arch/arm/mach-at91/sama5.c > +++ b/arch/arm/mach-at91/sama5.c > @@ -6,9 +6,6 @@ > * 2013 Ludovic Desroches > */ > > -#include > -#include > - > #include > #include > #include > @@ -30,11 +27,6 @@ static void __init sama5_secure_cache_init(void) > outer_cache.write_sec = sama5_l2c310_write_sec; > } > > -static void __init sama5_dt_device_init(void) > -{ > - of_platform_default_populate(NULL, NULL, NULL); > -} > - > static const char *const sama5_dt_board_compat[] __initconst = { > "atmel,sama5", > NULL > @@ -43,7 +35,6 @@ static const char *const sama5_dt_board_compat[] __initconst = { > DT_MACHINE_START(sama5_dt, "Atmel SAMA5") > /* Maintainer: Atmel */ > .init_late = sama5_pm_init, > - .init_machine = sama5_dt_device_init, > .dt_compat = sama5_dt_board_compat, > MACHINE_END > > @@ -54,17 +45,11 @@ static const char *const sama5_alt_dt_board_compat[] __initconst = { > > DT_MACHINE_START(sama5_alt_dt, "Atmel SAMA5") > /* Maintainer: Atmel */ > - .init_machine = sama5_dt_device_init, > + .init_late = sama5_pm_init, Should this be in the previous patch? > .dt_compat = sama5_alt_dt_board_compat, > .l2c_aux_mask = ~0UL, > MACHINE_END > > -static void __init sama5d2_init(void) > -{ > - of_platform_default_populate(NULL, NULL, NULL); > - sama5d2_pm_init(); > -} > - > static const char *const sama5d2_compat[] __initconst = { > "atmel,sama5d2", > NULL > @@ -72,8 +57,8 @@ static const char *const sama5d2_compat[] __initconst = { > > DT_MACHINE_START(sama5d2, "Atmel SAMA5") > /* Maintainer: Atmel */ > - .init_machine = sama5d2_init, > .init_early = sama5_secure_cache_init, > + .init_late = sama5d2_pm_init, Should this be in the previous patch? Thank you, Claudiu