From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0F854D599 for ; Wed, 12 Feb 2025 01:49:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739324990; cv=none; b=gqwYD20iRZ8adrdIOnMYSabVRG42zp9AnsCTRd9xmBQJ3G8PBMF8BAbaxwzx7fveXjzJJQwzS1rMqP0JZuQHcRIov4OgDgYEYA4ZHqgmyv2JmPLb/Ogs+ifFuLYhaXyTu3a/p0vjG+RMyalgeBfDVK/4fzQcsVyEqpiZVRhGFO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739324990; c=relaxed/simple; bh=jKdBskxCNyO7PTxTjdXd5yL5yFqdvDrkjdAV/6I7Coc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PyagZvS9fjyumuoAKwFvYpxjtUdK35en/b8ddkxbyY70/Hk0g/i6LDswY4Vt4L4aGbGrSTixEnig7dKKxpY+ndsy0JBemQuswZUOic/fn0MgPNniHkQsn+86eXIlYgj0W+DxGSLYRx9o8gCqI2yCGY6qPYSDVLJoP6anxt/0yO0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aFwpuzgv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aFwpuzgv" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51BDWCjM007933 for ; Wed, 12 Feb 2025 01:49:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2ernzMNDLjj8b3bFJtNA9v1qW4sjL/McdGQY0gLbAJs=; b=aFwpuzgv+gAHoSsY YmaGQgYy3TkhlwWgkPDFu4vmR/vzG9L/Uwfb20pvv3Lje1oSc4uFaOLXqWe0mADf ATIPNk0hWyS/FhgYdYQFmCsNcEIQQMzCm5IdyHqUbqv37wpRZyDjMRsRgjTOZQN0 EvDna+3pOkVv1n2lgre6ZPCirB18DmFZn/gYDPtx7nCzr3cjEHHMGYUJUV4blzPX Anvn+8qfYQwAu8l4RwoPuB29SdGENzbdoSb9HgMxxzU8PF3L1T/GnGOP26srJ/Ng uXP96vFSLAClIlBWMaWmJSE/VpAuiCi3m0DFfA2YSAXBoMVtQQ3SYXdthhrlRjQZ 63IqJQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44qy4db6wr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 12 Feb 2025 01:49:42 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-21f81fc2248so62375285ad.1 for ; Tue, 11 Feb 2025 17:49:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739324981; x=1739929781; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2ernzMNDLjj8b3bFJtNA9v1qW4sjL/McdGQY0gLbAJs=; b=c/q0/O+W+mSKxvN80QWms/tY+5YxIvJvjRlDKbD3OJOoCycQy38PeklFWBR14EPIMj CCfePEySEhvb37kxGpmz3nLrpTHqoqDuMYKfrnUr6jHLI70wbWc2vH2wDJyCZ366UFuV XQpDP/9UReGS7rDmZPccpw6C43xFcfPbsAz96hK3+SWhGrkOC+R5FZ9ZDkb9ABIqLfp5 UAQbobjeqku5Q4Lhc1wu29Q0F7Ve1ZvEGZAHA57OzchiOn47iZBp796kOZCimPAHuS/x xcWm6JgcIjTE1VZ6sHkTGvLOzQ+PiZa7xlXhR+Zy9SRwum4t3DeustTSGPFYRVf3G+QX 5wNg== X-Forwarded-Encrypted: i=1; AJvYcCVaWb0f50MI7gget88dgWTw23VaPV74WUPv9Ngr1V9qbF56KOJ3sxvBmmdGNBq5e9YlZHAqJhQ00gyfGvY=@vger.kernel.org X-Gm-Message-State: AOJu0YyXj0PZ0byPMJJuL7o2Rg6tJabcum5ADwx7GQcBWDb9/gsvBXLK ZkFEty5/w/fXSZAETmtQALLEnJfRwvqTU3rG5OHFGcVORquzxzEZzDPuR29UMkgJXbh8vIHTKcC CAuS/eFGnOTSMCMWPpgPUQZB/kiH0KJsOq5IyU+3NdNznpEtGrqxBeNDa/bMnfyg= X-Gm-Gg: ASbGncu6J9SXO91y5hx2vZYsW1vx5epjEDHzs5JqgfTHj1nWeOaWQoENxQx3aGUT5IP /soPXZKrp7g0lDfVcomn2qDtmDwXccmBdXpay+H1+UR+38wxQ787CFo81s8U7qKf+RytuuP5UkK Z15qiwtMXrIvlI04Dm2yelmbBKHfVHWqWDqAaSWaB5FNi6lld21VwcOodlo+DvWxeR06pwTTf8n N8SYrUt42xMcVFyk2wWxWLsjtj5Rb5Rc8XilNRI/CYHf1QTGMeoKMZp/IDbJnsiT8g7290IEKIt 7XJSYkBo6G60tTeLMSCGpEN8WE6IEVt5wav4dSNLzFzMNf6nu2Un3JyZcVJYLmMh X-Received: by 2002:a05:6a00:804:b0:730:a40f:e6e6 with SMTP id d2e1a72fcca58-7322c433cb2mr2618093b3a.21.1739324981193; Tue, 11 Feb 2025 17:49:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IE160hzgm0HU6EAVquv0vcTFwKk5qvMJvB1r2RCx7aFz3/skmu+cRH97oEl4xHY2B63zlm/8g== X-Received: by 2002:a05:6a00:804:b0:730:a40f:e6e6 with SMTP id d2e1a72fcca58-7322c433cb2mr2618017b3a.21.1739324980772; Tue, 11 Feb 2025 17:49:40 -0800 (PST) Received: from [10.133.33.12] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7321b34c003sm2125039b3a.52.2025.02.11.17.49.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2025 17:49:40 -0800 (PST) Message-ID: Date: Wed, 12 Feb 2025 09:49:32 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 03/14] net: ethernet: qualcomm: Add PPE driver for IPQ9574 SoC To: Andrew Lunn Cc: Luo Jie , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lei Wei , Suruchi Agarwal , Pavithra R , Simon Horman , Jonathan Corbet , Kees Cook , "Gustavo A. R. Silva" , Philipp Zabel , linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-hardening@vger.kernel.org, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, srinivas.kandagatla@linaro.org, bartosz.golaszewski@linaro.org, john@phrozen.org References: <20250209-qcom_ipq_ppe-v3-0-453ea18d3271@quicinc.com> <20250209-qcom_ipq_ppe-v3-3-453ea18d3271@quicinc.com> <58e05149-abc2-4cf4-a6e8-35380823d94a@oss.qualcomm.com> Content-Language: en-US From: Jie Gan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: yeHEI4wcFz6XeUmeFnCrUP18OLICugxU X-Proofpoint-GUID: yeHEI4wcFz6XeUmeFnCrUP18OLICugxU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-11_10,2025-02-11_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 mlxlogscore=626 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 mlxscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502120013 On 2/11/2025 9:04 PM, Andrew Lunn wrote: >>> +#ifndef __PPE_H__ >>> +#define __PPE_H__ >>> + >>> +#include >>> +#include >>> + >>> +struct device; >> #include ? >> >>> +struct regmap; >> Same with previous one, include it's header file? >> > > If the structure is opaque at this level, it is fine to not include > the header. There is nothing in the header actually needed. By not > including it, the build it faster. A large part of the kernel build > time is spent processing headers, so less headers are better. > > Andrew Thanks for explanation, that's make sense. Jie