From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7760142882F for ; Thu, 30 Apr 2026 14:36:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777559809; cv=none; b=D1C3hNPXzbuaAuDYNwBNk/Lmd3Vdct9lesto/M3/XdMf/39HdQEKCJWrGgNo/CYOTnC1r/vXrj1MD0hckhRquMbndxN7EZ3s+sMf1nBeUkcTt7dgq/zXEWm8QC9hQ3gdiT+0BzmfZWwAGEio9xQJ2KyuJi4zUxrXjdm37koi0Fs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777559809; c=relaxed/simple; bh=q4KFS0fUCLAoDRvlQFqZ9THrM4lzkFXcoKZvVvkflbc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XA8A2K5+I1gfDtS1H9AHE2FNm0iflg9J+DdYbnsuf+6Jfa2TReSr9fuUlFFy0dmFDKNXuwz1VCkLP74vpaZKbvIE0v628qSVHM+2siRTdzyxsFQbZuTIi5/sxKweoAhUDXofoTVExBFUMGjHm3YDUt0s4XC6wdudrQZlz4uS9dA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PSbIpxIv; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PSbIpxIv" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5a749f4de6dso96270e87.1 for ; Thu, 30 Apr 2026 07:36:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777559807; x=1778164607; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=AASJG66/zuamirWxKBfOYrG2p46fQckg6evU2EmKX+4=; b=PSbIpxIvXqoLMkTe8bkOr1b7U09reLGSJuNquHJeSJQND339hHSDny477vbDYB0ZBH 6CV6oBlcE0CaMPfbXHEY59bw66X2KwYNXc9KEntUVrUnrSD9/iTbXDtl4RhvQLBSnFx2 erYY3YO6ojqYm8pVxGjDBrUFxmunOiD3tVjWawIS0oDrI2AUzhKj8H/am8NTh9YQM/Ov gcrVIH/31veckBRIxDgnzTnCtFjBom1gH6M3ssMSsMG02bxUxC6x3qWjY0n0VYIDC9in sIPBDX1KQvsVlId+2WHJHOZho8rjePGUYhh4sMSuDpTRpGV2UWjRkufMEOg9KKAa40+O R1uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777559807; x=1778164607; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=AASJG66/zuamirWxKBfOYrG2p46fQckg6evU2EmKX+4=; b=V/xCvTx1DeKhKF5hYUlEZbwfZzm1Ypq9Gaxhz1zFK2F4IKV+k7zQVQUYGMv5OwE22L q5yt2tJVd6he14hQ9EQEUuKH2gPBY6ywkxbQSNXsLOLPMMU4jPvHompLgFXZFt7PlLyQ jh+Fpn3whoBfEDKCL6wliKdrIppbHZaFeFBJWk+uiBn3tageLnAjMkeGUim63euOw7Lo QzJSnaC6w/8yhdF2qvuFgUhR6jA0Ve2N5EPZacQRsxDQ5CkgcvcMEVbYuDuQ4bOdoEpq 2d0U5y8Ct2fGLw4wbOcorjrhm0vEwctmQgzM2leTJZAaRq2JwrM6Fq9B8oNWVA9cdmwW b40g== X-Forwarded-Encrypted: i=1; AFNElJ8AF01BMN5P4hDDzOCbfB9Z65DxaEy5T2fXPneBg+0fvaowe0Kj0Jm7/1RoNWNRFvakZGEyXDorzRUZOW4=@vger.kernel.org X-Gm-Message-State: AOJu0YxRXS2ZvHJsivgiD8RcYeBb2nRubbbrrHh+ES/jU7hVqkE9Hzhg h1BE7mzSsmg5DiVL57tmY+OZiNwLUxh1neko+4VRwf85jYPXBKOmBakYsRRGrTKoJKE= X-Gm-Gg: AeBDievTvORzRkK3Ho4f/82kcUsnLU5sMUPO9V3+iXOWs3wq/LzLfRIMLQAsjfdltwE 986tCN4mMe9wdFP5/Njc60tJ4hjV4R90hP0jfctPe3JKxnYyxFIxxPlUZmsTatNFvvaVUGhyWk/ hFZiG31PfG9GivhSjukMv5gii1BGYZfGmkceOzarIk8XFv/ltqIidOS5qZ8bADUws7pf9N4KUsf LUVuPYFwSkTfvskyHJMUa0vMipyIkz3rAkZblIPcrZXlEthIkcuNqHLL8uu/w6p7Udv4YSIRVyq /byM/VrlBLwvfvIOJzefoXauZxl65zLU393DA6fOvU+qcTziHC28tazxcF7jQpAZ1VjhofFXZfV +u8ZD/3sgnU6Wma3MsiC9IJro61tDRboQVc0RC7ZmJZnIGPwnz19NIVcx+kZ4fz/RnGEaIQotGF jbK3vUQLboZPAYwwzblKPHPn8TrdxiBUyUrCSbnTMwMIqpqQBLD6kFjtlCB2kZezP6Usyxhwe1p ZxlhgGfYkeRWrHb X-Received: by 2002:a05:6512:3d1f:b0:5a4:f0:c4c4 with SMTP id 2adb3069b0e04-5a8522dbb44mr488645e87.7.1777559806540; Thu, 30 Apr 2026 07:36:46 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a74a756c8fsm1460216e87.38.2026.04.30.07.36.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 07:36:46 -0700 (PDT) Message-ID: Date: Thu, 30 Apr 2026 17:36:45 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] clk: qcom: Constify qcom_cc_driver_data and list of critical CBCR registers To: Krzysztof Kozlowski , Bjorn Andersson , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Dmitry Baryshkov References: <20260429170859.247165-2-krzysztof.kozlowski@oss.qualcomm.com> <828d2935-e881-443f-b0e7-eb68466ecd30@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: <828d2935-e881-443f-b0e7-eb68466ecd30@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/30/26 17:05, Krzysztof Kozlowski wrote: > On 30/04/2026 15:03, Vladimir Zapolskiy wrote: >> On 4/29/26 20:09, Krzysztof Kozlowski wrote: >>> The static 'struct qcom_cc_driver_data' and array 'xxx_critical_cbcrs' >>> are already treated by common.c code as pointers to const, so constify >>> few remaining pieces. >>> >>> Reviewed-by: Dmitry Baryshkov >>> Signed-off-by: Krzysztof Kozlowski >>> >>> --- >>> >>> Changes in v2: >>> 1. Constify also nw_gcc_nord_critical_cbcrs (Sashiko) >>> 2. Add rb tag >>> --- >>> drivers/clk/qcom/gcc-nord.c | 2 +- >>> drivers/clk/qcom/gpucc-sm8750.c | 4 ++-- >>> drivers/clk/qcom/negcc-nord.c | 2 +- >>> drivers/clk/qcom/nwgcc-nord.c | 4 ++-- >>> drivers/clk/qcom/segcc-nord.c | 2 +- >>> 5 files changed, 7 insertions(+), 7 deletions(-) >> >> What's about constifying video_cc_sm8550_driver_data from videocc-sm8550.c? > > > It's on my exception list, not sure what would be the benefit in practice. > The benefit is just the same as the one described in the commit message, having such a peculiar exception left makes the commit message statement "constify few remaining pieces" imprecise, and if it's done deliberately, then it should be explained why it's done so in the commit message. -- Best wishes, Vladimir