From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 855EFC47071 for ; Thu, 16 Nov 2023 18:40:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345395AbjKPSkr (ORCPT ); Thu, 16 Nov 2023 13:40:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbjKPSkp (ORCPT ); Thu, 16 Nov 2023 13:40:45 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7481D4A for ; Thu, 16 Nov 2023 10:40:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700160040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aOl0JfiK0j7xYYge+U2mw+78Q50UWI5d1WGZpvL5HNw=; b=LaMu/m1YZhEVfc4Kvma1N03gaIQN5jZiUqIYCCeEm0NvOuWVmbAuZzk5WHBiRqBkFUZ4hy PPXM0EeOkSBtlfUewJm2A2CADvA79ClOfrH3+o2vm4OBcEHQMIy0xEsvvCq1nsLxEG8IGx odLjkA0mPjMxF3Y7zdSNycsI9bq1wlg= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-489-UxUU3X0pP1KogHrb3g3CyA-1; Thu, 16 Nov 2023 13:40:38 -0500 X-MC-Unique: UxUU3X0pP1KogHrb3g3CyA-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c520e0a9a7so9618351fa.3 for ; Thu, 16 Nov 2023 10:40:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700160037; x=1700764837; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aOl0JfiK0j7xYYge+U2mw+78Q50UWI5d1WGZpvL5HNw=; b=pp4QqC8UjBLb+Jh0/CVxlKsN1sja2lLo3l++WQ8kQBrZGHjB2hVhjNIRjUE6Z/NM3p E+gUvuTigFSngrhP1H+WenWLRmee1qX8K80pee/9SBmaVAnJLJf1GGbG7o/Lq0LFDSxZ fs330/OIg73BTxoDAT4+XrHIzJbsaVCtmCD2tkt91p48T9PVEjzkY4N2OlmgSQAYna4d IBEY4SwXdkGf6vCcnHgvYAqbIG5L9GNTOU8wiNp+88eTGtGF3jAhEfMbhwen9t6+WOhx sbgwbWuMgEUwOPnJF1q+aK8OxsvFvzCBD1YG+tJWPFMyleLo9sq3ikpnctmVg6tRdLAq OCcA== X-Gm-Message-State: AOJu0YxEypKh9cyn5fCOaguir+sE1BFID6GkaLVMY9uLNYNR3w+tSgs7 w0FX8sqfYxcYsZzs6J+wtWcPmXSwJC+cMqSHXFrcW+Sh7fLIHbcCosMHkeb300DYdjz25ENPzJQ XBl9bQik4+GSvPcaLP+Swn3bC X-Received: by 2002:a2e:8506:0:b0:2c5:1989:ce1c with SMTP id j6-20020a2e8506000000b002c51989ce1cmr2600431lji.26.1700160036771; Thu, 16 Nov 2023 10:40:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IFXLhDPWOzTlRkXddnSPhzG+NSVlQALkMLy0Mf5RiyPjzcDIfY56bH5EK6JDDMjc8QIiCvE1g== X-Received: by 2002:a2e:8506:0:b0:2c5:1989:ce1c with SMTP id j6-20020a2e8506000000b002c51989ce1cmr2600409lji.26.1700160036368; Thu, 16 Nov 2023 10:40:36 -0800 (PST) Received: from ?IPV6:2003:cb:c714:e000:d929:2324:97c7:112c? (p200300cbc714e000d929232497c7112c.dip0.t-ipconnect.de. [2003:cb:c714:e000:d929:2324:97c7:112c]) by smtp.gmail.com with ESMTPSA id f11-20020a05600c4e8b00b0040535648639sm120094wmq.36.2023.11.16.10.40.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Nov 2023 10:40:35 -0800 (PST) Message-ID: Date: Thu, 16 Nov 2023 19:40:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] mm/memory_hotplug: fix memory hotplug locking order Content-Language: en-US To: Sumanth Korikkar Cc: linux-mm , Andrew Morton , Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML References: <20231114180238.1522782-1-sumanthk@linux.ibm.com> <20231114180238.1522782-2-sumanthk@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15.11.23 14:41, Sumanth Korikkar wrote: > On Tue, Nov 14, 2023 at 07:22:33PM +0100, David Hildenbrand wrote: >> On 14.11.23 19:02, Sumanth Korikkar wrote: >> >> The patch subject talks about "fixing locking order", but it's actually >> missing locking, no? >> >>> From Documentation/core-api/memory-hotplug.rst: >>> When adding/removing/onlining/offlining memory or adding/removing >>> heterogeneous/device memory, we should always hold the mem_hotplug_lock >>> in write mode to serialise memory hotplug (e.g. access to global/zone >>> variables). >>> >>> mhp_(de)init_memmap_on_memory() functions can change zone stats and >>> struct page content, but they are currently called w/o the >>> mem_hotplug_lock. >>> >>> When memory block is being offlined and when kmemleak goes through each >>> populated zone, the following theoretical race conditions could occur: >>> CPU 0: | CPU 1: >>> memory_offline() | >>> -> offline_pages() | >>> -> mem_hotplug_begin() | >>> ... | >>> -> mem_hotplug_done() | >>> | kmemleak_scan() >>> | -> get_online_mems() >>> | ... >>> -> mhp_deinit_memmap_on_memory() | >>> [not protected by mem_hotplug_begin/done()]| >>> Marks memory section as offline, | Retrieves zone_start_pfn >>> poisons vmemmap struct pages and updates | and struct page members. >>> the zone related data | >>> | ... >>> | -> put_online_mems() >>> >>> Fix this by ensuring mem_hotplug_lock is taken before performing >>> mhp_init_memmap_on_memory(). Also ensure that >>> mhp_deinit_memmap_on_memory() holds the lock. >> >> What speaks against grabbing that lock in these functions? >> > At present, the functions online_pages() and offline_pages() acquire the > mem_hotplug_lock right at the start. However, given the necessity of > locking in mhp_(de)init_memmap_on_memory(), it would be more efficient > to consolidate the locking process by holding the mem_hotplug_lock once > in memory_block_online() and memory_block_offline(). Good point; can you similarly add comments to these two functions that they need that lock in write mode? -- Cheers, David / dhildenb