Re: [PATCH v4 09/17] wifi: cc33xx: Add main.c

["Nemanov, Michael" <michael.nemanov@ti.com>]

On 11/2/2024 3:25 PM, Simon Horman wrote:

...
> 
> Hi Michael,
> 
> Sparse seems a bit unhappy about this:
> 
> .../main.c:332:24: warning: incorrect type in initializer (different address spaces)
> .../main.c:332:24:    expected struct ieee80211_sband_iftype_data const [noderef] __iftype_data *iftype_data
> .../main.c:332:24:    got struct ieee80211_sband_iftype_data *
> 
> So perhaps it should be:
> 
> static const struct ieee80211_sband_iftype_data __iftd iftype_data_2ghz[] = {{
> 
> Likewise for iftype_data_5ghz.
> 

Hi Simon,

Yeah I saw that and was unsure how to properly solve it, Sparse does not 
seems to like direct use of this variable. The above is based on old 
code and I see newer implementations are using 
ieee80211_set_sband_iftype_data which has the casting that should make 
Sparse at ease. I'll try migrating the CC33xx code to this convention 
which will require moving some structs around.

Thanks and regards,
Michael.