From: Kim Phillips <kim.phillips@amd.com>
To: Liam Merwick <liam.merwick@oracle.com>,
Ashish Kalra <ashish.kalra@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
John Allen <john.allen@amd.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH] crypto: ccp - Fix null pointer dereference in __sev_platform_shutdown_locked
Date: Fri, 26 Jan 2024 10:31:19 -0600 [thread overview]
Message-ID: <c2fe25b0-a51c-44b8-a454-2573fe6ac651@amd.com> (raw)
In-Reply-To: <91b75885-26c0-4697-b5dd-3ebce922dd44@oracle.com>
On 1/26/24 5:59 AM, Liam Merwick wrote:
> On 25/01/2024 23:12, Kim Phillips wrote:
>> Fixes: 1b05ece0c9315 ("crypto: ccp - During shutdown, check SEV data pointer before using")
>
> checkpatch warns about SHA1 of Fixes: having more than 12 chars...
>
> However, although 1b05ece0c931 is the last commit to change this
> functionality, I think this issue exists prior to that.
>
> 5441a07a127f ("crypto: ccp - shutdown SEV firmware on kexec")
> might be more appropriate so that it'd get applied to linux-5.15.y
> (where 1b05ece0c931 and 5441a07a127f have been backported to also)
> This patch applies cleanly to linux-5.15.y.
1b05ece0c931 fixes 5441a07a127f, and I'm assuming Fixes: are transitive.
>> Cc: stable@vger.kernel.org
>> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
>> Signed-off-by: Kim Phillips <kim.phillips@amd.com>
>
> Code changes LGTM, so
> Reviewed-by: Liam Merwick <liam.merwick@oracle.com>
Thanks for your review!
Kim
next prev parent reply other threads:[~2024-01-26 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 23:12 Kim Phillips
2024-01-26 11:59 ` Liam Merwick
2024-01-26 16:31 ` Kim Phillips [this message]
2024-01-26 16:36 ` John Allen
2024-02-02 10:11 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2fe25b0-a51c-44b8-a454-2573fe6ac651@amd.com \
--to=kim.phillips@amd.com \
--cc=ashish.kalra@amd.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=john.allen@amd.com \
--cc=liam.merwick@oracle.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=stable@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®