From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755747AbdKBOJR (ORCPT ); Thu, 2 Nov 2017 10:09:17 -0400 Received: from mail-by2nam01on0081.outbound.protection.outlook.com ([104.47.34.81]:31808 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755703AbdKBOJP (ORCPT ); Thu, 2 Nov 2017 10:09:15 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Felix.Kuehling@amd.com; Subject: Re: [PATCH 1/3] drm/amdgpu/display: provide ASSERT macros unconditionally To: Arnd Bergmann , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= Cc: David Airlie , Harry Wentland , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Dave Airlie , "Edward O'Callaghan" , Tony Cheng References: <20171102112657.111405-1-arnd@arndb.de> From: Felix Kuehling Organization: AMD Inc. Message-ID: Date: Thu, 2 Nov 2017 10:09:09 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171102112657.111405-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-CA X-Originating-IP: [165.204.55.251] X-ClientProxiedBy: DM5PR05CA0020.namprd05.prod.outlook.com (10.173.226.30) To CY4PR1201MB0232.namprd12.prod.outlook.com (10.172.79.9) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cad30d37-cfe3-4ed4-b46f-08d521fb4b55 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603199);SRVR:CY4PR1201MB0232; X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0232;3:dS1WHYgLMkM83RsnoAUaLpPQpfcQFrRhHRFskiMTE+QN0NVXJmuNi8hBoPOzSq9J21nSfiWJX0AbuTkQPbrAWD9b95u1Vg5zVUAqmiRSVO8jmneg8BcIHBqCWcSoXF+utheobF5NfuTcKhjEHsw/Ho9QHixb69eFbk+5S7EWIO555PG+Js/aOst4r66Qn3XU+RKgkfP5Y2C3o0BR+ogZoICT9ECGukUV8b5xrXrF6PFkUOO4BExBvUb1CF6K1GKb;25:p33F0GQgtfxPlzT0wF4UriK+PY8qlV3IjAFEIGJRIf30VdZa06n8irwzoWK5jgOLyJ0OfqOTHOlAWsQ7mXLdabL7kCmiajfmdmVqbNDc9zaaWtI21ecngG2Gdxq3ZqjzauTs9maR2PkMhvQXsbU9oLGpl5sWO0Y3gpeWGs//1cr5dqQxuYwK/QRSMh1iR/jIU0tiVuJpgq5zIKVKZPaKUUJIgSCnEC75vJ0CYwqZckhfOvn2a07J7y6Zto79gAGNWrODDyzXSuohBNTQ6pEAfZQ05GeNZwHvSXe/hM1ou1NegTh+VW1Y2B9IMsb1eP1oqVMxrhAl08Z01k3qlkXItA==;31:XQIG5Gy70imzLxSG7dlNCoZB6C95yAktzdhvLEzG19n6HTyOBiMd5XswPFdhKnzBdGGO4yPLt+A0wt4SZ7mEFujkwsQ9KpAdkeRwpp6+ByKS8JRzMwNRdqsZde4cYYbXn1NfyFQxEexSiMGSa34hTLou51yqrylCyD2NBJt6iWovaQC0M/6zCoSZfN+Dm/DlWBP/5pqi1/Vc0dsrr3HVtf7tBMVvCX2S2VoywZTauFc= X-MS-TrafficTypeDiagnostic: CY4PR1201MB0232: X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0232;20:RBB700zBiaFmjz5foeb2lRtXmrVnJCQxh3nkKM2y7uYT9Ps2pv8O8fUiNJTtjadw1xe5Qhzuvd789LcwegjM7OOIl36Nw00GghCVe2EEUoVH++gLAfBH2VSRlObABcktXhdpzZoSxQuOEvmGrIDNzIYIuKcSQD2vJW78ONq5G+VFjJHcTSuXTmrYq9NbQLXSoaOGs5mzjtFUectkZfl3hm4xculXGv5DCJtjLMEeD1z7NmaLReJpl5d+ocFy0uKE6W3aTOf4HCxFrVdGY5HJv4OddZDCEEnc2NBo6K4MTynWu780KIxybSdLmkYUAmkb1QQkHUU5P/gl2YuDM/PdOZkH4RRv8BvRXhOmamuDet4TVbhlIegwfAGb9PCV2eMRc6HDajy8GawxtZ9G91pjO6Mglcfl4+utmAOVaTf2et6ObcGOts/bh/irrU01GUg/gddBIiwsg4w6CGd2k6dMDLJLUPVSOg8DgOzqnqYjhgW8EIFUhr7s6llGhavesW9q;4:T/VEtPNedH1QSSuFm1Us6bweouU3ZfOL89PoLc6y2qWRz/0lykhfPoaUoL6uBFjgnIT2YULpNuSZzIEOn7/WpCNoVlJXX6KtTACa/F+3t+Ze6CqZwHoteUcDDEIKUZVvnqf1aZMuiVmFu1ec0nHIdof36w5r6VEbu0nRZiFp+sGCuZ9PrRo4RMdh6VLR8ijQEzxoKHJhRr8O69cMUQKsg/We4bgDDyS7d2sfWgBs8pMjPOyLrwXMsTfTVC3v9G9pNQchL1aAU8hjJED0IB7P3A== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231020)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR1201MB0232;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR1201MB0232; X-Forefront-PRVS: 047999FF16 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(39860400002)(346002)(376002)(24454002)(189002)(199003)(377424004)(68736007)(5660300001)(81166006)(81156014)(86362001)(478600001)(4326008)(65826007)(8676002)(25786009)(90366009)(53936002)(72206003)(3846002)(8936002)(6246003)(31696002)(77096006)(6486002)(64126003)(6116002)(31686004)(50466002)(110136005)(65956001)(66066001)(65806001)(2906002)(47776003)(58126008)(54906003)(83506002)(7736002)(305945005)(16576012)(16526018)(316002)(2870700001)(36756003)(97736004)(23676003)(101416001)(189998001)(76176999)(50986999)(53546010)(54356999)(2950100002)(6636002)(6666003)(33646002)(229853002)(105586002)(106356001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR1201MB0232;H:[172.27.225.16];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyMDFNQjAyMzI7MjM6UUkrRXRySDZzM2RaYjVBZmUyMmx5L2VY?= =?utf-8?B?dkdZS0FiWlFGbGJSZCt4RnpKOUVxOWc2UThwRDg5RndiL3ZULzBjNklMUUZ6?= =?utf-8?B?bVhIc1N2TjNlZGVWUnE3OFl3UGZhYzA3WVllc3BzVGJsb0R1aEtXcWtEdkFx?= =?utf-8?B?NTR5Y2RFOCttUTBTWmxwV3pXODNvWlVmMlQ0TmhIWHdLM3JYdjgvWlRBbk1a?= =?utf-8?B?M3lWRVV6a2o2Y2dMRkhKdjRjQWp2emFZckg4RkZzZTdLN0JYUUcrbEVMUGFP?= =?utf-8?B?bzVwbEkwZUp4MGVoRHJpa3MxQTBuczJ1bnc2VWdYakIrR1hFeXR6czBLYmoy?= =?utf-8?B?blBweUl6ajJrbFhuKytJYy9rMTlibmtwZEtCczJBN3ZWRTV5ZklXbXl1d1A0?= =?utf-8?B?bVhvV0NUdGpGS1cwWFdlL0RHM2k4R1JsTGxjZnlWRjRrOGdQSzRBY0dPRm1y?= =?utf-8?B?RkJzcmZhYnlMN3ExUnM5UlB0L0hTTmdMaTJWNlJVSWVwaW5lWkl0a3psVS9X?= =?utf-8?B?NEtwaytpYVdsbzMrYk93L0hrdjRXSHEybWd0eGhSZVM0ZVJ5Ti9uenFhWkNi?= =?utf-8?B?VEdiRm9DclJKVmdLWHFoZzBpemhLZ3FyTG9oY0V2WVBqL1Jjb0huZ1VJUFc1?= =?utf-8?B?b0Z0TXN4dUZ4Z29ITEQ4K2wzcWowMk9GSkoydnhZUGlnbEdCN29Ma1BHdkc0?= =?utf-8?B?Q3piWFZKdGNuMGQvVWdBT0Q4bjNFQzNUaWRmWjFyb1BzckRBQVR3UTQ4d3la?= =?utf-8?B?OEk1TW9kYVNVcGYxaTdmdy9jNXUxd01wT2xPODNDYTY0MWIzeEZ2Qk1IcHdr?= =?utf-8?B?b29yRjdHRVFYbndoeTVXMlRJK2lEZTJ3c3N4NkhNeVNKQysrczhYbit0K3Zv?= =?utf-8?B?ZjZ3VTU5cy90OGE2TlhPYXFPSm10VExsZDJUZ1d2elE2RW11b3VmbVRLQmsv?= =?utf-8?B?TnhWNGdDREppcXRsNkp3QStReHdHakdoTEtROXpvQXBiaHVCYVZMNlBXemxW?= =?utf-8?B?RkliTllZUXJhanFLWFY2cnd0Tk9JSmwvcUxnZFFsNjBtU0VJME1DNFYrWFpm?= =?utf-8?B?bHJwSitZT0hvbXJwN25WbnlwR05lc1FRaWlDTXkxVjk1MU5YYmo1bVVqSHFo?= =?utf-8?B?OVQrQkEzRXY5VUVnU215dEJMQVhOZDltUUJEOUg5eG9hM3ZCWE45cFZSbWla?= =?utf-8?B?eUNYOTMxdGp1c0Y5aUpXNEM0S3FvSnJEVG04Um5ldWk3N3VZY3hQckVQUmI1?= =?utf-8?B?V0hoSE5nckxhWEgyNXFiRmx3QlNGcVRTOUFESHB6TlZGLzhCRHIrOGRwOExN?= =?utf-8?B?OTgwWFhxVGt2WFJLNDJUQVhBemZKczJFQXBxMEtwQzhHbkZjOTRNaVZkdzEy?= =?utf-8?B?QXFqNVVFZVRZQkF0aFhBV1JDOURDZ0xEaW5QQWlUWnAwbHJEckQzYXBnZ084?= =?utf-8?B?dk1ISFVxb250UU45cFJadmhSZnNxSGs3MGlmcktUSEM0cTlUczF3NjlQc216?= =?utf-8?B?NDdVMWEvdmFqemZzcEQ0T05Ic1Yxbi9BVitjN0h1NmU0b0xxMkcyTjJ2eXdY?= =?utf-8?B?Y2RVQnczMGVSVjRZZ25yaWN1cm5OMjBYOWZVV2JFVjZKQWxXMlVYdmFZODVt?= =?utf-8?B?dlB3L0N2b0ZxT051cFAyMEtJN3FKYjY4Vkpnby8wdkg4OUhjUXFCb2RVeW5I?= =?utf-8?B?TTFSeVJFN3NUU09kcm5tdEFGOVd6T055bldLajFsUUJrK3Jpd05SODFNaFFC?= =?utf-8?B?ZDRUNlkrRkNlSEk1ZzU0eFFlTE0yTGdGRkRBQUZTV2NFZTJ5Vm1ZaEZldWZG?= =?utf-8?B?M3pvcnAvUnpHOS9Vdi9EdXIzUmQ2Rk5nL24xWmVsVm11aWVpd1kvWStxUmli?= =?utf-8?B?L2xrTUd4bkdQQ3VtVitaclYwVDlsdzQ4Zm5pUFFHRFRPc1YrQm1xUDZuMzlx?= =?utf-8?Q?jLSu7syxgmcVaUaw5BNc9dyLJZV2R7RM=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0232;6:teONGHc8REVGaKVlNaSkUlbp29bd8Ni7Ihcg5v6QbVlgGIB31znKXP2d2nPzIqa5T68T66tRJPGh68ZiddHWyRNtenDTMgkZG+A9xAnCFu4ARP+jDo2veS3WyCZ/HraddI8ZWec8FMhJvVqtOjZfu6QHZWAsbuc3u6cVOYo/9PzWQ4F1kV5ZWCdivmBR53S2eJLnBLZqat4iggTeslogdtZILlpl6sjhtnOj8bf3InHHq2L2ZJhvlwtWiHaMa01sFCMP6giWvFC1t8Bami0gqvzfGJhh+tN/YEtW2qMXMKp+OdDlF7jBafYPs+e/Uc5nLpOqli71T/rfJXFq+CsbNiwfSa0Q+OBpPY0F09zShOU=;5:W45UN4nk+11zUGcjdJr/2oU6ckzccLHWydDpAXZEkRjVsOPcMcNVHbVoQaeqoqolHBqHDWmMG+Y0u4/ngyxxcd5q/mm6/le39zoyroLxR1oYM+WQeLXRRddZeIH7P5QE5PhBd010MgnbTraXxTFDKpg3YKeSIohQ4tPKtxFQNGc=;24:EUFxuHAXFZb09XE39uZsMk/aNlsA+zMlQwkyG6pNyxHDlFtuECvlrYZiZN3yZx565P+w7wgqy7XhfMX1j7tEpqYANpJL0OIuk5GWwg8ylV8=;7:dEilzsA0UzsFz1xkqbpHgTwidkLHD4ZsrI2kyKLU7Uw01/8d3drfBa7GPoh9HFeKExGvd5jT/etgFhrf/7YBXCMAb7LkDLFnyyQDIFQvqhLEalbC1AiLdxRj7C95gxku3tp8wlJktkAKPiIPqbThCu4ORlioXmhT5+x0o7Ckrkbo+TmCo9QjPB/jqpZe+IkSk917AnMUtA5CzGam2ZkF8F8m3iT4uN3/pq8HIr0AMt/G9fZVcfvZtg8iNNtpQ+PL SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0232;20:nujFv4uyqbrU7QgMIhtwpczvwadC6tTKpuT3M4IwwqY1fj5okG30JSsM7MTIqFqtDQmbw3pu8B0QhWqPzdQ4iY2a/jq0AQCpUWKYYuDR9pPyo5aoZoiSrakJpLs05LQB9MUmyF8cnDBzaZhJQ9IUzEQWMn0z633ECmmQ24472629UpmDn/BRwySHuOqtMl2+GzwsS6Mi3NZ2OUyM2+GhY38/nvRO2Yqe9VPuSO/U3Z0ebhbSXHh4zeOhi/fxvja9 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2017 14:09:12.0623 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cad30d37-cfe3-4ed4-b46f-08d521fb4b55 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0232 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-11-02 07:26 AM, Arnd Bergmann wrote: > It seems impossible to build this driver without setting either > CONFIG_DEBUG_KERNEL or CONFIG_DEBUG_DRIVER: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h: In function 'set_reg_field_value_ex': > drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:132:2: error: implicit declaration of function 'ASSERT'; did you mean 'IS_ERR'? [-Werror=implicit-function-declaration] > > This moves the ASSERT() macro and related helpers outside of > the #ifdef to get it to build again. > > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/amd/display/dc/os_types.h | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/os_types.h b/drivers/gpu/drm/amd/display/dc/os_types.h > index 86170b40b5c5..499bd52004cf 100644 > --- a/drivers/gpu/drm/amd/display/dc/os_types.h > +++ b/drivers/gpu/drm/amd/display/dc/os_types.h > @@ -61,8 +61,6 @@ > * general debug capabilities > * > */ > -#if defined(CONFIG_DEBUG_KERNEL) || defined(CONFIG_DEBUG_DRIVER) > - > #if defined(CONFIG_HAVE_KGDB) || defined(CONFIG_KGDB) > #define ASSERT_CRITICAL(expr) do { \ > if (WARN_ON(!(expr))) { \ > @@ -75,7 +73,7 @@ > ; \ > } \ > } while (0) > -#endif > +#endif /* CONFIG_DEBUG_KERNEL || CONFIG_DEBUG_DRIVER */ Is this the right comment here? Looks like it should be /* defined(CONFIG_HAVE_KGDB) || defined(CONFIG_KGDB) */. Regards,   Felix > > #if defined(CONFIG_DEBUG_KERNEL_DC) > #define ASSERT(expr) ASSERT_CRITICAL(expr) > @@ -86,8 +84,6 @@ > > #define BREAK_TO_DEBUGGER() ASSERT(0) > > -#endif /* CONFIG_DEBUG_KERNEL || CONFIG_DEBUG_DRIVER */ > - > #define DC_ERR(...) do { \ > dm_error(__VA_ARGS__); \ > BREAK_TO_DEBUGGER(); \