From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sonic312-23.consmr.mail.ne1.yahoo.com (sonic312-23.consmr.mail.ne1.yahoo.com [66.163.191.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 075713E169A for ; Sat, 16 May 2026 15:31:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.163.191.204 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778945496; cv=none; b=j1eniztnLBCyOoMWMrx0WWNj2yQacu5QZ+3WWEnwwgRThR2c08R4EJY1bNPzIdQY8VPmvXGFXa3WNGZfupM0uxJtyh1xHKiKfAacuKHWLMmvdkvDBtagNRQpgCZfqfnjtpqxaoQKmj1tJF9uzCONPmDHeZC0hj0GWBReclXd2rg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778945496; c=relaxed/simple; bh=bD6WGwZnwT/PB5NAWswED+NW3RAICeGEADp8Bp8Ru+s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z7iNlvwitdrLUJqEYnlErH+TdDviSPA59JH2hTYVsamLByrPTCvv6nTrnHtC78tBLJWWofqo5B1E/AAUYrKX1y+kWPwbaMYL4cLYRrsedWjTa7SDcqzfhIWjgxRaVzPtbozmq8K2rhf5r85yIDVKHk8hjVfm0NHp/Jap1TA0pPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com; spf=pass smtp.mailfrom=yahoo.com; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b=NhA6nPae; arc=none smtp.client-ip=66.163.191.204 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yahoo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b="NhA6nPae" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1778945494; bh=8o0c3wTrLl3NcAMsAuP+jfpZyX+nfCq3O/NnytFnK+M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=NhA6nPae0st5jJ//CrllEUNfk7Veo/DS4K4u8VagFj897PRtpQo3AOeFzJF4AWeIcTTA3AEK9gwxDOiA2Le3UJMrP/gvr0u27NVx+vv2pvDxqBGNSyf5rTIA2kMydpSNeRA0u3rW9x31RLkfi5WtIU5f0uNx9koFDSSWBY+IRD9UY58f2WvU8ffVdMeFjxxqNhPzgVxocS+9o3oTYN1kDrHnQV7Fg2NbwMPn6SfNo7ybRwnhwom+A/XR0a3h7sIkegP4C5cMdQqo2lkaxID0JtqKdK6ZJW/OXoLej7koj/NM9Xv/gEPCu9K6NyhhsywFOirGg1mJb3PwKE9ric0EcA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1778945494; bh=S9wKYneDMvEyHG5ODiSdCyG6mnt7M0deDkEV4/hmiKg=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=rndk/jFem97kAwjHDRJqTxzV/geEWMtdfg//4oyOSOznktd+amFKeYyaqB99wtx2aTiltdJJT6BVdCANCRYV/aIdV2lgA0l8auzaTZszb+fgWYKFK0AeozK2NRswNenRMDLsVA7p9N6VjW3jVGK0KzDLr4QHtNF5ouyfD2vTeCGT6wlexgtzKKncmuxo5PB3QB4CjHhglLjhiboIiOEElxQ/1WIr37CjhyAvxlOcdY8qzdIFDghIu21UkGvIocPkw9Kfr9dqyrrxnejb4VULlxnczDPod5Aca6sHCC8sNJdTg9nGcc6gYzAm2oTVDqWOpt3dnG0R1ZlL+wMMpmi9UQ== X-YMail-OSG: ZBGuLe8VM1lJB9EqD6d53QFwrsB9hDBqJXPziohywNwA6P_il4bR5ZwdgDhMqQj c1.pidVIVaorudfdS0pvd8BNncZj2yVNIpifYwAH18N8lIngO2zlmHV3TonutfHRm5OTEF_s__26 JNKhLzApSDgz19jp4_jeWv1ImJGoT2NescqWw54pb2vwznV8iJh6UuCvsBEKJUpYrLOztS4RKsET m6udDVcktLDdtWK3Os5A.AykWCes3rN5hmx.Nen6Az1xV1orsJ4rOeBcVk5yoaVv7EUHWZnVjSCM ueBO5BTQAzFyfwX6UDj7uWVpBJpXZ5CcOjJ9aDg7rPZoFAEJvHQlxzlaGJyomjS8hGLbatlV74lm UKYNgMSPzkTS.nx5jMNTIAOSs.cbXWKZHPl25GinbBhA9y38D3n7hHG4aLzSbzKzJigXqHq373J6 YMzelI0vdt7UQ6dqZnTdu.T.30AN_2Y_jQKj1IKZE1FvL0HlJNO6KNVvjpDZ2whLz7lyIA30n3.j qCOusfk5puEfeN6uJL3AVhcXMu9Xv50nHS51jaSCAJpfrzLa3nQZAWSAtfyx99hgFSXGUY1BZQAR Woze8N80O6Wuu1FkCaKIJn0hscqPj3TWNzXLF_4f7xGg0jh_iPD3VN5zzpW.fH7Th7Lu._M0mCbn WikQXWuy3OzNasT4S8evVi_g0NSymgt80WhP4JRHbHki_m3MeyEUdQlVmjhdRjp10C9nu9jYvJRw 20HVa3_jadGSkfjEgUOl6B3ON_b5DzSwn1c81Ft9LzzqNrHLeohtjRA.E6NXzGJwtJootZif8qLC cvH9OApeQl3sIv3brnOIDoYfsyEqgCXLYle7MsPfuE.FOJyngAH2phE.pqbQJxXdUXI4Um4xF5oJ qYyTJsVLoN6THXyDsJ_0G5RFnTdQQdrcvfX3pSQ_RlAaLtpF9ik2a_YWdv4eIdl7zLeLu6u8XZHp MeWv4pXISGSj9jE_QrBX_ZX4GuUlx9TAyNLSRcc5TsrzDKg7y5U6TDS8bvzYCV.dyLslaWEaL8nI 1Jffklurln0f7_mRQFvxjm3uVZ_g1svkRWdPbtbyTNwd8wvZPstF_VViYs4YqpyssN_3UpwATs7Z Swph_n6Bzv8nZoa8NjFi5pfhsBvNS.v6psLybVsMfu886AZngp_TjZeaB7SZZZV3hGdzAp4Nf6dT gePdNyIJG7MjM.iCBCBL4Vw1n69bBDM2FxQL_iGnHypO39R5oBIBY32378cEm2gAMAo_7VOcTS17 rm.xcjKE20VHNdju3sOygmIHxRmzfn5OXQpEwY4IZcPb95gW8kz2503cNB4i.7.eFKJtQIA0sguh CROVcqDmYcs8Njd3jWTQfbA284ah_aWRf3MqRd50f_vGRIiUnWfhfUmRrtkyTYAjSflDIt3MEgsH 2h630LUlpL7MjTjRCFyFxSSPeHZ3wP0lqcDsIhpdCd_xi1QV_hYxIZ0aqGX285OYucUidLeDgDWz nx5qUSpTYbOlTRzCY8EKP_d90nl.raWt8f7.z_UMpxIs0plLw96qgYC9yGxG68ah0PpSSK1dhmD. zPXG1K5Eio1Nvid6PJ5hSLUoC0OEL_p04FpdwLt.RwyOYVZVonaWw_N.nbCU74zNqa5T9JjIWk7B f5it1c4h_KEj17HDi1EAjVIYdyEXmEEDfklp2iherZiqx2ir6wvM88XSUYtvPEZn9S07x7zLs8hX RMgpFZS8ZRH6MrgBpndxYMQVgwnZ1IvQhJdvT6trDwP3f.zcgFdEAuXNMQv_5caHBDP0c2c.TV00 8F_AmvDY7diAcmNxe6UiBpMASLOC6tTVrEUfWDDBHIlomCOLvoFGepIuX_djRrGQeOO8am0Uq_c3 VQDpG9lM3QAEQ5DDepneixp98Bz7aWSQqj_JubhzqbCFtFuwsbvRDk5hU5yGhOAwGsCks8DBFeis pii3MdYsdjydY0NxbsUImzhPxcw58.rnrwyADUsx553UXnZ_qUjhNPHc7z0jgHandR9LmeWsjP6V NSoyub19m2rZE9bhXmnbcKCyEufcztkA96heZf.EpvCPTH6rx8PLXmHWQMEMerDLhBcbRqtX5Fmb LGiE1SsO9Uxumdczoxs4kDJm1bI08C92wXvy3YKHImu3COdSlK_v1HbHMoNz8RthUrsapT_fLfEw bb.xwqVe.qGPegsj90CPOp7QfaUVr35n6j.KTHgWH6CnA1G8ZO3D0xfjbo1J71IIj9N825nL4sFy T8oiHvnLTrBcdc7LrJIAL9aA2izFc.SVfVotwRvijfRKRONfHII1TIHM..bzSsD_ezPXcDTgMvhy YTIQ1Kzu4w7DigMtxBBrWjFnE58ic20e_c5X_TJI0AQZLmg-- X-Sonic-MF: X-Sonic-ID: d148b691-1abd-434f-8668-8abe1a695656 Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Sat, 16 May 2026 15:31:34 +0000 Received: by hermes--production-ir2-89844b765-8tkrv (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID e383ed008e6ba98b8a171bc7f15063d3; Sat, 16 May 2026 15:31:28 +0000 (UTC) Message-ID: Date: Sat, 16 May 2026 17:31:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next PATCH v4 5/8] net: dsa: realtek: rtl8365mb: add VLAN support To: Luiz Angelo Daros de Luca , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Linus Walleij , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Yury Norov , Rasmus Villemoes , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yury Norov , Abdulkader Alrezej References: <20260516-realtek_forward-v4-0-8b6d6a1eefdc@gmail.com> <20260516-realtek_forward-v4-5-8b6d6a1eefdc@gmail.com> Content-Language: pl From: Mieczyslaw Nalewaj In-Reply-To: <20260516-realtek_forward-v4-5-8b6d6a1eefdc@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.25725 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo On 5/16/2026 5:46 AM, Luiz Angelo Daros de Luca wrote: > From: Alvin Šipraga > > Realtek RTL8365MB switches (a.k.a. RTL8367C family) use two different > structures for VLANs: > > - VLAN4K: A full table with 4096 entries defining port membership and > tagging. > - VLANMC: A smaller table with 32 entries used primarily for PVID > assignment. > > In this hardware, a port's PVID must point to an index in the VLANMC > table rather than a VID directly. Since the VLANMC table is limited to > 32 entries, the driver implements a dynamic allocation scheme to > maximize resource usage: > > - VLAN4K is treated by the driver as the source of truth for membership. > - A VLANMC entry is only allocated when a port is configured to use a > specific VID as its PVID. > - VLANMC entries are deleted when no longer needed as a PVID by any port. > > Although VLANMC has a members field, the switch only checks membership > in the VLAN4K table. However, when a corresponding VLAN entry also exists > in VLANMC, this driver keeps both membership configurations in sync. > > VLANMC index 0, although a valid entry, is reserved in this driver as a > neutral PVID value for ports not using a specific PVID. > > In the subsequent RTL8367D switch family, VLANMC table was > removed and PVID assignment was delegated to a dedicated set of > registers. > > All ports start isolated, forwarding exclusively to CPU ports, and > with VLAN transparent, ignoring VLAN membership. Once a member in a > bridge, the port isolation is expanded to include the bridge members. > When that bridge enables VLAN filtering, the VLAN transparent feature is > disabled, letting the switch filter based on VLAN setup. > > The use of FIELD_PREP for reconstructing LO/HI values was suggested by > Yury Norov. > > Fix for vlan_setup and vlan_filtering was suggested by Abdulkader > Alrezej. > > Suggested-by: Yury Norov > Suggested-by: Abdulkader Alrezej > Co-developed-by: Alvin Šipraga > Signed-off-by: Alvin Šipraga > Reviewed-by: Linus Walleij > Signed-off-by: Luiz Angelo Daros de Luca Reviewed-by: Mieczyslaw Nalewaj