From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 503D6397E94 for ; Wed, 11 Mar 2026 22:57:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773269866; cv=none; b=ET8XdfLBql9W7R0axmmsVRhrFeOwlPk+g4gLp3u3q7i/oM2thiEyyzdVdrqN2i2i2hZ7EfX80q4vgpJqzvnFY+BTlM9sGp9KeAPWnFvl189zvR49YSD/pOdpjy2bx34o+zF/zWW+nE9znZsPpaNxrm9jysO0UnT5rBNvd4x32Gs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773269866; c=relaxed/simple; bh=VHm6QSnAsA+602Lrd0emZ6caSFHzLyVnfrA1BntmvqE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=c/Tnxa2eVs53jyCaozpy+MsHzhbgjMW3pRHOi7Tv+Mnj5F6gPjZDVKSVecvi7ej8EFIFJZDY23e0SKrXGUn20evo184cEMYlU7llhCKloXN3h7Rnyjd4m0jBmVntz1VLBPlZbDe/XC3aK5SFENLpvGuIkC9EOmEVuop8PJLYxDc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bn1+/UD1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GFnw5Ws6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bn1+/UD1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GFnw5Ws6" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62BMN73u263571 for ; Wed, 11 Mar 2026 22:57:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RtNHy2LyyuXRdz/OlobybRGnBBWQatheEUj0Up6bJVI=; b=bn1+/UD1+NWbHFOo fXr9VtQHFwMIApd6ugoH3bqgeEFv6hKYPDHs4KQ8REJaPSIYIF8zKjUSptIvmLtb uwj/BPuy8MPBMoBizqRglFwFcC/8MEds8MuDoWC9yb0pVQQOPaKbWCzDX4Yx3ief 40Dc1Q9dM+/5cToC/0H7TzrBZ8DT7TVOqbxR3tCIC4dKFVojaAqUzXSP8D2UUTl9 ipLm5HjozemfxQj+rOH0heOVXhzMOtOTsper/D80jbujfAvMDqzo0N/K2+nB9nqc gJsaSVpkocSiD+InTaPpEU2zsP+/Yga5YHtEXtRgfPazYgJXPgPkWteQuqhs9x4w pRNj5Q== Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh4yg2qa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 22:57:44 +0000 (GMT) Received: by mail-oi1-f198.google.com with SMTP id 5614622812f47-463a018f61bso1744941b6e.3 for ; Wed, 11 Mar 2026 15:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773269864; x=1773874664; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RtNHy2LyyuXRdz/OlobybRGnBBWQatheEUj0Up6bJVI=; b=GFnw5Ws6rgTOoWnYyqyc33F+0RFTExcxPA3LLoqIxoArmYyOllQ0II1n416/++XXW2 RIyXCXXfIyx24wvI4bP7eIBQwyyCBmvTnbDyxQ7mPVgzfnhCAUbU4AuCNnIdP8kcLBbw Zrxndfgpx50s/do1hY5U8qUAxtFkBjGxhrjX/XS4vODvi3FmYUKy7D+lIJIG+uRShiXD OoMFq+RWbwtQ4pzK+KUgCutngceZBebgnqQ/pkvcTbQqtgsrD4XjdjVc5Oz8RtI+CBJo n49Pgc4WjUMf1M2Nim2BZGy3kGFSJJEd1gYaxkprWW6ZCNMCsYff22fnqKp1m99R5Erv oyhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773269864; x=1773874664; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RtNHy2LyyuXRdz/OlobybRGnBBWQatheEUj0Up6bJVI=; b=BloUWwFfJUWRlz8b2i9WMlEtD3/vo+E4KtiXXG7l3+XEG+FEmoG/+y1nwp0gCzUg0/ 0semx5EAulEoPTCYmSEQ7tGb9xKdQsIm2JfULT2gmm1Be4HQ8o68IE/X/fu6thFr3WvC Q0Cx4sehop0e1Htm3APgZpYjGcIl+zB7c91gL7jDPbLs6B2u1BZ1uQPhyEFoJKpvLk6Y pt+g1CTaU0D8+NQIk0i6LV9Pbs2p8IOIx8VQIjxImtraaIaOtsevlDCHu5SZOzLhxGUh dgN8MnFFWG0Rf9ngGsS20xIipN0PqgV09FiUubfpQsWilaCMWGOB+mrs/loxQAkRq3zz 9uHQ== X-Forwarded-Encrypted: i=1; AJvYcCVvm2R/5ru+UxSi/W5gPRm/nUE9PHWttBsVt/lgH0CKEbKwBD6XpMVoXoYfP9E1ljhlXsND52yrTBY8naE=@vger.kernel.org X-Gm-Message-State: AOJu0YyOFXUSKwVCTeyJzf2f0fJOj7oOjTzSdieC/u02aZomMIh1MMNR r9T3bguKIOG0n9JtEgPsteUM3WZYbCrNhKCN4l/iqAbxZMgtxB7dKdFpyYuxEOOngxJp683tmW5 WdvPv6UzwTqDfh/r1xco/jkEreX1cO8hNqsDroFxA76xSLgYlCq5CmzWc9o1UDkcRCvo= X-Gm-Gg: ATEYQzzG6f5bAPW8kz3VZ7l7de7+e8x/sFPlMNCQ0HWYG790cvZE7OQWAsOuQ22GjMD ERR5k+NAslHZZ/FIOp1duixpTbvl7UrMEukJPmIkICNXDaZsQt2RmwRSCfjTrUVit4SBfU6afxn eDSn52o4Ru1XlbNF87YkBVcTzoo5wHVTM6AVw8qHAA/OOR7wb/pWJZWQX7hWeHR7jiKqOjZ+sZA E5qSiO4lcP8tVug+xjY7Ell0UAHy4Mnep5Ryv6A4XojwrzcHOFj/3+8h8LWNp9SBiClpzsCufAa kmZdrV2Dgipj5ktIAj8nMUrC9ghF7X/hbFuS5IoKGk1TJERoV2jRDs6KENCfx2sx0oFYautngX9 6Y/v1JrOAYeL/YKqunF4B6DHNpcsqPZKRVXG2gJy2mOtRl6H3haSao4bn4xbK6f0VpOhjXnJYoS ZLIGI= X-Received: by 2002:a05:6808:1920:b0:45c:7b2c:10bb with SMTP id 5614622812f47-46733641014mr2342947b6e.60.1773269863602; Wed, 11 Mar 2026 15:57:43 -0700 (PDT) X-Received: by 2002:a05:6808:1920:b0:45c:7b2c:10bb with SMTP id 5614622812f47-46733641014mr2342938b6e.60.1773269863167; Wed, 11 Mar 2026 15:57:43 -0700 (PDT) Received: from [10.71.180.216] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5614622812f47-46734340842sm2034184b6e.18.2026.03.11.15.57.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Mar 2026 15:57:42 -0700 (PDT) Message-ID: Date: Wed, 11 Mar 2026 15:57:40 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 02/10] usb: misc: qcom_eud: add sysfs attribute for port selection To: Greg Kroah-Hartman Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Souradeep Chowdhury , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260309203337.803986-1-elson.serrao@oss.qualcomm.com> <20260309203337.803986-3-elson.serrao@oss.qualcomm.com> <2026031101-cornstalk-partner-a30e@gregkh> Content-Language: en-US From: Elson Serrao In-Reply-To: <2026031101-cornstalk-partner-a30e@gregkh> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDE5NiBTYWx0ZWRfX/rZAOFadH0KL U8l/DBO5R5Bjc9Ahlhm7B3Ev9UZHHRX6I5iTrR4y1c9qItOzzvDSVE+VYkDvNSb/fdJ9FC07T9h 2fGIRKTz31ZOhpQQ7cpDYxKnQvehMzcA6N57bpHsQJZ0Ai6DmpaSVOYQwQKSH8ycgc4hIiZ1UMD X8N+cerup/nprILihTeM7B3pD15RSEvdx7zboZL0LJGhoIJuKFln+e5jRCQ9WSorPT6kwPaFeAc PFWE0Na9bNH8P7CatA4rMPX1uKXAotU6nrh3t6aSzJhrjMIjIcEEkKK4d18UJbA2/yLCTUUte0L hUu68IYEd8U3M9iT2IJw7iuoaB29AStJajHIgmVx8rmeTUO4XZg/JPrMGGXaWNr5ZwMTWkIEX+6 cEVY4yRDaF0GL5hG3nMAsgOOJLDAr7lvEaosr1eWEZtciaYORO0LVRn5dtqF0pUGm1ItMgdjR/N aWkNEMZqxAokLYTav5A== X-Proofpoint-ORIG-GUID: RNoZ8Xv5Dhw57IE0GYHUu1mhb5vZk6xU X-Authority-Analysis: v=2.4 cv=C+7kCAP+ c=1 sm=1 tr=0 ts=69b1f368 cx=c_pps a=4ztaESFFfuz8Af0l9swBwA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=IAXstxnVdUbjqp5kDF4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=TPnrazJqx2CeVZ-ItzZ-:22 X-Proofpoint-GUID: RNoZ8Xv5Dhw57IE0GYHUu1mhb5vZk6xU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603110196 On 3/11/2026 6:16 AM, Greg Kroah-Hartman wrote: [...] >> + >> +What: /sys/bus/platform/drivers/qcom_eud/.../port >> +Date: January 2026 >> +Contact: Elson Serrao >> +Description: >> + Selects which USB port the Embedded USB Debugger (EUD) >> + is mapped to on platforms providing multiple High-Speed >> + USB ports. >> + >> + Valid values: >> + 0 - Primary USB port >> + 1 - Secondary USB port > > Why not use "primary" and "secondary" as values instead? That makes > this much simpler to understand. > [...] >> >> +static ssize_t port_show(struct device *dev, >> + struct device_attribute *attr, char *buf) >> +{ >> + struct eud_chip *chip = dev_get_drvdata(dev); >> + >> + return sysfs_emit(buf, "%u\n", chip->port_idx); > > Wait, you are returning a 0/1 here, yet using a u8? How can that work? > Thanks for the review, Greg. I’ll switch the sysfs attribute to use "primary"/"secondary" values (instead of numeric 0/1) as suggested and update the ABI doc and driver. This should also resolve the ambiguity around the current 0/1 output. Regards, Elson