mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
To: "Uwe Kleine-König" <ukleinek@kernel.org>
Cc: <robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<wbg@kernel.org>, <jic23@kernel.org>, <catalin.marinas@arm.com>,
	<will@kernel.org>, <devicetree@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
	<linux-pwm@vger.kernel.org>, <olivier.moysan@foss.st.com>,
	<lee@kernel.org>, <alexandre.torgue@foss.st.com>
Subject: Re: [PATCH v3 4/8] pwm: stm32: add support for stm32mp25
Date: Fri, 13 Jun 2025 15:44:57 +0200	[thread overview]
Message-ID: <c3208fec-53ac-46eb-907f-cc5b7a18b188@foss.st.com> (raw)
In-Reply-To: <5ui74qlssllgn4h34by5jcpi5g6rknziclcsh4w27tjvznynsv@lcjtjxn6rovl>

On 5/15/25 11:24, Uwe Kleine-König wrote:
> Hello Fabrice,
> 
> On Wed, May 14, 2025 at 11:30:26AM +0200, Fabrice Gasnier wrote:
>> On 1/10/25 10:19, Fabrice Gasnier wrote:
>>> Add support for STM32MP25 SoC. Use newly introduced compatible to handle
>>> new features along with registers and bits diversity.
>>> The MFD part of the driver fills in ipidr, so it is used to check the
>>> hardware configuration register, when available to gather the number
>>> of PWM channels and complementary outputs.
>>>
>>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
>>> ---
>>> Changes in v2:
>>> Address Uwe review comments:
>>> - Make MAX_PWM_OUTPUT definition less generic: STM32_PWM_MAX_OUTPUT
>>> - No need to initialize 'npwm'
>>> - refactor code, for *num_enabled to use same code path
>>> ---
>>>  drivers/pwm/pwm-stm32.c | 42 ++++++++++++++++++++++++++++++++++-------
>>>  1 file changed, 35 insertions(+), 7 deletions(-)
>>
>> Hi Uwe,
>>
>> I think this patch still miss some reviews.
>> The first patches of this series have been merged.
>>
>> Is it ok for you to merge, or shall I resend separately ?
> 
> I have it still on my radar, no need to resend. I just have to find the
> time to look into it in more detail.

Hello Uwe,

Gentle reminder, I hope you may find some time to review this patch ?

Best Regards,
Fabrice

> 
> Best regards
> Uwe

  reply	other threads:[~2025-06-13 13:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10  9:19 [PATCH v3 0/8] Add STM32MP25 timers support: MFD, PWM, IIO and counter drivers Fabrice Gasnier
2025-01-10  9:19 ` [PATCH v3 1/8] dt-bindings: mfd: stm32-timers: add support for stm32mp25 Fabrice Gasnier
2025-01-10  9:19 ` [PATCH v3 2/8] " Fabrice Gasnier
2025-01-10  9:19 ` [PATCH v3 3/8] counter: stm32-timer-cnt: " Fabrice Gasnier
2025-05-14  9:30   ` Fabrice Gasnier
2025-05-15  0:16     ` William Breathitt Gray
2025-05-15  0:21   ` (subset) " William Breathitt Gray
2025-01-10  9:19 ` [PATCH v3 4/8] pwm: stm32: " Fabrice Gasnier
2025-05-14  9:30   ` Fabrice Gasnier
2025-05-15  9:24     ` Uwe Kleine-König
2025-06-13 13:44       ` Fabrice Gasnier [this message]
2025-06-16 15:44   ` Uwe Kleine-König
2025-01-10  9:19 ` [PATCH v3 5/8] arm64: defconfig: enable STM32 timers drivers Fabrice Gasnier
2025-01-10  9:19 ` [PATCH v3 6/8] arm64: dts: st: add timer nodes on stm32mp251 Fabrice Gasnier
2025-01-10  9:19 ` [PATCH v3 7/8] arm64: dts: st: add timer pins for stm32mp257f-ev1 Fabrice Gasnier
2025-01-10  9:19 ` [PATCH v3 8/8] arm64: dts: st: add timer nodes on stm32mp257f-ev1 Fabrice Gasnier
2025-02-10 16:44 ` (subset) [PATCH v3 0/8] Add STM32MP25 timers support: MFD, PWM, IIO and counter drivers Lee Jones
2025-07-04  9:10 ` Alexandre TORGUE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3208fec-53ac-46eb-907f-cc5b7a18b188@foss.st.com \
    --to=fabrice.gasnier@foss.st.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=robh@kernel.org \
    --cc=ukleinek@kernel.org \
    --cc=wbg@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®