From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFD79C54EBD for ; Thu, 12 Jan 2023 03:42:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231690AbjALDmm (ORCPT ); Wed, 11 Jan 2023 22:42:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229561AbjALDmh (ORCPT ); Wed, 11 Jan 2023 22:42:37 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4A3E44378 for ; Wed, 11 Jan 2023 19:42:36 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id y25so26557474lfa.9 for ; Wed, 11 Jan 2023 19:42:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jLHtoE959u40G0xbX28KrB8L8Do3FTdLcmezZ+Ohpr8=; b=YpauyFYgXE4dRDmivNFp/j2H4FoZtQkEFypYGteVIZ2dMLikBrHLjmTkAae4+PLlWg +URvMWTOiZNnIhBoBb8E+XemGxzDOMd8QFlg5YXQFQkL/20Eubtu8MK/mHfHVH9mVUTm lkaAmXvrD+wN4YqYIStIPe6MMVHDYPXPgpBBKUTBL4SgKZG4aThbi/HPlEiwZivM1YOJ RFt4IVrY6x8P05m+hbN8xKPrQgva4UaZ0Y08qrkuaHUAJy5QT6NTTV3fYBWK4iFzxKak 3atssbaNGxv42pnWPaDDh5OKHiKDj1bPlNUS0qvCPsOyS8BlYXWWY/lniu2y24XhThMx it4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jLHtoE959u40G0xbX28KrB8L8Do3FTdLcmezZ+Ohpr8=; b=acfBwAWVGaRILTY7XIzvYp3K8N4bMiaeDWdD8GusEdTAOV6bpEyvsw4OLh1H8uRhgq Tf6mcagqBfPJJ+7H9xxuPxUchjqCQZzV2gHQwrFlDrKroe9IZIS+qhK9IO4sQDIIUUmk GkIw1nRkBSW3cVMzlh3X6vwOX4Ylt6NHitUEfCtK2zYgRsTqdnmRLyTHUdh0QdKUkmL2 hfiBzgAvIrDvpTeAhgRGMaolsUpQVoWHNz/WeIPxFkU7jMTBd0gYp14p5OrNAonpnv1u ah4GAAY4bqPN9ad3lj8c9Pr4mQbEtttiBlGNINrm/IMUWvvhmXkXJpY8DyS5h45XI560 g6og== X-Gm-Message-State: AFqh2kq9ekicxKb/dvWVdQ7LG26I71tdq09JmFsa990CLQlBBIBxqYvk +Ub0SrkOWWl4L6itdublagPoQQ== X-Google-Smtp-Source: AMrXdXuAjlLyWrwlXPju1jhRFwVMDKZBuI77Lkwtin61RZmeiNOZGX9nHS19HZduB4tcQ9jqucCMDw== X-Received: by 2002:a05:6512:6d6:b0:4a4:68b9:609b with SMTP id u22-20020a05651206d600b004a468b9609bmr25117729lff.38.1673494955164; Wed, 11 Jan 2023 19:42:35 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id v10-20020a056512348a00b004a4731f75a5sm3033409lfr.250.2023.01.11.19.42.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 19:42:34 -0800 (PST) Message-ID: Date: Thu, 12 Jan 2023 05:42:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] drm/msm/dpu: Remove some unused variables Content-Language: en-GB To: Jiapeng Chong , robdclark@gmail.com Cc: quic_abhinavk@quicinc.com, sean@poorly.run, airlied@gmail.com, daniel@ffwll.ch, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abaci Robot References: <20230112033823.24901-1-jiapeng.chong@linux.alibaba.com> From: Dmitry Baryshkov In-Reply-To: <20230112033823.24901-1-jiapeng.chong@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/01/2023 05:38, Jiapeng Chong wrote: > Variables 'sc8280xp_regdma' and 'sm8350_regdma' are defined in the > dpu_hw_catalog.c file, but not used elsewhere, so remove these unused > variables. > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:2029:37: warning: unused variable 'sc8280xp_regdma'. > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c:2053:37: warning: unused variable 'sm8350_regdma'. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3722 > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 16 ---------------- > 1 file changed, 16 deletions(-) NAK, the patch should change catalog entries to use correct regdma entries instead of deleting them. -- With best wishes Dmitry