From: Edward Cree <ecree.xilinx@gmail.com>
To: Daniel Zahka <daniel.zahka@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] ethtool: rss: prevent rss ctx deletion when in use
Date: Wed, 16 Oct 2024 17:23:21 +0100 [thread overview]
Message-ID: <c32a876f-4d20-c975-5a2f-3fa0ab229f05@gmail.com> (raw)
In-Reply-To: <43a98a99-4c79-4954-82f1-b634e4d1be82@gmail.com>
On 15/10/2024 17:31, Daniel Zahka wrote:
> On 10/14/24 6:10 AM, Edward Cree wrote:
>> Imho it would make more sense to add core tracking of ntuple
>> filters, along with a refcount on the rss context. That way
>> context deletion just has to check the count is zero.
>>
>> -ed
>
> That sounds good to me. Is that something you are planning on sending patches for?
I'm afraid I don't have the bandwidth to do it any time soon.
If you aren't able to take this on, I'm okay with your original
approach to get the issue fixed; I just wanted to ensure the
'better' solution was considered if you do have the time for it.
next prev parent reply other threads:[~2024-10-16 16:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 18:35 [PATCH net-next 0/2] ethtool: rss: track rss ctx busy from core Daniel Zahka
2024-10-11 18:35 ` [PATCH net-next 1/2] ethtool: rss: prevent rss ctx deletion when in use Daniel Zahka
2024-10-14 10:10 ` Edward Cree
2024-10-15 0:53 ` Jakub Kicinski
2024-10-15 16:31 ` Daniel Zahka
2024-10-16 16:23 ` Edward Cree [this message]
2024-10-16 16:50 ` Daniel Zahka
2024-10-17 8:21 ` Paolo Abeni
2024-10-11 18:35 ` [PATCH net-next 2/2] selftests: drv-net: rss_ctx: add rss ctx busy testcase Daniel Zahka
2024-10-17 8:30 ` [PATCH net-next 0/2] ethtool: rss: track rss ctx busy from core patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c32a876f-4d20-c975-5a2f-3fa0ab229f05@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®