mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	linux-kernel@vger.kernel.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	stable@vger.kernel.org, linux-sh <linux-sh@vger.kernel.org>
Subject: Re: [PATCH 7/7 v4] sh: mcount.S: fix build error when PRINTK is not enabled
Date: Mon, 20 Mar 2023 14:32:40 +0100	[thread overview]
Message-ID: <c33548dd94ca23347a418743120aed4a552264a2.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <CAMuHMdVR78EXTVd7ThUEv6rxL8aHSyAoC_5z8KyAPmiTyww85w@mail.gmail.com>

Hi Geert!

On Mon, 2023-03-20 at 13:42 +0100, Geert Uytterhoeven wrote:
> Oops, obviously all of that happened before my morning coffee ;-)
> 
> Makefile has:
> 
>     ifdef CONFIG_FRAME_POINTER
>     KBUILD_CFLAGS   += -fno-omit-frame-pointer -fno-optimize-sibling-calls
>     KBUILD_RUSTFLAGS += -Cforce-frame-pointers=y
>     else
>     # Some targets (ARM with Thumb2, for example), can't be built with frame
>     # pointers.  For those, we don't have FUNCTION_TRACER automatically
>     # select FRAME_POINTER.  However, FUNCTION_TRACER adds -pg, and this is
>     # incompatible with -fomit-frame-pointer with current GCC, so we don't use
>     # -fomit-frame-pointer with FUNCTION_TRACER.
>     # In the Rust target specification, "frame-pointer" is set explicitly
>     # to "may-omit".
>     ifndef CONFIG_FUNCTION_TRACER
>     KBUILD_CFLAGS   += -fomit-frame-pointer
>     endif
>     endif
> 
> Your config probably has CONFIG_FRAME_POINTER set?
> 
>     arch/sh/Kconfig.debug=config DWARF_UNWINDER
>     arch/sh/Kconfig.debug-  bool "Enable the DWARF unwinder for stacktraces"
>     arch/sh/Kconfig.debug-  depends on DEBUG_KERNEL
>     arch/sh/Kconfig.debug:  select FRAME_POINTER
> 
> You should make sure that cannot happen when CONFIG_FUNCTION_TRACER
> is enabled. I.e. make DWARF_UNWINDER depend on !FUNCTION_TRACER?
> 
> Other architectures do something similar:
> 
>     arch/sparc/Kconfig.debug:config FRAME_POINTER
>     arch/sparc/Kconfig.debug-       bool
>     arch/sparc/Kconfig.debug-       depends on MCOUNT
> 
>     arch/x86/Kconfig.debug:config FRAME_POINTER
>     arch/x86/Kconfig.debug- depends on !UNWINDER_ORC && !UNWINDER_GUESS
>     arch/x86/Kconfig.debug- bool
> 
> Probably you need to adjust the following, too:
> 
>     lib/Kconfig.debug:config FRAME_POINTER
>     lib/Kconfig.debug-      bool "Compile the kernel with frame pointers"
>     lib/Kconfig.debug-      depends on DEBUG_KERNEL && (M68K || UML ||
> SUPERH) || ARCH_WANT_FRAME_POINTERS
>     lib/Kconfig.debug-      default y if (DEBUG_INFO && UML) ||
> ARCH_WANT_FRAME_POINTERS
> 
> i.e. drop SUPERH from the list above, and select ARCH_WANT_FRAME_POINTERS
> if !FUNCTION_TRACER.

Do you think you can send a patch for this change? I can then review and apply
it together with Randy's series in case everything works as expected.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

  parent reply	other threads:[~2023-03-20 13:32 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06  4:00 [PATCH 0/7 v4] sh: various doc, build, init fixes Randy Dunlap
2023-03-06  4:00 ` [PATCH 1/7 v4] sh: SH2007: drop the bad URL info Randy Dunlap
2023-03-19 19:22   ` John Paul Adrian Glaubitz
2023-03-06  4:00 ` [PATCH 2/7 v4] sh: nmi_debug: fix return value of __setup handler Randy Dunlap
2023-03-19 19:32   ` John Paul Adrian Glaubitz
2023-03-06  4:00 ` [PATCH 3/7 v4] sh: init: use OF_EARLY_FLATTREE for early init Randy Dunlap
2023-03-19 19:48   ` John Paul Adrian Glaubitz
2023-03-06  4:00 ` [PATCH 4/7 v4] sh: math-emu: fix macro redefined warning Randy Dunlap
2023-03-19 19:49   ` John Paul Adrian Glaubitz
2023-03-06  4:00 ` [PATCH 5/7 v4] sh: remove sh5/sh64 last fragments Randy Dunlap
2023-03-16 13:23   ` John Paul Adrian Glaubitz
2023-03-16 16:44     ` Randy Dunlap
2023-03-16 16:52       ` John Paul Adrian Glaubitz
2023-03-16 20:43         ` Randy Dunlap
2023-03-16 20:46           ` John Paul Adrian Glaubitz
2023-03-17  7:31             ` Geert Uytterhoeven
2023-03-17  7:51               ` John Paul Adrian Glaubitz
2023-03-19 19:50   ` John Paul Adrian Glaubitz
2023-03-06  4:00 ` [PATCH 6/7 v4] sh: fix Kconfig entry for NUMA => SMP Randy Dunlap
2023-03-19 20:20   ` John Paul Adrian Glaubitz
2023-03-20 20:13     ` John Paul Adrian Glaubitz
2023-03-20 20:17       ` Randy Dunlap
2023-03-06  4:00 ` [PATCH 7/7 v4] sh: mcount.S: fix build error when PRINTK is not enabled Randy Dunlap
2023-03-19 20:49   ` John Paul Adrian Glaubitz
2023-03-20  8:16     ` Geert Uytterhoeven
2023-03-20  9:13       ` John Paul Adrian Glaubitz
2023-03-20 12:42         ` Geert Uytterhoeven
2023-03-20 12:43           ` Geert Uytterhoeven
2023-03-20 13:32           ` John Paul Adrian Glaubitz [this message]
2023-03-20 20:10           ` John Paul Adrian Glaubitz
2023-03-20 20:09   ` John Paul Adrian Glaubitz
2023-03-07 15:18 ` [PATCH 0/7 v4] sh: various doc, build, init fixes John Paul Adrian Glaubitz
2023-03-16 13:26 ` John Paul Adrian Glaubitz
2023-03-23  9:41 ` John Paul Adrian Glaubitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c33548dd94ca23347a418743120aed4a552264a2.camel@physik.fu-berlin.de \
    --to=glaubitz@physik.fu-berlin.de \
    --cc=dalias@libc.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=stable@vger.kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®