From: Dan Carpenter <dan.carpenter@linaro.org>
To: Yogesh Hegde <yogi.kernel@gmail.com>
Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] staging: rtl8192e: Remove variable SetWirelessMode
Date: Thu, 8 Jun 2023 13:27:44 +0300 [thread overview]
Message-ID: <c3397bcc-e6b2-4ed1-a8c4-715c739d6977@kadam.mountain> (raw)
In-Reply-To: <20230608095938.GA598514@yogi-Zephyrus>
On Thu, Jun 08, 2023 at 03:29:38PM +0530, Yogesh Hegde wrote:
> On Wed, Jun 07, 2023 at 10:18:28PM +0200, Philipp Hortmann wrote:
> Dan, Greg and Philipp what would be the best fix for this issue,
> 1. Patchset to combine both the modules into one module
> 2. Revert back this patchset to v1.
Neither of those options are good. I haven't investigated this problem
to figure out what the correct option is but we're unlikely to merge
either of those unless you make some very persuasive arguments.
regards,
dan carpenter
next prev parent reply other threads:[~2023-06-08 10:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 15:01 [PATCH v2 0/5] Trivial code cleanup patches Yogesh Hegde
2023-06-07 15:01 ` [PATCH v2 1/5] staging: rtl8192e: Remove variable SetWirelessMode Yogesh Hegde
2023-06-07 15:07 ` Dan Carpenter
2023-06-07 20:18 ` Philipp Hortmann
2023-06-08 9:00 ` Dan Carpenter
2023-06-08 9:59 ` Yogesh Hegde
2023-06-08 10:27 ` Dan Carpenter [this message]
2023-06-08 12:43 ` Philipp Hortmann
2023-06-12 1:52 ` kernel test robot
2023-06-07 15:02 ` [PATCH v2 2/5] staging: rtl8192e: Remove variable SetBWModeHandler Yogesh Hegde
2023-06-13 9:16 ` kernel test robot
2023-06-07 15:02 ` [PATCH v2 3/5] staging: rtl8192e: Remove variable LeisurePSLeave Yogesh Hegde
2023-06-07 15:02 ` [PATCH v2 4/5] staging: rtl8192e: Remove variable InitialGainHandler Yogesh Hegde
2023-06-07 15:03 ` [PATCH v2 5/5] staging: rtl8192e: Remove DRV_NAME definition in rtllib_debug.h Yogesh Hegde
2023-06-07 15:10 ` [PATCH v2 0/5] Trivial code cleanup patches Dan Carpenter
2023-06-15 10:36 ` Greg Kroah-Hartman
2023-06-15 14:09 ` Yogesh Hegde
2023-06-15 14:34 ` Greg Kroah-Hartman
2023-06-15 16:11 ` Yogesh Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3397bcc-e6b2-4ed1-a8c4-715c739d6977@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
--cc=yogi.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®