From: Andrew Lunn <andrew@lunn.ch>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Sky Huang <SkyLake.Huang@mediatek.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Qingfang Deng <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Steven Liu <Steven.Liu@mediatek.com>
Subject: Re: [PATCH net-next 3/3] net: phy: mediatek: add driver for built-in 2.5G ethernet PHY on MT7988
Date: Sun, 19 Jan 2025 18:35:34 +0100 [thread overview]
Message-ID: <c339e887-b576-4f0e-988c-4cd8f27d47a7@lunn.ch> (raw)
In-Reply-To: <Z4hnv2lzy8Ntd_Hp@makrotopia.org>
> Imho it's fine to add the driver without support for the LEDs for now
> and add LED support later on. But in that case you also shouldn't call
> mtk_phy_leds_state_init().
It is also O.K. to hard code the default LED meanings, different to
the reset defaults. But you need to think ahead to when you do add
full LED support, you want the defaults to be something which the LED
subsystem can represent and take over when it controls the LEDs.
Andrew
next prev parent reply other threads:[~2025-01-19 17:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 1:21 [PATCH net-next 0/3] net: phy: mediatek: Add token-ring ops Sky Huang
2025-01-16 1:21 ` [PATCH net-next 1/3] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib Sky Huang
2025-01-16 12:55 ` Krzysztof Kozlowski
2025-01-19 17:12 ` Andrew Lunn
2025-02-13 7:39 ` SkyLake Huang (黃啟澤)
2025-02-13 13:29 ` Andrew Lunn
2025-02-13 13:43 ` Daniel Golle
2025-02-13 15:34 ` Andrew Lunn
2025-02-14 3:35 ` SkyLake Huang (黃啟澤)
2025-02-16 16:39 ` Andrew Lunn
2025-01-16 1:21 ` [PATCH net-next 2/3] net: phy: mediatek: Move some macros to phy-lib for later use Sky Huang
2025-01-19 17:20 ` Andrew Lunn
2025-01-16 1:21 ` [PATCH net-next 3/3] net: phy: mediatek: add driver for built-in 2.5G ethernet PHY on MT7988 Sky Huang
2025-01-16 1:58 ` Daniel Golle
2025-01-19 17:35 ` Andrew Lunn [this message]
2025-02-14 13:13 ` SkyLake Huang (黃啟澤)
2025-01-16 12:45 ` Krzysztof Kozlowski
2025-02-14 13:23 ` SkyLake Huang (黃啟澤)
2025-02-14 15:31 ` Krzysztof Kozlowski
2025-01-16 12:51 ` Krzysztof Kozlowski
2025-01-19 17:31 ` Andrew Lunn
2025-02-14 13:25 ` SkyLake Huang (黃啟澤)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c339e887-b576-4f0e-988c-4cd8f27d47a7@lunn.ch \
--to=andrew@lunn.ch \
--cc=SkyLake.Huang@mediatek.com \
--cc=Steven.Liu@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®