From: Markus Elfring <Markus.Elfring@web.de>
To: Jonathan Richardson <jonathan.richardson@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Cc: "Dejin Zheng" <zhengdejin5@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Petr Štetiar" <ynezz@true.cz>, "Ray Jui" <ray.jui@broadcom.com>,
"Scott Branden" <scott.branden@broadcom.com>,
"Stephen Boyd" <swboyd@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: net: broadcom: fix a mistake about ioremap resource
Date: Thu, 7 May 2020 13:16:29 +0200 [thread overview]
Message-ID: <c33b90a6-3f4d-d3fb-7f65-928247cd2ee7@web.de> (raw)
In-Reply-To: <CAHrpVsWbAdf+K1+mToj-5yoj-quFoXwF5D6_aAKufBE2tNSkFA@mail.gmail.com>
>> I hope that other contributors can convince you to improve also this
>> commit message considerably.
>> Would you like to fix the spelling besides other wording weaknesses?
>
> How about this wording:
>
> Commit d7a5502b0bb8b ("net: broadcom: convert to
> devm_platform_ioremap_resource_byname()")
> inadvertently made idm_base and nicpm_base mandatory. These are
> optional properties.
> probe will fail when they're not defined. The commit is partially
> reverted so that they are
> obtained by platform_get_resource_byname() as before. amac_base can
> still be obtained
> by devm_platform_ioremap_resource_byname().
Is it interesting anyhow that another attempt for such an improvement
did not get the possibly desired software development attention?
https://lore.kernel.org/lkml/20200505.111206.118627398774406136.davem@davemloft.net/
https://lore.kernel.org/patchwork/comment/1430759/
https://lkml.org/lkml/2020/5/5/1114
Regards,
Markus
prev parent reply other threads:[~2020-05-07 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 7:19 [PATCH] " Markus Elfring
2020-05-05 17:44 ` Jonathan Richardson
2020-05-07 11:16 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c33b90a6-3f4d-d3fb-7f65-928247cd2ee7@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jonathan.richardson@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ray.jui@broadcom.com \
--cc=scott.branden@broadcom.com \
--cc=swboyd@chromium.org \
--cc=ynezz@true.cz \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®