From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02804C433E0 for ; Mon, 8 Mar 2021 12:05:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB894651C5 for ; Mon, 8 Mar 2021 12:05:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231159AbhCHMEd (ORCPT ); Mon, 8 Mar 2021 07:04:33 -0500 Received: from foss.arm.com ([217.140.110.172]:36840 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229965AbhCHMET (ORCPT ); Mon, 8 Mar 2021 07:04:19 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AC600D6E; Mon, 8 Mar 2021 04:04:18 -0800 (PST) Received: from [10.57.19.192] (unknown [10.57.19.192]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CCB353F70D; Mon, 8 Mar 2021 04:04:16 -0800 (PST) Subject: Re: [PATCH v5 1/4] PM / devfreq: Register devfreq as a cooling device on demand To: Daniel Lezcano Cc: cwchoi00@gmail.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, steven.price@arm.com, MyungJoo Ham , Kyungmin Park , Chanwoo Choi References: <20210308091646.28096-1-daniel.lezcano@linaro.org> From: Lukasz Luba Message-ID: Date: Mon, 8 Mar 2021 12:04:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/8/21 12:00 PM, Daniel Lezcano wrote: > On 08/03/2021 10:53, Lukasz Luba wrote: >> Hi Daniel, >> >> In general the approach is good. If there is a special GPU driver, which >> would like to provide 'struct devfreq_cooling_power *' it would leave >> 'is_cooling_device=false' and register manually: >> devfreq_cooling_em_register(df, dfc_power); >> >> Please find only a few minor comments below. >> >> >> On 3/8/21 9:16 AM, Daniel Lezcano wrote: >>> Currently the default behavior is to manually having the devfreq >>> backend to register themselves as a devfreq cooling device. >>> >>> Instead of adding the code in the drivers for the thermal cooling >>> device registering, let's provide a flag in the devfreq's profile to >>> tell the common devfreq code to register the newly created devfreq as >>> a cooling device. >>> >>> Suggested-by: Chanwoo Choi >>> Signed-off-by: Daniel Lezcano >>> --- > > [ ... ] > >>> +    struct thermal_cooling_device *cdev; >> >> The linux/thermal.h for 'cdev' would be needed in this header. > > May be just a forward declaration ? > > struct thermal_cooling_device; Make sense Regards, Lukasz