From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751507AbdAaKCt (ORCPT ); Tue, 31 Jan 2017 05:02:49 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:36963 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750809AbdAaKCk (ORCPT ); Tue, 31 Jan 2017 05:02:40 -0500 Subject: Re: [PATCH 02/17] net: stmmac: Remove the bus_setup function pointer To: Corentin Labbe , , References: <20170131091152.13842-1-clabbe.montjoie@gmail.com> <20170131091152.13842-3-clabbe.montjoie@gmail.com> CC: , , Patrice CHOTARD From: Giuseppe CAVALLARO Message-ID: Date: Tue, 31 Jan 2017 11:02:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20170131091152.13842-3-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.48] X-ClientProxiedBy: SFHDAG1NODE2.st.com (10.75.127.2) To SFHDAG4NODE1.st.com (10.75.127.10) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-31_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/31/2017 10:11 AM, Corentin Labbe wrote: > The bus_setup function pointer is not used at all, this patch remove it. indeed this was used and documented on some previous kernels where some ST40/SH4 platforms (w/o DT). It's ok to remove it in the new MAC generation; I do not think that ST will re-use it on new development. Peppe > > Signed-off-by: Corentin Labbe > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ---- > include/linux/stmmac.h | 1 - > 2 files changed, 5 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index e3f6389..bf2d8e6 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -1671,10 +1671,6 @@ static int stmmac_hw_setup(struct net_device *dev, bool init_ptp) > /* Copy the MAC addr into the HW */ > priv->hw->mac->set_umac_addr(priv->hw, dev->dev_addr, 0); > > - /* If required, perform hw setup of the bus. */ > - if (priv->plat->bus_setup) > - priv->plat->bus_setup(priv->ioaddr); > - > /* PS and related bits will be programmed according to the speed */ > if (priv->hw->pcs) { > int speed = priv->plat->mac_port_sel_speed; > diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h > index 266dab9..2d82df9 100644 > --- a/include/linux/stmmac.h > +++ b/include/linux/stmmac.h > @@ -135,7 +135,6 @@ struct plat_stmmacenet_data { > int tx_fifo_size; > int rx_fifo_size; > void (*fix_mac_speed)(void *priv, unsigned int speed); > - void (*bus_setup)(void __iomem *ioaddr); > int (*init)(struct platform_device *pdev, void *priv); > void (*exit)(struct platform_device *pdev, void *priv); > void *bsp_priv; >