From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f52.google.com (mail-yx1-f52.google.com [74.125.224.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9324430CDA0 for ; Wed, 24 Dec 2025 19:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766603265; cv=none; b=E5MhYXl2hLbcVJylNiAYJjti6vBm8JOdjVPCqZwiEGnrETEwmMOdwh/Bihp5RqWJlsvE2u0DLw5vobrlszxZMD/7FVBFxm3FcjJptEIXQ3JmZdpaiViCSCRtLVp3FKljO1EEswlj++4+Favitq9e+tcJYHtxWvDQlRnaki86lW8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766603265; c=relaxed/simple; bh=xGMey4A7iFVHAmrVZuSavckmgLulJhGs63Zh3metjjY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jXmXAI5LAGrHC6lSMK1Nz6+Tl/dqw3yDFH8P73/02rO0v89/80zPrFSJFrM6P+iPpbOpn9r554tPa9+R67CpgKFbrZBTMBIvpoF/c+3KEFn1wy18GoQsHYBw4MVg4Y1O/0fb3eh28CBXNr8uP7o9O916pCTp3np7XdbXcwbM+KE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=jt48wwVz; arc=none smtp.client-ip=74.125.224.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jt48wwVz" Received: by mail-yx1-f52.google.com with SMTP id 956f58d0204a3-6446fcddf2fso5425918d50.0 for ; Wed, 24 Dec 2025 11:07:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1766603261; x=1767208061; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NzIVnDZpOLjchy2wgbEcpJaoavN6zFZmqhSGhoRwcq0=; b=jt48wwVzAY30EJsCgsBi7TrUZHYIH4B7dENfIKwBOgf+orFGCMZ9TbGni6VSrbHmdI LPK3rS9lwcDDXS6PnM9tsNqrFgZ7p2KuWtrjQMcqMm//eCk9BKnUomcvLXovIP2xunU2 B6SbxvRopOesHK+AkV3hoIJG//jR3l+5+m301qKjGd44VvSJfsthjTX2uhcGj/bSFdIv /RNSYyo8UUlEjlTDCeM13EDgRLXa1Am1Xyvy1AR6PHvQqG9BJn9aCjzvQPJrv6iWzFDk EGY1aznIp1KannV8iZph+snCe15e2bn28pj/gkm5t81hhSPQDlAsc8A5HMnv1mP/5xq9 uSfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766603261; x=1767208061; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NzIVnDZpOLjchy2wgbEcpJaoavN6zFZmqhSGhoRwcq0=; b=J7CPZjPGJkFMJzkJSBbXlUdrso5nEpo5gbNEIdr3kWE1i9PsULeIGRp6M/cseHeJLp Tdj5WLYXYbNh1Q0xfzAHxeDaTJ12d93mDLtWALxfipj5QWUzuxeevitJW5KDlcq/QL4w 2SB80UK2Brm+8rK8ljmY1C4qJcrXmrAF7FaPgLBlcWPy/IGYyFP1iOWM5pdnCNKHfUY2 G0UnE+Dwwv55UhDhMOj3i1bsql0RsCQlRbFA71kz3v6MxvQ6tQQ7EcA8tpp6q9X2fs7H 0F/VSIBkd7O6MA1stFhy31A5mp/SfvZBS+VFWiZSx7wfoxRAVV1jl9epnSU+MbvRDaou oN8Q== X-Gm-Message-State: AOJu0Yx9BAsoX6S+PmZ4IRi64WQD7oNG56gR+Rfu/2I5nIYFVF3Qih11 NRZ8Ia03TEf8/7vtwWGPax+f+j/bGP9sDH7YzZr2FUScB+Je2DDySkVSp8Ry4mQYqg== X-Gm-Gg: AY/fxX7Wihq70qQR8h4GPUveMOFnllw8CjEKhAMr7rF3fnU6YGu4oc+1GkDJIa4CmQm LR9gHDwSxcTlylK5JNHqdNr6ZNncWbkPglkKOMa6KsunMPv/qjaRFM3wdGsg+tg4WrkyfKozoFp MlxWdqDYfH0oEvWdO8xFoJdAmKK0ygDSV3IjAWB1JRjEkdHsoWK8rvi8MgHEUTC2gJgczLrfZ4m /KLXp7ynd8tY/kFNRuP+HXfXR+hRYA8rQgtQw7k3SsYxnd171gRhLC2xvufjjupfqop8PmHe7L9 nsPSzYfTBg/OAvDdm0UEw09ukfX/W5C9q/sp94wj+CiV/IaU4Jr5humXWqMowBNQoY4LEpO6JXL ouvi7JxGDquzxJom+S1EUBoDC+dcbqN3HmZ+DB2o+AcxBFgI9zoQ7F4HI28s0yCIwX7+M65NH4g jQKKKMyeVGf81KpvxT0BCrhD2ecZIV685WlK9/FOLRmhtos/toT6W3xDsES3g= X-Google-Smtp-Source: AGHT+IEY4Bkjt/yYbrhofiHe25t6FYtL51Cgg0/pcmheFBExP5e5Z7qmADlL5vL1uqS/fVBKeLgjpg== X-Received: by 2002:a53:bdc5:0:b0:63f:2bc7:7074 with SMTP id 956f58d0204a3-6466a8aba62mr11525267d50.60.1766603261316; Wed, 24 Dec 2025 11:07:41 -0800 (PST) Received: from ?IPV6:2600:1700:4570:89a0:6872:f79a:c2ff:4f4f? ([2600:1700:4570:89a0:6872:f79a:c2ff:4f4f]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6466a8b16e2sm8621687d50.2.2025.12.24.11.07.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Dec 2025 11:07:40 -0800 (PST) Message-ID: Date: Wed, 24 Dec 2025 11:07:38 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] dt-bindings: mfd: maxim,max77759: add charger child node To: Krzysztof Kozlowski , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Lee Jones , Greg Kroah-Hartman , Badhri Jagan Sridharan , Heikki Krogerus , Peter Griffin , Tudor Ambarus , Alim Akhtar Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, RD Babiera , Kyle Tso References: <20251218-max77759-charger-v2-0-2b259980a686@google.com> <20251218-max77759-charger-v2-1-2b259980a686@google.com> <411802b6-517d-497e-bf7b-183e6e6d7a64@kernel.org> From: Amit Sunil Dhamne Content-Language: en-US In-Reply-To: <411802b6-517d-497e-bf7b-183e6e6d7a64@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Krzysztof, On 12/19/25 12:17 AM, Krzysztof Kozlowski wrote: > On 18/12/2025 23:49, Amit Sunil Dhamne via B4 Relay wrote: >> From: Amit Sunil Dhamne >> >> The Maxim MAX77759 MFD includes a charger function. Extend the max77759 >> binding to include the charger. Also, update the example to include >> charger. >> >> Signed-off-by: Amit Sunil Dhamne >> --- >> .../devicetree/bindings/mfd/maxim,max77759.yaml | 33 ++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77759.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77759.yaml >> index 525de9ab3c2b..1cffdf2e5776 100644 >> --- a/Documentation/devicetree/bindings/mfd/maxim,max77759.yaml >> +++ b/Documentation/devicetree/bindings/mfd/maxim,max77759.yaml >> @@ -37,6 +37,30 @@ properties: >> nvmem-0: >> $ref: /schemas/nvmem/maxim,max77759-nvmem.yaml >> >> + charger: >> + type: object >> + description: This is a dual input switch mode battery charger for portable >> + applications. It supports wired and wireless charging and can operate in >> + buck and boost mode. >> + > > I do not see any improvements, so same comment: this should be folded > into the parent. I misunderstood the folding comment for merging the charger binding into mfd. > Please read DTS 101 slides or writing bindings or any other talks... This gives a lot more context. Thanks for the pointer. I also reviewed a few recently merged mfd (with charger being a cell) patches as well. I realize that you're asking me to remove the charger node and re-anchor its properties to the pmic mfd device. I will update it in the next revision. BR, Amit > > Best regards, > Krzysztof