From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Lorenzo Stoakes <ljs@kernel.org>
Cc: David Laight <david.laight.linux@gmail.com>,
Yury Norov <ynorov@nvidia.com>,
Thorsten Blum <thorsten.blum@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Yury Norov <yury.norov@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/3] mm: add bytes_to_page_end() helper
Date: Mon, 18 May 2026 15:24:15 +0200 [thread overview]
Message-ID: <c36050a0-dafa-4dee-a5e9-2192a1e7b138@kernel.org> (raw)
In-Reply-To: <agsQZ6M3_mXC1OYj@lucifer>
On 5/18/26 15:15, Lorenzo Stoakes wrote:
> On Mon, May 18, 2026 at 03:06:16PM +0200, David Hildenbrand (Arm) wrote:
>> On 5/18/26 12:24, Lorenzo Stoakes wrote:
>>>
>>> Yeah please don't, that's already a weird situation I don't really love the idea
>>> of extending that.
>>>
>>> mm_types.h seems the more appropriate place.
>>
>> I think I'd prefer vdso/page.h for something as basic as that.
>>
>> But definitely no new header unless really unavoidable :)
>
> I just find vdso/page.h an extremely weird beast. what does the VDSO have to do
> with it and why are we smuggling some basic definitions there...
Yeah, I don't know the history of all that, but I know that BIT(), ALIGN() etc
are also in vdso/ ... and confused me in the past.
So as long as PAGE_MASK etc is in there, I guess adding simple helpers in there
as well is the right thing to do. (I don't know if the defines could be
reasonably moved at this point)
--
Cheers,
David
next prev parent reply other threads:[~2026-05-18 13:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 12:34 [PATCH 1/3] mm: move offset_in_page() to page_helpers.h Thorsten Blum
2026-05-17 12:34 ` [PATCH 2/3] mm: add bytes_to_page_end() helper Thorsten Blum
2026-05-17 15:28 ` Yury Norov
2026-05-18 6:48 ` Andy Shevchenko
2026-05-18 10:23 ` Lorenzo Stoakes
2026-05-18 11:53 ` William Kucharski
2026-05-18 9:09 ` David Laight
2026-05-18 10:24 ` Lorenzo Stoakes
2026-05-18 13:06 ` David Hildenbrand (Arm)
2026-05-18 13:15 ` Lorenzo Stoakes
2026-05-18 13:24 ` David Hildenbrand (Arm) [this message]
2026-05-18 13:38 ` Lorenzo Stoakes
2026-05-18 14:29 ` Thomas Weißschuh
2026-05-18 14:41 ` David Hildenbrand (Arm)
2026-05-18 14:52 ` Thomas Weißschuh
2026-05-18 15:32 ` David Hildenbrand (Arm)
2026-05-18 6:49 ` Andy Shevchenko
2026-05-18 10:24 ` Lorenzo Stoakes
2026-05-17 12:34 ` [PATCH 3/3] lib/bitmap: use " Thorsten Blum
2026-05-18 10:33 ` Lorenzo Stoakes
2026-05-18 15:29 ` Yury Norov
2026-05-18 6:51 ` [PATCH 1/3] mm: move offset_in_page() to page_helpers.h Andy Shevchenko
2026-05-18 10:02 ` Lorenzo Stoakes
2026-05-18 12:13 ` Thorsten Blum
2026-05-18 12:33 ` Lorenzo Stoakes
2026-05-18 13:36 ` Thorsten Blum
2026-05-18 14:03 ` Lorenzo Stoakes
2026-05-18 12:58 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c36050a0-dafa-4dee-a5e9-2192a1e7b138@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=david.laight.linux@gmail.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=thorsten.blum@linux.dev \
--cc=vbabka@kernel.org \
--cc=ynorov@nvidia.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome