From: Markus Elfring <Markus.Elfring@web.de>
To: Jianyun Gao <jianyungao89@gmail.com>,
linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev
Cc: LKML <linux-kernel@vger.kernel.org>,
Alison Schofield <alison.schofield@intel.com>,
Dan Williams <djbw@kernel.org>, Dave Jiang <dave.jiang@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>
Subject: Re: [PATCH] dax: fix dax_core_init error return code
Date: Mon, 12 Oct 2026 16:21:39 +0200 [thread overview]
Message-ID: <c37fdba1-0fd0-483e-bc0c-1767f2cd32be@web.de> (raw)
In-Reply-To: <20261011132017.31131-1-jianyungao89@gmail.com>
> dax_core_init() mistakenly returns 0 on error paths. Change the
> error return to use rc so the actual error code is propagated
> to the caller.
Please reconsider the proposed need for an additional label once more.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.3-rc7#n532
Regards,
Markus
next prev parent reply other threads:[~2026-10-12 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 13:20 jianyungao89
2026-10-12 14:21 ` Markus Elfring [this message]
2026-10-12 14:28 ` Jonathan Cameron
2026-10-12 15:01 ` Jianyun Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c37fdba1-0fd0-483e-bc0c-1767f2cd32be@web.de \
--to=markus.elfring@web.de \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=djbw@kernel.org \
--cc=jianyungao89@gmail.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®