From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4793BC32772 for ; Tue, 23 Aug 2022 15:17:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242474AbiHWPQ7 (ORCPT ); Tue, 23 Aug 2022 11:16:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243082AbiHWPNX (ORCPT ); Tue, 23 Aug 2022 11:13:23 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 525DE149A36 for ; Tue, 23 Aug 2022 03:23:36 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id u24so7489873lji.0 for ; Tue, 23 Aug 2022 03:23:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=yn5Cp9zoeWqGbxL3HM65C3eQTNCudh4CzSg5Uvw3JAk=; b=QAJc4lxwTmf0W3KWKXRjlw6qcyC3eHPyQ5QoGuhnvAn60+muAHk9sdN/Zcrm1cUMIq s/MnHrcCQNq3gmf9HYQNuccxGkfgpsLZL3+qnn86GSOLQoFZfN1u8KnQ3gDYLaOCKcgW fLKxap4SHvHxX6tr3L632x2JnYqbZa2/5J3CopLcqmYJfyGRzPyGN50TuOW8DZUOhphs zIJsqGjIJRIiRgqM/V447asxh+qfPATLOZ2Ic9S7QL+s5C7vfITWKfI8dfruPLKw483q WpUr3abO2RFu4eWv6TQUVEkjTKgPnmC0rnSEyrkHDsyWTtzGPQEzEXrNtaE6dS5IrIWZ Kyjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=yn5Cp9zoeWqGbxL3HM65C3eQTNCudh4CzSg5Uvw3JAk=; b=M8jWWP40UHhdkBuEX+uYFTDAgBka/jicjg/7FxsqBSiZpI3DC8h71mEt6Q+fxKxg1r ev7dvlFzWDfQE9NLfhJZ2T27j9/jmz5wTo426jKzwFEl4owDYQ6YHYxWsp3QBxzAbCD4 xotqljViVJ43Ui38ldxdoxnTwehupN9aYI4yAL5OP0/L+gnwp6FnwizzwmptCcjwo5pt XgcuA6RpBndIAWsD1D4yWaCI6DHr+kBwDtnXUoF8mN/59v4i5Y6S9sKiExOdWgDj5Xxt EkzB22AVLHZ8suqWOsJyUCYxxY6Ws2ftaT6ODow75vs/qmepfD7uLnEyLgktqDdauCHK 8zyQ== X-Gm-Message-State: ACgBeo1q46yU/pEKjUIP4vOonJHdq1ZQCYwsFxvxNBG1XFlJyJ+AEMtb Z9Tn8mPPE+hpP1qFtOdRf3QfXQ== X-Google-Smtp-Source: AA6agR4D5aExJIR72fiYWF97zzNBynY+4arB6wbMmJjNpCzNC+/Ov4i9Sl/PcwnVnQxQKarFz5l0fg== X-Received: by 2002:a05:651c:114b:b0:25b:e13b:6900 with SMTP id h11-20020a05651c114b00b0025be13b6900mr6417785ljo.462.1661250214179; Tue, 23 Aug 2022 03:23:34 -0700 (PDT) Received: from [192.168.0.11] (89-27-92-210.bb.dnainternet.fi. [89.27.92.210]) by smtp.gmail.com with ESMTPSA id c4-20020a196544000000b00489e2156285sm2434193lfj.104.2022.08.23.03.23.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 03:23:33 -0700 (PDT) Message-ID: Date: Tue, 23 Aug 2022 13:23:32 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH RESEND v10 6/7] clk: baikal-t1: Add DDR/PCIe directly controlled resets support Content-Language: en-US To: Serge Semin , Stephen Boyd , Michael Turquette , Philipp Zabel , Rob Herring , Krzysztof Kozlowski Cc: Serge Semin , Alexey Malahov , Pavel Parkhomenko , Thomas Bogendoerfer , linux-clk@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220822182934.23734-1-Sergey.Semin@baikalelectronics.ru> <20220822182934.23734-7-Sergey.Semin@baikalelectronics.ru> From: Krzysztof Kozlowski In-Reply-To: <20220822182934.23734-7-Sergey.Semin@baikalelectronics.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/08/2022 21:29, Serge Semin wrote: > Aside with a set of the trigger-like resets Baikal-T1 CCU provides two > additional blocks with directly controlled reset signals. In particular it > concerns DDR full and initial resets and various PCIe sub-domains resets. > Let's add the direct reset assertion/de-assertion of the corresponding > flags support into the Baikal-T1 CCU driver then. It will be required at > least for the PCIe platform driver. Obviously the DDR controller isn't > supposed to be fully reset in the kernel, so the corresponding controls > are added just for the sake of the interface implementation completeness. > > Signed-off-by: Serge Semin > Reviewed-by: Philipp Zabel > > --- > > Changelog v6: > - Refactor the code to support the linear reset IDs only. (@Philipp) > > Changelog v7: > - Drop empty line from the sys_rst_info structure initialization block. > (@Philipp) > --- > drivers/clk/baikal-t1/ccu-rst.c | 66 +++++++++++++++++++++++++++++ > drivers/clk/baikal-t1/ccu-rst.h | 10 +++++ > include/dt-bindings/reset/bt1-ccu.h | 9 ++++ Do not mix drivers and bindings. Bindings always go separately, so this has to be split. Best regards, Krzysztof