mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Leon Woestenberg" <leon.woestenberg@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: "Joe Korty" <joe.korty@ccur.com>, "mingo@elte.hu" <mingo@elte.hu>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] shrink printk timestamp field
Date: Sat, 30 Aug 2008 19:47:06 +0200	[thread overview]
Message-ID: <c384c5ea0808301047g7b3658can77b41e5906d306b6@mail.gmail.com> (raw)
In-Reply-To: <20080830101618.b6c2e1ab.akpm@linux-foundation.org>

Hello,

On Sat, Aug 30, 2008 at 7:16 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Sat, 30 Aug 2008 10:38:08 -0400 Joe Korty <joe.korty@ccur.com> wrote:
>> On Fri, Aug 29, 2008 at 07:35:40PM -0400, Andrew Morton wrote:
>> > On Wed, 27 Aug 2008 11:17:59 -0400 Joe Korty <joe.korty@ccur.com> wrote:
>> >
>> > > Shrink the printk timestamp field.
>>
>> I was looking at it from the point of view of finding out where the
>> boot process was too slow.  For that millisecs is enough.  I am not
>> sure where knowing printk output to the microsec would be useful for
>> solving anything.
>
> Of course it's useful.  If you're working on performance or latency in
> a disk, network or USB driver, microsecond resolution is about right.
>
I second this. If we have timestamps enables, let it be useful for all
current uses. The 3 digits extra are very cheap useful information in
that area (without resorting to more elaborate methods like the
recently merged latency tracer).

Rather than cut 3 digits off, maybe fix some of the too-wide prints
would solve the posters issue better.

Can we please have this patch non-committed or reverted?

Regards,
-- 
Leon

  reply	other threads:[~2008-08-30 17:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-27 15:17 Joe Korty
2008-08-28  9:38 ` Ingo Molnar
2008-08-29 23:35 ` Andrew Morton
2008-08-30 14:38   ` Joe Korty
2008-08-30 17:16     ` Andrew Morton
2008-08-30 17:47       ` Leon Woestenberg [this message]
2008-08-30 18:57         ` Joe Korty
2008-09-06 18:24           ` Ingo Molnar
2008-09-01  8:31       ` Benny Halevy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c384c5ea0808301047g7b3658can77b41e5906d306b6@mail.gmail.com \
    --to=leon.woestenberg@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=joe.korty@ccur.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®