From: "Leon Woestenberg" <leon.woestenberg@gmail.com>
To: "Boaz Harrosh" <bharrosh@panasas.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: scatterlist.c: bug in sg_next()?
Date: Sun, 28 Sep 2008 17:51:07 +0200 [thread overview]
Message-ID: <c384c5ea0809280851j59fe7201yda71b2101f4cb8e2@mail.gmail.com> (raw)
In-Reply-To: <48DFA285.1010701@panasas.com>
Hello,
On Sun, Sep 28, 2008 at 5:28 PM, Boaz Harrosh <bharrosh@panasas.com> wrote:
> Leon Woestenberg wrote:
>> In sg_next(), after following a chain_ptr, a few more checks should be
>> performed.
>> The rare case exists that the first entry in the chained list is a
>> last marker, in case NULL must be returned.
>
> No! the last marker is set on a valid sg entry. Only it's next
> is no longer valid. So the check at the top is for the Next-sg
> not the passed-in-sg. What you thought of is a NULL terminating
> sg-list. The end marker is so to save the extra NULL entry.
>
Ah yes, the lower bit magic. Thanks!
Sorry for the noise.
Regards,
--
Leon
prev parent reply other threads:[~2008-09-28 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-28 15:15 Leon Woestenberg
2008-09-28 15:28 ` Boaz Harrosh
2008-09-28 15:51 ` Leon Woestenberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c384c5ea0809280851j59fe7201yda71b2101f4cb8e2@mail.gmail.com \
--to=leon.woestenberg@gmail.com \
--cc=bharrosh@panasas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®