mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Leon Woestenberg <leon.woestenberg@gmail.com>
To: Tony Vroon <tony@linx.net>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Philip Langdale <philipl@overt.org>,
	Robert Hancock <hancockrwd@gmail.com>
Subject: Re: [PATCH 2.6.32 v3] Conditional MSI support for sata_nv
Date: Wed, 12 Aug 2009 19:03:05 +0200	[thread overview]
Message-ID: <c384c5ea0908121003x2f3eef3ejd8bc4a5aaa120793@mail.gmail.com> (raw)
In-Reply-To: <20090805235009.88C091007F@gold.linx.net>

Hello,

On Thu, Aug 6, 2009 at 1:50 AM, Tony Vroon<tony@linx.net> wrote:
> At least the nVidia MCP55 controller quite happily supports MSI.
> +static int msi_enabled;
> +       if (msi_enabled) {
> +               dev_printk(KERN_NOTICE, &pdev->dev, "Using MSI\n");
> +               pci_enable_msi(pdev);
> +       }
> +

I just saw this patch, didn't check the full sources.

Shouldn't there be a matching "if (msi_enabled)
pci_disabling_msi(pdev);" somewhere else?

Regards,

Leon.

  parent reply	other threads:[~2009-08-12 17:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-05 23:50 Tony Vroon
2009-08-12 10:26 ` Jeff Garzik
2009-08-12 17:03 ` Leon Woestenberg [this message]
2009-08-12 17:15   ` Tony Vroon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c384c5ea0908121003x2f3eef3ejd8bc4a5aaa120793@mail.gmail.com \
    --to=leon.woestenberg@gmail.com \
    --cc=hancockrwd@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipl@overt.org \
    --cc=tony@linx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®