From: Jens Axboe <axboe@kernel.dk>
To: "T.J. Mercier" <tjmercier@google.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] splice: remove duplicate noinline from pipe_clear_nowait
Date: Wed, 23 Apr 2025 14:10:39 -0600 [thread overview]
Message-ID: <c3880483-7cd6-4151-9af8-f6a1be9977c9@kernel.dk> (raw)
In-Reply-To: <20250423180025.2627670-1-tjmercier@google.com>
On 4/23/25 12:00 PM, T.J. Mercier wrote:
> pipe_clear_nowait has two noinline macros, but we only need one.
>
> I checked the whole tree, and this is the only occurrence:
>
> $ grep -r "noinline .* noinline"
> fs/splice.c:static noinline void noinline pipe_clear_nowait(struct file *file)
> $
Funky! Obivously looks fine:
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
next prev parent reply other threads:[~2025-04-23 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 18:00 T.J. Mercier
2025-04-23 20:10 ` Jens Axboe [this message]
2025-04-24 9:02 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3880483-7cd6-4151-9af8-f6a1be9977c9@kernel.dk \
--to=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tjmercier@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®