From: Krzysztof Kozlowski <krzk@kernel.org>
To: zain_zhou@realsil.com.cn, linux-staging@lists.linux.dev,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org
Cc: gregkh@linuxfoundation.org, alexandre.belloni@bootlin.com,
Frank.Li@nxp.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
wei_wang@realsil.com.cn
Subject: Re: [PATCH v2 2/2] staging: i3c: add Realtek RTS490x I3C HUB driver
Date: Mon, 25 May 2026 16:00:21 +0200 [thread overview]
Message-ID: <c38c3c96-a775-45a9-b2e0-64ed5d0a49d4@kernel.org> (raw)
In-Reply-To: <20260525125128.297-2-zain_zhou@realsil.com.cn>
On 25/05/2026 14:51, zain_zhou@realsil.com.cn wrote:
> From: Yin Zhou <zain_zhou@realsil.com.cn>
>
> Add driver for Realtek RTS490x series I3C HUB devices.
>
> The driver supports:
> - Device Tree based configuration of LDO, pull-up, IO strength
> and per-port mode (I3C/SMBus/GPIO/disabled)
> - Logical I3C bus registration per target port
> - SMBus agent functionality with IBI and polling modes
> - GPIO chip with IRQ support
> - DebugFS interface for register access and DT config inspection
> - IBI (In-Band Interrupt) handling
>
> The driver is placed in staging as it has known issues to be resolved
> before mainlining; see drivers/staging/rts490x/TODO for details.
>
> Signed-off-by: Yin Zhou <zain_zhou@realsil.com.cn>
>
> Changes in v2:
> - Update driver to match v2 DT binding: parse physical values
> directly via of_property_read_bool/u32; drop string enum lookup
> tables; update property names with realtek, prefix and unit suffixes
> - Fix maintainer name; move MAINTAINERS entry to driver patch
> - Code style: rename TPn_* macros to TPN_*; rename SMBus frequency
> constants to UPPER_CASE; add mutex field comments
> ---
> MAINTAINERS | 6 +
> drivers/staging/Kconfig | 2 +
> drivers/staging/Makefile | 1 +
> drivers/staging/rts490x/Kconfig | 16 +
> drivers/staging/rts490x/Makefile | 2 +
> drivers/staging/rts490x/TODO | 35 +
So this is staging driver? Then why do you send us bindings? We don't
need them. You must follow staging rules then.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-25 14:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 12:51 [PATCH v2 1/2] dt-bindings: i3c: add Realtek RTS490x I3C HUB zain_zhou
2026-05-25 12:51 ` [PATCH v2 2/2] staging: i3c: add Realtek RTS490x I3C HUB driver zain_zhou
2026-05-25 13:25 ` Alexandre Belloni
2026-05-25 14:00 ` Krzysztof Kozlowski [this message]
2026-05-25 19:11 ` Greg KH
2026-05-25 13:58 ` [PATCH v2 1/2] dt-bindings: i3c: add Realtek RTS490x I3C HUB Krzysztof Kozlowski
2026-05-25 18:45 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c38c3c96-a775-45a9-b2e0-64ed5d0a49d4@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=robh@kernel.org \
--cc=wei_wang@realsil.com.cn \
--cc=zain_zhou@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome